From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Vamsi Vytla <vamsi.vytla@gmail.com>
Cc: gordienkos@gmail.com, emacs-orgmode@gnu.org
Subject: Re: org-mobile-push and MobileOrg compatibility issue
Date: Sat, 05 Sep 2015 10:45:51 +0200 [thread overview]
Message-ID: <87pp1xjlts.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAMruYDRjAs0xFPcBXEkt7w2vOQdToCBzQrN65J+MPChORbWdzg@mail.gmail.com> (Vamsi Vytla's message of "Fri, 04 Sep 2015 22:28:33 +0000")
Hello,
Vamsi Vytla <vamsi.vytla@gmail.com> writes:
> M-x 'org-mobile-push', with the latest org-mode leaves the files
> incompatible with MobileOrg Android application. There have been no changes
> in MobileOrg for over a year.
>
> I bisected the latest org-mobile related changes and noticed that reverting
> this one line below "fixes" the issue (at least for me). Since there aren't
> any tests, it's hard to validate changes and understand things easily.
>
> If anybody can point me in the right direction, I would love to look into
> it further.
>
> Cheers!
>
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index 6c7c8d0..7e1127c 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -446,7 +446,7 @@ agenda view showing the flagged items."
> x))
> (cdr entry)))
> (insert "#+TODO: " (mapconcat 'identity kwds " ") "\n")
> - (setq dwds (or (member "|" kwds) (last kwds))
> + (setq dwds (member "|" kwds)
> twds (org-delete-all dwds kwds)
> todo-kwds (org-delete-all twds todo-kwds)
> done-kwds (org-delete-all dwds done-kwds)))
IIRC this change was introduced to fix another bug. It might be useful
to discuss with the author of this change. Another option is to use
(or (member "|" kwds) (cons "|" (last kwds)))
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2015-09-05 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-04 22:28 org-mobile-push and MobileOrg compatibility issue Vamsi Vytla
2015-09-05 8:45 ` Nicolas Goaziou [this message]
2015-10-12 17:42 ` Vamsi Vytla
2015-10-13 19:28 ` Chris Patti
2015-10-14 6:29 ` Eric S Fraga
2015-10-13 20:15 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pp1xjlts.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=gordienkos@gmail.com \
--cc=vamsi.vytla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.