From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alexis Newsgroups: gmane.emacs.devel Subject: Re: master 1be349c 1/2: * lisp/emacs-lisp/package.el: Define custom faces Date: Thu, 10 Sep 2015 21:31:26 +1000 Message-ID: <87pp1q4ik1.fsf@gmail.com> References: <20150806102825.25477.3457@vcs.savannah.gnu.org> <8737yspmmp.fsf@gnu.org> <87vbboo6mb.fsf@gnu.org> <87zj0y4l2k.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; format=flowed X-Trace: ger.gmane.org 1441884731 20946 80.91.229.3 (10 Sep 2015 11:32:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Sep 2015 11:32:11 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 10 13:32:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Za058-00018H-L2 for ged-emacs-devel@m.gmane.org; Thu, 10 Sep 2015 13:31:58 +0200 Original-Received: from localhost ([::1]:48594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za053-0007lz-2q for ged-emacs-devel@m.gmane.org; Thu, 10 Sep 2015 07:31:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za04o-0007lp-Ng for emacs-devel@gnu.org; Thu, 10 Sep 2015 07:31:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za04j-0007jf-5x for emacs-devel@gnu.org; Thu, 10 Sep 2015 07:31:38 -0400 Original-Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:35761) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za04j-0007hM-0L for emacs-devel@gnu.org; Thu, 10 Sep 2015 07:31:33 -0400 Original-Received: by pacfv12 with SMTP id fv12so41748423pac.2 for ; Thu, 10 Sep 2015 04:31:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:from:to:subject:in-reply-to:date:message-id:mime-version :content-type; bh=F0KQr/15L+Um9bTFV81xNQWyYw2j4JyUt1SLuR7e7zM=; b=DvNYOM17UOIceRutBXd5pMmNfG8PSFrYCivF+D3ZxU0tbeRCK02Zq5bYSb1D/nLGI1 0J86hDCLFEjjdJmnu/bnbB2h0gcxfS0hbuylbR1To25Ph+VikCjQ+laekgOrtB0K28L2 FkJsxKV5m726D04wMsp8jO7c+N2rUx8ChZotCboCWeZL0ciNUkdDdsww41r4aSKmqZdh oV8VqZhAEwQb5SdxZBtH54HTSjbXFwwlGx3iZnWfQiwe0fJxA2rVBYXrvHXk/Azp2yDH gNdAke9MUKcYQ/tEYZbIP/Yfw85CovHL/9bv5QsZkyVAaoiC3r+y7Y6WK/d5GZYGj4Xn QwBg== X-Received: by 10.68.107.133 with SMTP id hc5mr81535710pbb.5.1441884691393; Thu, 10 Sep 2015 04:31:31 -0700 (PDT) Original-Received: from localhost (ppp118-209-144-24.lns20.mel8.internode.on.net. [118.209.144.24]) by smtp.gmail.com with ESMTPSA id if9sm11512106pbc.89.2015.09.10.04.31.29 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Sep 2015 04:31:30 -0700 (PDT) In-reply-to: <87zj0y4l2k.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400e:c03::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189797 Archived-At: Oleh Krehel writes: > Is it actually a good idea not end with "-face"? I do it for all > my packages. And the reason is a very good one: I get completion > (completion-at-point, apropos, git-grep, CEDET tags, whatever) > for faces with "package-prefix.*-face". It's useful to > distinguish the face symbols from the variable symbols. Agreed. In my `picolisp-mode` package, i have a defface `picolisp-global-variable-face`, i.e. the face used for PicoLisp global variables. i feel that dropping '-face' from this wouldn't provide any concrete benefits to me or my users, and indeed, would prevent the sort of useful actions you describe. Alexis.