From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Asynchronous DNS Date: Mon, 22 Feb 2016 13:07:38 +1100 Message-ID: <87povpa45x.fsf@gnus.org> References: <87k2mmzkry.fsf@gnus.org> <83k2mlyet8.fsf@gnu.org> <87lh71nriy.fsf@gnus.org> <8637t8opla.fsf@realize.ch> <871t8skg6c.fsf@gnus.org> <86y4b0n5q2.fsf@realize.ch> <87fux7gb7o.fsf@gnus.org> <83wpqjvd2f.fsf@gnu.org> <87zivfobn4.fsf@gnus.org> <86y4ao5g1c.fsf@realize.ch> <87r3ggdo9f.fsf@gnus.org> <86twlb5yl4.fsf@realize.ch> <83d1rzz1mu.fsf@gnu.org> <86egcc49qu.fsf@realize.ch> <87io1k41cg.fsf@gnus.org> <86a8mv41s5.fsf@realize.ch> <8660xj40ky.fsf@realize.ch> <87r3g6iybb.fsf@gnus.org> <87bn7ahiit.fsf@gnus.org> <86povp3nbk.fsf@realize.ch> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456106913 23496 80.91.229.3 (22 Feb 2016 02:08:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 22 Feb 2016 02:08:33 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alain Schneble Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 22 03:08:24 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXfvD-0005ld-MK for ged-emacs-devel@m.gmane.org; Mon, 22 Feb 2016 03:08:23 +0100 Original-Received: from localhost ([::1]:45852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXfvC-0007st-Tp for ged-emacs-devel@m.gmane.org; Sun, 21 Feb 2016 21:08:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXfuz-0007sb-JQ for emacs-devel@gnu.org; Sun, 21 Feb 2016 21:08:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXfuv-0000U9-IS for emacs-devel@gnu.org; Sun, 21 Feb 2016 21:08:09 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:58029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXfuv-0000U3-BQ for emacs-devel@gnu.org; Sun, 21 Feb 2016 21:08:05 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aXfuY-0007oL-MS; Mon, 22 Feb 2016 03:07:43 +0100 In-Reply-To: <86povp3nbk.fsf@realize.ch> (Alain Schneble's message of "Sun, 21 Feb 2016 19:55:43 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aXfuY-0007oL-MS MailScanner-NULL-Check: 1456711663.39994@GX3AgsDmLhIOLVo3CLbDFg X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200418 Archived-At: Alain Schneble writes: > Just two minor points that came to my mind right now: > > - Shouldn't the printf statements -- that were used for debugging > purposes -- be removed before merging to master? See also attached > patch below. I think the "blocker" messages should perhaps be turned into those "log them to the *Messages* buffer" warnings. Err... that's add_to_log, I guess. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no