From: Lars Ingebrigtsen <larsi@gnus.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 12413@debbugs.gnu.org
Subject: bug#12413: 24.2.50; M-j should be bound to default-indent-new-line
Date: Wed, 24 Feb 2016 17:11:35 +1100 [thread overview]
Message-ID: <87povmd4dk.fsf@gnus.org> (raw)
In-Reply-To: <504F05EA.6000703@yandex.ru> (Dmitry Gutov's message of "Tue, 11 Sep 2012 13:35:38 +0400")
Dmitry Gutov <dgutov@yandex.ru> writes:
> A major mode can change the value of comment-line-break-function, but
> currently it's only used from `do-auto-fill'. I think that doesn't make
> sense, the value should affect the M-j command, too.
>
> default-indent-new-line does pretty much that. The function could use a
> better name, though - it isn't used in any variables as default value.
[...]
I think this makes sense, but it wasn't applied at the time (three years
ago). Is this still an issue?
> (define-key esc-map ";" 'comment-dwim)
> -(define-key esc-map "j" 'indent-new-comment-line)
> -(define-key esc-map "\C-j" 'indent-new-comment-line)
> +(define-key esc-map "j" 'default-indent-new-line)
> +(define-key esc-map "\C-j" 'default-indent-new-line)
> (define-key ctl-x-map ";" 'comment-set-column)
> (define-key ctl-x-map "f" 'set-fill-column)
> (define-key ctl-x-map "$" 'set-selective-display)
>
> === modified file 'lisp/simple.el'
> --- lisp/simple.el 2012-09-07 08:58:31 +0000
> +++ lisp/simple.el 2012-09-11 06:34:40 +0000
> @@ -5501,7 +5501,7 @@
>
> (defun default-indent-new-line (&optional soft)
> "Break line at point and indent.
> -If a comment syntax is defined, call `comment-indent-new-line'.
> +If a comment syntax is defined, call `comment-line-break-function'.
>
> The inserted newline is marked hard if variable `use-hard-newlines' is true,
> unless optional argument SOFT is non-nil."
>
> === modified file 'lisp/textmodes/refill.el'
> --- lisp/textmodes/refill.el 2012-07-11 23:13:41 +0000
> +++ lisp/textmodes/refill.el 2012-09-11 06:50:28 +0000
> @@ -179,7 +179,7 @@
> (refill-fill-paragraph-at refill-doit)
> (setq refill-doit nil)))
> ((or `quoted-insert `fill-paragraph `fill-region) nil)
> - ((or `newline `newline-and-indent `open-line `indent-new-comment-line
> + ((or `newline `newline-and-indent `open-line `default-indent-new-line
> `reindent-then-newline-and-indent)
> ;; Don't zap what was just inserted.
> (save-excursion
>
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-02-24 6:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 9:35 bug#12413: 24.2.50; M-j should be bound to default-indent-new-line Dmitry Gutov
2016-02-24 6:11 ` Lars Ingebrigtsen [this message]
2016-02-24 15:04 ` Dmitry Gutov
2016-02-25 5:43 ` Lars Ingebrigtsen
2019-06-27 14:58 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87povmd4dk.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=12413@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.