From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolaus Rath Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Tue, 08 Mar 2016 08:08:54 -0800 Message-ID: <87pov554vd.fsf@thinkpad.rath.org> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <64a52598-ad53-498c-993c-67d7827dbdfc@default> <838u1uuuau.fsf@gnu.org> <878u1um2xl.fsf@thinkpad.rath.org> <87io0xedoh.fsf@vostro.rath.org> <87fuw179tb.fsf@ericabrahamsen.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1457453379 28274 80.91.229.3 (8 Mar 2016 16:09:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 16:09:39 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 17:09:20 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adKCE-00007E-4j for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 17:09:18 +0100 Original-Received: from localhost ([::1]:35547 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKCD-0007f4-9E for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 11:09:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKBw-0007eE-Ef for emacs-devel@gnu.org; Tue, 08 Mar 2016 11:09:01 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adKBt-0001gH-M2 for emacs-devel@gnu.org; Tue, 08 Mar 2016 11:09:00 -0500 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:49694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adKBt-0001g8-G0 for emacs-devel@gnu.org; Tue, 08 Mar 2016 11:08:57 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B8CFB20EA9 for ; Tue, 8 Mar 2016 11:08:56 -0500 (EST) Original-Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 08 Mar 2016 11:08:56 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-sasl-enc:x-sasl-enc; s=smtpout; bh=nAhtIHlsCPD6UQ0 qJX+OCtQT7rw=; b=NJla0Z1LG2nz3qoacBJx7zCjBQXNyqU5lHsEQiHz4XIVyaP 1Lgq6llJkkG3ukUmu5W/uKs+eF6iyi/Rj5KocstXW8+oanEIpACx1dOwmPSeFOa0 N98XO0JCC4OoBrpVcJaPghgvmeU9Fi4h2YtYewXA8fuB1ch05zrhRD2/+ekA= X-Sasl-enc: hhRapRES+SOQEdkG27pinSkhqrj3yW3bG8EnVgX4La1K 1457453336 Original-Received: from ebox.rath.org (ebox.rath.org [45.79.69.51]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F150C00021 for ; Tue, 8 Mar 2016 11:08:56 -0500 (EST) Original-Received: from thinkpad.rath.org (thinkpad [192.168.12.2]) by ebox.rath.org (Postfix) with ESMTPS id 8FE9620D955 for ; Tue, 8 Mar 2016 16:08:55 +0000 (UTC) Original-Received: by thinkpad.rath.org (Postfix, from userid 1000) id 30833C01DF; Tue, 8 Mar 2016 08:08:55 -0800 (PST) Mail-Copies-To: never Mail-Followup-To: emacs-devel@gnu.org In-Reply-To: <87fuw179tb.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 08 Mar 2016 14:39:12 +0800") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201159 Archived-At: On Mar 08 2016, Eric Abrahamsen wrote: > Nikolaus Rath writes: > >> On Mar 07 2016, Stefan Monnier wrote: >>>> When I submitted my first Emacs patch, I was astonished when I was ask= ed >>>> to re-submit with my commit message essentially duplicated in the >>>> ChangeLog. >>> >>> I can't remember ever asking this kind of duplication. We used to >>> duplicate the ChangeLog-info in the ChangeLog file and in the commit >>> message (tho we stopped doing it a year ago), but we never asked for it >>> to be duplicated in the email messages that submits a patch. >>> >>> So I have the impression that I'm misunderstanding you. Could you >>> describe more precisely the kind of duplication you're talking about? >> >> No, you understood me correctly. However, I've just looked this up again >> and it turns out I was actually submitting a patch to Gnus, not >> Emacs. It was eventually committed by Eric Abrahamsen to the Gnus git >> repo, who first asked me to re-submit my patch with a commit message >> that was formatted like a Changelog entry, and to duplicate the message >> in the ChangeLog itself. It seemed to me that he considered that a >> questionable practice himself, but said it was obligatory because Gnus >> closely followed the Emacs standards here. >> >> >> Unfortunately that discussion never made it into the bug >> (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D20956), so I'm >> paraphrasing from memory. But I'm pretty sure I'm remembering correctly, >> because I was so surprised by this. > > Not duplicating it in the email, just commit message + ChangeLog > duplication. This may be getting conflated with me asking for the commit > to be emailed as a git-format-patch attachment, which was just because I > was lazy (and it also preserves the author/committer distinction). Actually, I was quite happy about that. I very much prefer if patches that I submit also have me as the author of the commit. (Eric, I think my last email sounded a bit like telling on you. I'm sorry about that, I think I should have written it differently (or asked you first). I'm very grateful for the time you took to help me with those patches, and for patiently explaining the rationale for the format). Best, -Nikolaus --=20 GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F =C2=BBTime flies like an arrow, fruit flies like a Banana.=C2= =AB