From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: vc-state and unregistered Date: Sun, 24 Apr 2016 21:41:20 +0200 Message-ID: <87pote94m7.fsf@gmx.de> References: <6ok2vyzwf9.fsf@fencepost.gnu.org> <08f70cda-44be-0657-e50a-2b2c80d2c21c@yandex.ru> <87oa9dzgl0.fsf@gmx.de> <87potshczh.fsf@gmx.de> <87bn57otja.fsf_-_@gmx.de> <515b3451-820d-ad50-8c98-d0330a0f4266@yandex.ru> <87lh4arpbg.fsf@gmx.de> <87ega2rodp.fsf@gmx.de> <87vb37ury1.fsf@gmx.de> <87potfuqdt.fsf@gmx.de> <557a2987-39e8-051e-55fd-678bc01a6a40@yandex.ru> <87lh43upd9.fsf@gmx.de> <80b86343-9324-1de0-e66c-a02e80467740@yandex.ru> <87k2jmzxh5.fsf@gmx.de> <27facefd-4eb5-fa1f-4d72-66ac160c5478@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461526902 18880 80.91.229.3 (24 Apr 2016 19:41:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 19:41:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 24 21:41:33 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auPuL-0007ZA-Tb for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 21:41:30 +0200 Original-Received: from localhost ([::1]:56404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auPuL-0006Wj-EY for ged-emacs-devel@m.gmane.org; Sun, 24 Apr 2016 15:41:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auPuI-0006U0-2J for emacs-devel@gnu.org; Sun, 24 Apr 2016 15:41:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auPuE-0000LD-S0 for emacs-devel@gnu.org; Sun, 24 Apr 2016 15:41:25 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:51728) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auPuE-0000L9-JH for emacs-devel@gnu.org; Sun, 24 Apr 2016 15:41:22 -0400 Original-Received: from detlef.gmx.de ([79.195.30.210]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MWkZL-1bEYFm0a3n-00Xw1u; Sun, 24 Apr 2016 21:41:21 +0200 In-Reply-To: <27facefd-4eb5-fa1f-4d72-66ac160c5478@yandex.ru> (Dmitry Gutov's message of "Sun, 24 Apr 2016 21:58:36 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-Provags-ID: V03:K0:o6/EElnehrQ8AO/ml64Zn5uKdCIfQwZtncOR7F91SQMsyUCBbVu u0kgtX8lnujLQGNEz5+NkJAfvo24BzoVItICdJnzmIQqqKcU+Ptvy1dhVZmhRlFxjOctbrE ZfK39zdtSC+ygb/T/iptscJYn7xvvQiUm4mu7bxW1YN/2ZyLUctm4sLM2YfWA/mWYvRXIve inKXFYMErjmLnAJa0qPzw== X-UI-Out-Filterresults: notjunk:1;V01:K0:NsHFoi/wvYg=:aEA7NLSJABUm0RhISsamKH jiCUKbewEyvA7TkbRFBiHAvt320HxQmJN3AcuJWIf0nEbANHK8eUaGueBV2yFMqyDEG+nIgV8 ihQ28x290P02soBakoJyhDlGiWRd0AUhv4D5b9vdv8O20kltQwLpeEJAIUuAm11wMrUAvThxT 47IYCN2LiKEBE7yP0YZ4XIndhoOK7FzJ2JCl7JV7k+SGlxIlus47fNCOnnP1KH//Q7Z66na3T Nb9QevpKlzPdlCaANZ3p2bSmmx+/d/yFDCKEKOenLo24P+IbkNC3OpnVZJlBK12qnCPhYj65H /u6r0fMItHoa/jkZKO7xrJviprT/ox8/m53Z2VB7stbHpUrJQNxN3zWqaCgJaR+x5n1KWHNzj S4UrAXtRjjG3vz7jCgSzQTiYQGfym0E6HYw/5DEBuOZrmvgxuomdAMMfkR/K9et2s4g4Z7NG/ C5esMNZzaDEvW3CCN07iUVzNYcbj3lRXTA9uhT3S5j7VoeOHdesuHNHnatWgotgr0ggZbCrX+ BPYlk6Juf9EhgCDZ/LN8qcaDzJT+V6C9BhWXtJK1owdxCMZAA9hRn2i6MKZe3AYnwZuwgGZjc JlACDNxKhx3DFa/3ZMULtbMveydl2BKLRgMFi/7dJ9IE0esJwFwx/ekNzXY4NJdzf00TzgSYO PYQvT1OSF7eAqn+1QWGbc2Xvo0XcW9w31hx6bkXBltBxho/vKLN00lOy8noDIpxUZjhY2ba+h bC4yrsiWO2fFylIHqOFHlXOmJCPPVMhAfUCE7BVCHpjwNY1KOmmNMuBfLOCa852ZffGkdQST X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203275 Archived-At: Dmitry Gutov writes: >> See the docstring of vc-state: >> >> "A return of nil from this function means we have no information on the >> status of this file." >> >> I would expect this for files which are located in a directory not under >> version control. None of the tests in vc-tests.el cover this case. > > And if buffer-file-name is outside of any version control, does your > version of vc-state return nil? No. I didn't test this. As said, the tests must be improved, that's what they are good for. And bugs must be fixed. But for the other cases, files under version control, my last commits have shown improvements I believe. That's why I find your reaction to revert everything ... annoying.