From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Drew Adams <drew.adams@oracle.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions'
Date: Thu, 28 Apr 2016 23:37:42 +0200 [thread overview]
Message-ID: <87pot94dp5.fsf@gnus.org> (raw)
In-Reply-To: <jwv60v1tuxf.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Thu, 28 Apr 2016 15:09:33 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> --- a/lisp/icomplete.el
>> +++ b/lisp/icomplete.el
>> @@ -388,6 +388,9 @@ matches exist."
>> (progn ;;(debug (format "Candidates=%S field=%S" candidates name))
>> (format " %sNo matches%s" open-bracket close-bracket))
>> (if last (setcdr last nil))
>> + (when (and minibuffer-completing-file-name
>> + icomplete-with-completion-tables)
>> + (setq comps (completion-pcm--filename-try-filter comps)))
>> (let* ((most-try
>> (if (and base-size (> base-size 0))
>> (completion-try-completion
>
> Yuck. We should really extend completion-tables yet a bit more
> (probably via the completion-metadata or completion-extra-properties) so
> we don't need to check minibuffer-completing-file-name and we can use
> similar features in other completions.
Should I revert the patch?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-04-28 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160428173225.3631.60149@vcs.savannah.gnu.org>
[not found] ` <E1avpnd-0000xB-Qt@vcs.savannah.gnu.org>
2016-04-28 19:09 ` [Emacs-diffs] master 65797b1: Make icomplete respect `completion-ignored-extensions' Stefan Monnier
2016-04-28 21:37 ` Lars Ingebrigtsen [this message]
2016-04-30 13:33 ` Stefan Monnier
2016-04-30 14:22 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pot94dp5.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.