From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 18204@debbugs.gnu.org
Subject: bug#18204: 24.4.50; `ediff-file-compressed-p'
Date: Sat, 30 Apr 2016 02:38:01 +0200 [thread overview]
Message-ID: <87pot8szh2.fsf@gnus.org> (raw)
In-Reply-To: <15f9dfe5-6bb6-4a94-9755-8c75cbb0eb70@default> (Drew Adams's message of "Tue, 5 Aug 2014 14:49:29 -0700 (PDT)")
Drew Adams <drew.adams@oracle.com> writes:
> Could be improved from this:
>
> (defun ediff-file-compressed-p (file)
> (condition-case nil
> (require 'jka-compr)
> (error))
> (if (featurep 'jka-compr)
> (string-match (jka-compr-build-file-regexp) file)))
>
> to this:
>
> (defun ediff-file-compressed-p (file)
> (and (require 'jka-compr nil t)
> (string-match-p (jka-compr-build-file-regexp) file)))
Probably written that way for backwards compatibility.
I've now simplified it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2016-04-30 0:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 21:49 bug#18204: 24.4.50; `ediff-file-compressed-p' Drew Adams
2016-04-30 0:38 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pot8szh2.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=18204@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.