From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.bugs Subject: bug#22295: viper-mode undo bug introduced between Nov 10 and Nov 14 Date: Tue, 17 May 2016 23:35:32 +0100 Message-ID: <87posk8g97.fsf@russet.org.uk> References: <83vb2h6lfq.fsf@gnu.org> <83r3d56jrg.fsf@gnu.org> <87poso7nf5.fsf@russet.org.uk> <878tzatbte.fsf@russet.org.uk> <83zirq3qt4.fsf@gnu.org> <5739FFDD.8080206@cs.stonybrook.edu> <87futh5axw.fsf@russet.org.uk> <573B2517.4010102@cs.stonybrook.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1463535762 9884 80.91.229.3 (18 May 2016 01:42:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 May 2016 01:42:42 +0000 (UTC) Cc: 22295@debbugs.gnu.org, Jim Meyering To: Michael Kifer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 18 03:42:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b2qVK-00020j-O4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 May 2016 03:42:30 +0200 Original-Received: from localhost ([::1]:41977 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qVG-00059r-LQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 May 2016 21:42:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qPQ-0006zS-R7 for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:36:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2nco-0005m8-Ay for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 18:38:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2nco-0005lj-7n for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 18:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1b2ncn-0002lQ-U5 for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 18:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: phillip.lord@russet.org.uk (Phillip Lord) Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 May 2016 22:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22295 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22295-submit@debbugs.gnu.org id=B22295.146352465610593 (code B ref 22295); Tue, 17 May 2016 22:38:01 +0000 Original-Received: (at 22295) by debbugs.gnu.org; 17 May 2016 22:37:36 +0000 Original-Received: from localhost ([127.0.0.1]:56336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2ncO-0002kn-99 for submit@debbugs.gnu.org; Tue, 17 May 2016 18:37:36 -0400 Original-Received: from cloud103.planethippo.com ([31.216.48.48]:49981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2ncM-0002ka-As for 22295@debbugs.gnu.org; Tue, 17 May 2016 18:37:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:References:Message-ID :Date:In-Reply-To:Subject:Cc:To:From; bh=uMJl+C8NId2XhvwTbfSaiaNS6SAhvXHrzgT8JKYltzw=; b=y0hv05VMASvg0VBeqi2QvSpGcJ Xq9ZD468MyGxgeUzHPGkZP8wZebihz7w9Un3bpaxrdbVaNuobXjiAVpRwFYT9ci9VYmFdSCHu+9OC XJqsxzQEBvM8eqWxo+ltMZtDd8VsMG81Qe4whlYGWkjidZ1i443qV4SqT5W0z5tVNAlxvVdWBGWGR 7K8wZGS8pOXZMtMEHRt6NoDfqsfuIQVtJOWPi0pqyqLUq/ngYEo0kHIRSgQovN1qccd/gdXnIHuO4 3OW13184uSNSqQbz7TVf+Wr/gcw8wPQK5UftqrVRSh2Yx8hlxGSkAjKhiygarrFNlxqt5gXXoVGV3 PYZn70sg==; Original-Received: from cpc1-benw10-2-0-cust373.gate.cable.virginm.net ([77.98.219.118]:52111 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.86_1) (envelope-from ) id 1b2ncG-002mQC-4p; Tue, 17 May 2016 23:37:28 +0100 In-Reply-To: <573B2517.4010102@cs.stonybrook.edu> (Michael Kifer's message of "Tue, 17 May 2016 10:05:11 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:118362 Archived-At: Michael Kifer writes: > I used to have (may still have) access to Solaris where the One True > Vi could still be found :-) True, vim undo is slightly different. But > I am not sure there was a vim back when viper started. Besides, the > '.' came from a precursor of viper, introduced by someone else, so I > am not responsible :-) After all these years using it I prefer the > viper behavior. Trying to preserve the old behaviour (i.e. before I broke it!) is the best I can offer then! > Anyway, I have sent more code upstream. It changes the implementation, > but (hopefully) will preserve the currrent behaviour. > > Cool, thanks! Please do send me any test cases that do not work. I've got ert unit tests working now, so I can use any set of keypresses on a clean buffer with the expected output (preferable as a keyboard macro, but I can convert a description!). Phil