all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Eli Zaretskii <eliz@gnu.org>
Cc: larsi@gnus.org, 23967@debbugs.gnu.org
Subject: bug#23967: 25.1.50; Slow compilation of ns-win.el
Date: Thu, 14 Jul 2016 23:22:54 -0400	[thread overview]
Message-ID: <87poqfega9.fsf@users.sourceforge.net> (raw)
In-Reply-To: <83inw88e3k.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 14 Jul 2016 17:54:23 +0300")

[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> However, I'm worried that we have no test for ucs-normalize, so it's
> hard to be sure the non-trivial functionality is unchanged, even
> though your changes are pretty straightforward.
>
> How about adding a test that uses the data in this file:
>
>   http://www.unicode.org/Public/UNIDATA/NormalizationTest.txt
>
> ucs-normalize claims to have passed an old version of this, but I see
> no existing way of re-running that test, did I miss something?

I don't see any evidence of an existing test.  I stared writing a new
one, and it's failing with the original ucs-normalize.el (or I'm
misunderstanding the requirements).

The first invariant to test is

    c2 ==  toNFC(c1) ==  toNFC(c2) == toNFC(c3)

(cX is column X, columns numbered from 1).

Line 15131 of NormalizationTest.txt has
# c1   c2      c3
1112E;1112E;11131 11127;1112E;11131 11127; # (◌𑄮; ◌𑄮; ◌𑄱◌𑄧; ◌𑄮; ◌𑄱◌𑄧; ) CHAKMA VOWEL SIGN O

So I think toNFC(c3) == c2 is equivalent to

    (equal (ucs-normalize-NFC-string
            (string #x11131 #x11127))
           (string #x1112E))

which gives nil.

Lines 15131 to 15139 and 16149 to 16289 are failing.  To check
invariants for a single line, load the attached ucs-normalize-tests.el,
put point at the beginning of the line and evaluate

        (ucs-normalize-tests--invariants-hold-p
         (ucs-normalize-tests--parse-column)
         (ucs-normalize-tests--parse-column)
         (ucs-normalize-tests--parse-column)
         (ucs-normalize-tests--parse-column)
         (ucs-normalize-tests--parse-column))


[-- Attachment #2: initial ucs-normalize.el file --]
[-- Type: application/emacs-lisp, Size: 5935 bytes --]

  reply	other threads:[~2016-07-15  3:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13 12:19 bug#23967: 25.1.50; Slow compilation of ns-win.el Lars Ingebrigtsen
2016-07-13 14:55 ` Eli Zaretskii
2016-07-13 21:15   ` Noam Postavsky
2016-07-14 14:54     ` Eli Zaretskii
2016-07-15  3:22       ` npostavs [this message]
2016-07-15  7:21         ` Eli Zaretskii
2016-07-16  2:46           ` npostavs
2016-07-16  6:43             ` Eli Zaretskii
2016-07-16 17:03               ` npostavs
2016-07-16 17:20                 ` Lars Ingebrigtsen
2016-07-17 16:20       ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87poqfega9.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=23967@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.