From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: debbugs tracker builds character Date: Thu, 21 Jul 2016 16:11:40 -0400 Message-ID: <87poq6iweb.fsf@ericabrahamsen.net> References: <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87twg2g86g.fsf@lifelogs.com> <83eg76n5h5.fsf@gnu.org> <87y45eeoor.fsf@lifelogs.com> <577D42BB.1020500@cs.ucla.edu> <87oa694rfw.fsf@russet.org.uk> <837fcxlbay.fsf@gnu.org> <87lh1d2wg5.fsf@russet.org.uk> <83eg75jk5h.fsf@gnu.org> <87lh1cb6p0.fsf@lifelogs.com> <87oa5sa176.fsf_-_@lifelogs.com> <874m7kmkcm.fsf@gmx.de> <871t2o6t94.fsf@gmx.de> <87wpkf6pup.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1469134966 10312 80.91.229.3 (21 Jul 2016 21:02:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 21:02:46 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 23:02:31 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQL6z-00005Q-KM for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 23:02:29 +0200 Original-Received: from localhost ([::1]:43719 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL6z-0004o6-02 for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 17:02:29 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL6X-0004dT-TY for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:02:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQL6V-0002iU-7m for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:02:01 -0400 Original-Received: from plane.gmane.org ([80.91.229.3]:56876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQL6U-0002i9-Sk for emacs-devel@gnu.org; Thu, 21 Jul 2016 17:01:59 -0400 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bQL6S-0008Ab-G5 for emacs-devel@gnu.org; Thu, 21 Jul 2016 23:01:56 +0200 Original-Received: from otwaon234vw-lp140-05-1176444371.dsl.bell.ca ([70.31.29.211]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 21 Jul 2016 23:01:56 +0200 Original-Received: from eric by otwaon234vw-lp140-05-1176444371.dsl.bell.ca with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 21 Jul 2016 23:01:56 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 150 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: otwaon234vw-lp140-05-1176444371.dsl.bell.ca User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:ptkWIapAF0HwnuMsKBArspS5xP8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205996 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: > SM> I think I'm starting to see what you mean. You're talking about a tight > SM> integration where a pull-request is also itself an issue, so the comments > SM> can be directly on the patch itself. As opposed to having issues and > SM> pull-request be two separate things that can refer to each other via > SM> an indirection. > >> Yes. Actually Github has both of these right now. When pull requests are >> not true issues, they tend to be associated with issues: sometimes >> 1-to-N and sometimes N-to-1. People have different workflows, so it's >> good to have flexibility built into the model. Sorry if this seems >> ambivalent; it's really a degree of creative freedom that users >> appreciate. > > So, we could start by setting up a Gitlab or Kallithea instance for > Emacs and use it for pull-requests, while we keep using Debbugs for > issue tracking. > > This lets us move forward on the pull-request and code-review front > without having to solve the "issue" of switching to another bug-tracker. > > EA> A suggestion from a part-time package maintainer: make > EA> `report-emacs-bug' prompt for a package, and offer the results of > EA> `featurep' as completion. If the user picks a package that only exists > EA> in ELPA, email the package maintainer with the bug report. >> That's a really good suggestion, regardless of the underlying bug tracker. > > I also like this idea. Patches welcome, Here's a patch. I hope I've used all the proper utility functions for finding libraries and extracting headers. So far as I can tell, debbugs doesn't keep track of "bug subscriptions", and putting the package maintainer in the Cc header is all we need to do, right? Anyhow, I'm sure this will require tweaking, but take a look and let me know. Also, I've included a second patch to `lm-maintainer', which is (I hope) a fairly minor fix. Eric --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Cc-package-maintainers-when-reporting-emacs-bugs.patch >From 347d5a0935a671e4a1401925ecff0ca2c4c7a277 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Thu, 21 Jul 2016 15:58:47 -0400 Subject: [PATCH 1/2] Cc package maintainers when reporting emacs bugs * lisp/mail/emacsbug.el (report-emacs-bug): Prompt for a package to report a bug against, and cc the package maintainer, if any, on the bug report. --- lisp/mail/emacsbug.el | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index 18eaa22..ce3b60c 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -144,11 +144,14 @@ message-send-mail-function (defvar message-sendmail-envelope-from) ;;;###autoload -(defun report-emacs-bug (topic &optional unused) +(defun report-emacs-bug (topic package &optional unused) "Report a bug in GNU Emacs. Prompts for bug subject. Leaves you in a mail buffer." (declare (advertised-calling-convention (topic) "24.5")) - (interactive "sBug Subject: ") + (interactive (list + (read-string "Bug Subject: ") + (when (bound-and-true-p package--initialized) + (completing-read "Package: " package-alist)))) ;; The syntax `version;' is preferred to `[version]' because the ;; latter could be mistakenly stripped by mailing software. (if (eq system-type 'ms-dos) @@ -158,6 +161,9 @@ report-emacs-bug (let ((from-buffer (current-buffer)) (can-insert-mail (or (report-emacs-bug-can-use-xdg-email) (report-emacs-bug-can-use-osx-open))) + (cc (when (and package (null (string= package "emacs"))) + (require 'finder) + (lm-maintainer (find-library-name package)))) user-point message-end-point) (setq message-end-point (with-current-buffer (messages-buffer) @@ -184,6 +190,13 @@ report-emacs-bug (when (and (not message-sendmail-envelope-from) (message-bogus-recipient-p (message-make-address))) (set (make-local-variable 'message-sendmail-envelope-from) 'header))) + (when (cdr cc) ;; The cdr is the email address. + (if (eq major-mode 'message-mode) + (message-goto-cc) + (mail-cc)) + (if (car cc) + (insert (format "%s <%s>" (car cc) (cdr cc))) + (insert (format "%s" (cdr cc))))) (rfc822-goto-eoh) (forward-line 1) ;; Move the mail signature to the proper place. -- 2.9.0 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0002-lm-maintainer-should-pass-file-arg-to-lm-authors.patch >From fd9fec872ba4799dae4718cd5716f96c97d4b823 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Thu, 21 Jul 2016 16:00:20 -0400 Subject: [PATCH 2/2] lm-maintainer should pass file arg to lm-authors * lisp/emacs-lisp/lisp-mnt.el (lm-maintainer): If `lm-maintainer' ends up calling `lm-authors', it should pass the optional FILE arg to that call. --- lisp/emacs-lisp/lisp-mnt.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/lisp-mnt.el b/lisp/emacs-lisp/lisp-mnt.el index 46373da..604f472 100644 --- a/lisp/emacs-lisp/lisp-mnt.el +++ b/lisp/emacs-lisp/lisp-mnt.el @@ -393,7 +393,7 @@ lm-maintainer (let ((maint (lm-header "maintainer"))) (if maint (lm-crack-address maint) - (car (lm-authors)))))) + (car (lm-authors file)))))) (defun lm-creation-date (&optional file) "Return the created date given in file FILE, or current buffer if FILE is nil." -- 2.9.0 --=-=-=--