From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#24313: [PATCH] Add tests for dom.el Date: Sun, 28 Aug 2016 11:21:30 +0200 Message-ID: <87poottfj9.fsf@gmx.de> References: <1472235970.16843.0@smtp.gmail.com> <1472374727.3660.0@smtp.gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1472376139 13376 195.159.176.226 (28 Aug 2016 09:22:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Aug 2016 09:22:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: Lars Ingebrigtsen , 24313@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 28 11:22:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdwIA-0002rO-HS for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2016 11:22:14 +0200 Original-Received: from localhost ([::1]:38621 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdwI7-0003q5-VJ for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Aug 2016 05:22:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdwI2-0003py-0l for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 05:22:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bdwHy-0006Cn-Qf for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 05:22:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:44763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bdwHy-0006Cd-N1 for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 05:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bdwHy-0002we-Jn for bug-gnu-emacs@gnu.org; Sun, 28 Aug 2016 05:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Aug 2016 09:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24313 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24313-submit@debbugs.gnu.org id=B24313.147237610311295 (code B ref 24313); Sun, 28 Aug 2016 09:22:02 +0000 Original-Received: (at 24313) by debbugs.gnu.org; 28 Aug 2016 09:21:43 +0000 Original-Received: from localhost ([127.0.0.1]:42475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdwHf-0002w7-EL for submit@debbugs.gnu.org; Sun, 28 Aug 2016 05:21:43 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:63041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bdwHe-0002vv-75 for 24313@debbugs.gnu.org; Sun, 28 Aug 2016 05:21:42 -0400 Original-Received: from detlef.gmx.de ([87.146.62.18]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MB2G8-1bnneT3Wqa-009zaE; Sun, 28 Aug 2016 11:21:34 +0200 In-Reply-To: <1472374727.3660.0@smtp.gmail.com> ("Simen \=\?utf-8\?Q\?Heggest\?\= \=\?utf-8\?Q\?\=C3\=B8yl\=22's\?\= message of "Sun, 28 Aug 2016 10:58:47 +0200") X-Provags-ID: V03:K0:zziHU2hhRBn7dmPhi9pSVsWxZ+XMjOKRUyLGQwZQRRHyARlg8Zm wpLOPwzjSvvW3jY6WrCjSgODj2Xqc7RowirpTrbBTiPDzF5fs3ll4ldeqhUzCJfg4WQcdu9 eWboi2aB9fjsOJ5j9ssc+dqBno31dy+nnB0jjB9hhtR7MuG0uyqQji04kWNcGy4n21Lh3SL O3ixxwPG5euZs5AdT2/Tw== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZPLHXtZ2VHU=:4lahG76+XHL5Q5UvD75pn1 Y+E+tROR0plMF/ljCI4AkYrPkS13G+uv3wTHnxYmqUyJPOKwTe92RiCbx0U+bpziqjN6volgK Mp/yYB13I1gBMQuLlDolEH5JeGkI/Usjc8aTF4sc/tYCI7MG/TdixRAI6EA5rrc0s9yVtgkMo 5MuCssrdeoYQE79dADGCIoOPWElx83xGM6vag4MmXCDzpJBGa5ULhhXbpGBJiHINPKECwyhh7 FumFcoXseAT6eVWD5oCm9756hv7fvwvvUFTuYFNZ9uSataQlUZ/Ne0jP/02eR7t7bUJtMmHHp ymo6548KQ9zVTj6RSUHyynXUWnHJBEz4Aw2+urkhC+iaW/0FaOUvek02BmL1VIRx0DQaLNRZ4 XG77UWsueuyc4QvKXBWe3M+sFEoRo0iMVgDGEylvUQGRnv8kmtXF18mXTc8T7mQ6CXTjThlrl Qzjq9xP9Ts/r3CbeJdawZksCaZUJODQrKIO+V3TOb5bSOqIHjv0Ki6TAbK+BwJm+QaZhk6uwJ i45R+gL96nR/vYNf9qUBJbWRhvCDAnISBziOFuAnPkpfI5pP+jmy4/6YV/HilVJwsYwU5fVYw e0DfN036zQzcLWJOTwTNYoeqj198n4PRMZ7AD6JF3IUrQvGn2XVzI0tMszmbCqEtI/GywRNY9 l6KSHWdtDeqCCHyv00ohfCFpd0aJo1ITu7mSiJoPuVaY7rSL4MWlYzH+7fe7Ucv3DfHOfOZBw ojRy4TTVmcluhXAuGWCIjjVCv0LPbCFWrcOXsRH4o50t+7VgL4kJmH/6CvRe1jIHb/Yu5EBT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122738 Archived-At: Simen Heggest=C3=B8yl writes: Hi Simen, >> It would also be nice if you could add a docstring per test. > > Does it any value to such trivial test cases? For most of these I don't > think there's more to add than "Tests .", which is > already conveyed by the name of the test. It depends. Likely you are right, but sometimes it might be worth to note also what is NOT covered by a test, or to mention possible side effects which are tested implicitely. But it is your decision, of course. > Thank you all for the feedback. > > -- Simen Best regards, Michael.