all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dima Kogan <dima@secretsauce.net>
To: Alan Mackenzie <acm@muc.de>
Cc: 25362@debbugs.gnu.org
Subject: bug#25362: 26.0.50; comment-region goes into an infinite loop
Date: Mon, 09 Jan 2017 13:46:28 -0800	[thread overview]
Message-ID: <87pojvlxe3.fsf@secretsauce.net> (raw)
In-Reply-To: <20170109211801.GA4752@acm.fritz.box>

Alan Mackenzie <acm@muc.de> writes:

> Hello again, Dima.
>
> As already observed, this bug happens simply in C Mode by attempting to
> comment out the four lines inside the function, doing this by marking
> the lines then C-c C-c.
>
> The cause was a rather nasty situation where a "syntactic whitespace
> cache", designed to facilitate moving rapidly over large areas of WS
> (particularly long comments at the beginning of files) got screwed up by
> the insertion of "// " onto a line already containing a "//" later on.
>
> Here is a patch.  It is not yet in its final form (the comments need
> fixing).  Would you please try it out and let me know how well/how badly
> it works:

Hi. I'm now running with this patch, and some cursory testing says that
it works. I briefly ran into an issue where I

1. highlighted a problematic region
2. hit M-; (this worked correctly)
3. Hit M-/ to undo

This undo restored the text correctly, but the whole region remained
highlighted as a comment, even after the undo removed the comment
characters. I hit this once, but cannot reproduce it anymore. If this
description means something to you, feel free to act on it :)


> Thanks for this rather obscure bug report.  :-)

Heh. I just report issues that pop up during the course of the day. We
owe you hugely for responding to these bugs and maintaining cc-mode.
Thanks!





  reply	other threads:[~2017-01-09 21:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 23:37 bug#25362: 26.0.50; comment-region goes into an infinite loop Dima Kogan
2017-01-05 20:54 ` Alan Mackenzie
2017-01-06  7:41   ` Eli Zaretskii
2017-01-06  9:32     ` Alan Mackenzie
2017-01-06  9:37       ` Eli Zaretskii
2017-01-06  9:41         ` Alan Mackenzie
2017-01-07  8:20         ` Alan Mackenzie
2017-01-07  9:44           ` Eli Zaretskii
2017-01-07 10:27             ` Alan Mackenzie
     [not found]             ` <20170107162907.GC3499@acm.fritz.box>
2017-01-07 16:31               ` Eli Zaretskii
2017-01-09 21:18 ` Alan Mackenzie
2017-01-09 21:46   ` Dima Kogan [this message]
2017-01-09 22:04     ` Alan Mackenzie
2017-01-11 18:32       ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pojvlxe3.fsf@secretsauce.net \
    --to=dima@secretsauce.net \
    --cc=25362@debbugs.gnu.org \
    --cc=acm@muc.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.