From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#25641: 25.1; insert-char function inconsistency Date: Wed, 08 Feb 2017 22:43:50 +0100 Message-ID: <87poisgxyh.fsf@rosalinde> References: <83tw8656gf.fsf@gnu.org> <87a89y6ifh.fsf@rosalinde> <87inok7rjf.fsf@rosalinde> <83zihw4lh7.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1486590543 4963 195.159.176.226 (8 Feb 2017 21:49:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 8 Feb 2017 21:49:03 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: programingfrik@gmail.com, 25641@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 08 22:48:55 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cba6f-0000h0-5R for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 22:48:53 +0100 Original-Received: from localhost ([::1]:33403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cba6k-0000kh-Ry for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 Feb 2017 16:48:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cba32-0006J6-5D for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 16:45:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cba2w-0002rd-KU for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 16:45:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34161) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cba2w-0002rZ-Hd for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 16:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cba2w-00010W-CS for bug-gnu-emacs@gnu.org; Wed, 08 Feb 2017 16:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2017 21:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25641 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 25641-submit@debbugs.gnu.org id=B25641.14865902463788 (code B ref 25641); Wed, 08 Feb 2017 21:45:02 +0000 Original-Received: (at 25641) by debbugs.gnu.org; 8 Feb 2017 21:44:06 +0000 Original-Received: from localhost ([127.0.0.1]:60593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cba21-0000z2-Nf for submit@debbugs.gnu.org; Wed, 08 Feb 2017 16:44:05 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:50523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cba1z-0000yJ-Hh for 25641@debbugs.gnu.org; Wed, 08 Feb 2017 16:44:04 -0500 Original-Received: from rosalinde ([62.214.227.193]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LgqEs-1c7Dcn262o-00oF7b; Wed, 08 Feb 2017 22:43:51 +0100 In-Reply-To: <83zihw4lh7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 08 Feb 2017 19:54:12 +0200") X-Provags-ID: V03:K0:5mxUA7fIuc7CCdFDG4/Su42HBkdsxa9EposNXSwFmADSHl8jQNq F6Aoq8OmLaQ57BMILNhRajGEYCcA985tx8yCroGEbrJ8axdbo7YkyVZEZiKzopTT+lT03zZ F7jrEtPVFCr2z5x38RYK20sO5Z367lxJPxu+Eza6+bqKgz5Wp/mnM/UUodCXdP5TUYOZV4A 6S5xorLVkk2q8XVRYPQ3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:TY4e70yf6Ps=:sRPnc3AO2eSEAvWkzcxCcW QccXyeU385gdXZlJHJUqb1D94z4G41NiIHBJi9RYo2eLSnAfZrDgr8UacdoQviwoUcekl4Q+S 5KlIFnsK/NXRHOsvYSsNCl68eVTkRvEdhOiIdn58YXjIi0dOQ6Sa5KmuUamqwq/VMWLFjjm/7 r80fCSNKsGQPUB4RryjAGvqRRPMly5ow1DOW8/YGAtb/kKorggHWv7PQg8w6r3CSck/1015l0 ZE6rjiwNeiCxvnGRjGOH9zADnzwCQ4bt5Z7S9YjRtFWEaYn+ETM41T5YxV3cwhHOu85gb13Pm uXnTpcyYxyYGvJFdZaKbt+wWaLJhZ3+OcrwC4/XTDFDtXM9PTttf5X2H/Mhp+AHKEF3YhLzAG dtt5SpUzLEx8KqjwE0Oo7Wyw6cvraw9BqkbgDdWaPN2vSONNx9ZjsSVYJCC+250tYgBZnX5bF b+L2ysCJW0Vituji7SILXqq8F64/ij5v9ohYm+BgFZXj5etO08jGnH/OmNHJy3LxlrqhGkkM0 Jk5/Zju5u/6HxZE2un4eWPdscWpOqHPPVhQHYXdbqDaAFA1xvgDvGNOkQrbytMbOKMFRkBdHY B/JR5+5za49YuaidfO/GIaPoHD9L6ApVJ5B1SlGQbpJfrheXxg7Tt5jG8pgFsus38p+qEa29B IFnxsYIQxMnOOEAnp5Tu1plqVf7hXPUjNcOrYWaQL3HFObHaSJdIY4GNo1/nRtyonZ+ai0QbU vEw6TOf68mNskJwX4vt2XoXV8TJkzAbGajHi+N4syB7JrgoodfcenNsInX/4A1BiQ3OLiQoq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:129133 Archived-At: On Wed, 08 Feb 2017 19:54:12 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Wed, 08 Feb 2017 14:15:00 +0100 >> Cc: 25641@debbugs.gnu.org >> >> I agree. The following patch does that (the special-casing here has a >> precedent in ucs-names in mule-cmds.el, from which the comment is >> copied): >> >> diff --git a/lisp/descr-text.el b/lisp/descr-text.el >> index 3971dbb..a1efb67 100644 >> --- a/lisp/descr-text.el >> +++ b/lisp/descr-text.el >> @@ -617,7 +617,14 @@ describe-char >> "input method") >> (list >> (let ((name >> - (or (get-char-code-property char 'name) >> + (or (when (= char 7) >> + ;; Special case for "BELL" which is >> + ;; apparently the only char which >> + ;; doesn't have a new name and whose >> + ;; old-name is shadowed by a newer char >> + ;; with that name. >> + (car (rassoc char ucs-names))) >> + (get-char-code-property char 'name) >> (get-char-code-property char 'old-name)))) >> (if (and name (assoc-string name (ucs-names))) >> (format >> >> Eli, what do you say? > > I don't mind, but ucs-names might be nil if the function by the same > name was not yet called, so I think we should call it first. Oh yes, I should have noticed that. > Also, I think it would be good to mention this bug report in the > comment. Done and pushed to master as 90f76eb. Steve Berman