bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[Mohammed Sadiq]

When enabiling yas-minor-mode in xml files, I get the following
error logged into *Messages*, and yas doesn't work:

xml-find-file-coding-system: Invalid function: with-coding-priority

both GNU Emacs and yasnippet are from git master.

Thanks.


In GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.7)
 of 2017-02-25 built on rose
Repository revision: ecbd5f9ac6eb2d31241657bbb3e3f9b860391054
Windowing system distributor 'The X.Org Foundation', version 11.0.11901000
System Description:	Debian GNU/Linux 9.0 (stretch)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list...

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF GSETTINGS
NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD

Important settings:
  value of $LC_MONETARY: en_GB.UTF-8
  value of $LC_NUMERIC: en_GB.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message puny seq byte-opt subr-x gv
bytecomp byte-compile cl-extra help-mode cconv cl-loaddefs pcase cl-lib
dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec
password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils time-date mule-util tooltip eldoc electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow isearch timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript case-table epa-hook jka-cmpr-hook help
simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote dbusbind inotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 96649 9551)
 (symbols 48 20169 1)
 (miscs 40 42 154)
 (strings 32 17702 4866)
 (string-bytes 1 564959)
 (vectors 16 14640)
 (vector-slots 8 482496 4589)
 (floats 8 49 67)
 (intervals 56 215 0)
 (buffers 976 12))

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[npostavs]

Mohammed Sadiq <sadiq@sadiqpk.org> writes:

> When enabiling yas-minor-mode in xml files, I get the following
> error logged into *Messages*, and yas doesn't work:
>
> xml-find-file-coding-system: Invalid function: with-coding-priority
>
> both GNU Emacs and yasnippet are from git master.

I'm not able to reproduce.  Can you give a recipe starting from 'emacs
-Q'?  Perhaps the contents of the xml file is significant?

Can you get a backtrace with debug-on-error?

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[Mohammed Sadiq]

> On February 27, 2017 at 8:15 AM npostavs@users.sourceforge.net wrote:
> I'm not able to reproduce.  Can you give a recipe starting from 'emacs
> -Q'?  Perhaps the contents of the xml file is significant?
> 
> Can you get a backtrace with debug-on-error?

Sure. Here is my .emacs:

(setq debug-on-error t)

(package-initialize)
(require 'yasnippet)
(yas-global-mode 1)


How I opened emacs (the test.xml file don't really exists)
(Also note: emacs -Q test.xml also spits the same error. So this has *nothing to do with
yasnippet*, which I initially thought):

emacs test.xml

Here is the output in debugger when I opened emacs:
Debugger entered--Lisp error: (invalid-function with-coding-priority)
  with-coding-priority((utf-8) undecided)
  xml-find-file-coding-system((insert-file-contents "/home/sadiq/test.xml" t nil nil nil))
  insert-file-contents("~/test.xml" t)
  find-file-noselect-1(#<buffer test.xml> "~/test.xml" nil nil "~/test.xml" nil)
  find-file-noselect("/home/sadiq/test.xml")
   #[1285 "\x03\204\x0f^@\301\302\x02\"\207\303\304\x02!\x05\"\305\x01!\x06\x06\x01\x06\b\242B\240\210\211q\210\x04\242\306U\2043^@eb\210\x04\242Sy\210\x04\306\240\210\x03\242\307W\204D^@\310\x04\242S!\210\x03\306\240\207" [file-name-absolute-p message "Ignoring relative file name (%s) due to nil default-directory" expand-file-name command-line-normalize-file-name find-file-noselect 0 1 move-to-column] 10 "\n\n(fn DISPLAYABLE-BUFFERS DIR LINE COLUMN NAME)"]((nil) "~/" (0) (0) "test.xml")
  command-line-1(("test.xml"))
  command-line()
  normal-top-level()


Note: I have replaced \0 (^@) with real ^@, to not get truncated at \0

I installed yasnippet from https://github.com/joaotavora/yasnippet HEAD from master (but, as I
said, this isn't an issue with yasnippet).

This issue is present only in the git master branch of GNU Emacs.

Thanks

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[npostavs]

Mohammed Sadiq <sadiq@sadiqpk.org> writes:
>
> Here is the output in debugger when I opened emacs:
> Debugger entered--Lisp error: (invalid-function with-coding-priority)
>   with-coding-priority((utf-8) undecided)
>   xml-find-file-coding-system((insert-file-contents "/home/sadiq/test.xml" t nil nil nil))
>   insert-file-contents("~/test.xml" t)

It looks like `xml-find-file-coding-system' was miscompiled,
`with-coding-priority' is supposed to be a macro.  Can you see if 'make
bootstrap' fixes it?

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[Mohammed Sadiq]

> On February 27, 2017 at 9:12 AM npostavs@users.sourceforge.net wrote:
> It looks like xml-find-file-coding-system' was miscompiled,with-coding-priority' is supposed to be a macro. Can you see if 'make
> bootstrap' fixes it?

That didn't fix. What I did:
git clean -xfd (from emacs repo),
make bootstrap
sudo make uninstall (to uninstall the previous installation)
sudo make install

I'm on Debian GNU/Linux (current testing). I have a package named emacsen-common (version 2.0.8) installed on my system. Can that be a reason for this?

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[npostavs]

tags 25885 confirmed
retitle 25885 26.0.50; 'invalid-function with-coding-priority' when opening xml file
quit

Mohammed Sadiq <sadiq@sadiqpk.org> writes:

>> On February 27, 2017 at 9:12 AM npostavs@users.sourceforge.net wrote:
>> It looks like xml-find-file-coding-system&#39; was miscompiled,with-coding-priority' is supposed to be a macro. Can you see if 'make
>> bootstrap' fixes it?
>
> That didn't fix. What I did:
> git clean -xfd (from emacs repo),
> make bootstrap
> sudo make uninstall (to uninstall the previous installation)
> sudo make install

Ah, I tried doing 'make bootstrap' on my end, and now I can reproduce
this too.

with-coding-priority is an autoloaded Lisp macro in ‘mule-util.el’.
Phillip, is it possible this is another side-effect of the ldefs-boot
change?

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[Support]

Hi,

I can confirm that builds before commit c2469c50e8 don't have the "XML
loading" issue as described by Mohammed in the original post.; the
latest builds from master (currently  4da7aaa3a8daf) (still) have it. So
it could have something to do with the ldefs changes (I didn't perform a
complete bisect).

Running GNU Emacs 26.0.50 on x86_64-w64-mingw32, compiled on MSYS2.



Cheers,


Peter Mosmans

bug#25885: 26.0.50; yas-minor-mode fails to load with xml files

[npostavs]

tags 25885 fixed
close 25885 
quit

npostavs@users.sourceforge.net writes:
>
> Ah, I tried doing 'make bootstrap' on my end, and now I can reproduce
> this too.

Support <support@go-forward.net> writes:

>
> I can confirm that builds before commit c2469c50e8 don't have the "XML
> loading" issue as described by Mohammed in the original post.; the
> latest builds from master (currently  4da7aaa3a8dafb) (still) have it. So
> it could have something to do with the ldefs changes (I didn't perform a
> complete bisect).

Seems to be fixed now, probably one of the changes below:

542a763281 * Revert "Replace ldefs-boot with a much smaller file"
e37bfd4154 * Revert "Record autoloads till emacs dump"
7f5ad6b3c0 * Revert "Remove unused ldefs-boot.el"
41ed3c3da6 * Revert "Remove conditional includes from bootstrap"
8f58747a87 * Revert "Speed generation of ldefs-boot-auto"
11436e2890 * Revert "Fix minor problems with loaddefs autogeneration"

7b5e1c8238 * Speed generation of ldefs-boot-auto
7572740653 * Add error handling to magic-mode-alist
1b94630518 * Remove conditional includes from bootstrap
514a14ffd8 * Do not use find-file non-interactively