Bug in org-mobile-get-outline-path-link

Bug in org-mobile-get-outline-path-link

[Ian Dunn]

I recently tried turning off 'org-mobile-force-id-on-agenda-items', only
to find that there were problems updating agenda tasks.  I poked around
in the code and found that 'org-mobile-locate-entry' looks for an OLP in
the form olp:file:/path/to/heading, and
'org-mobile-get-outline-path-link' stores it as
olp:file/path/to/heading.

I've attached a patch to fix the latter function.

--
Ian Dunn

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index f6ef18f10..12e6c84b3 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
   (org-with-point-at pom
     (concat "olp:"
 	    (org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
-	    "/"
+	    ":"
 	    (mapconcat 'org-mobile-escape-olp
 		       (org-get-outline-path)
 		       "/")

Re: Bug in org-mobile-get-outline-path-link

[Nicolas Goaziou]

Hello,

Ian Dunn <dunni@gnu.org> writes:

> I recently tried turning off 'org-mobile-force-id-on-agenda-items', only
> to find that there were problems updating agenda tasks.  I poked around
> in the code and found that 'org-mobile-locate-entry' looks for an OLP in
> the form olp:file:/path/to/heading, and
> 'org-mobile-get-outline-path-link' stores it as
> olp:file/path/to/heading.
>
> I've attached a patch to fix the latter function.
>
> --
> Ian Dunn
>
> diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
> index f6ef18f10..12e6c84b3 100644
> --- a/lisp/org-mobile.el
> +++ b/lisp/org-mobile.el
> @@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
>    (org-with-point-at pom
>      (concat "olp:"
>  	    (org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
> -	    "/"
> +	    ":"
>  	    (mapconcat 'org-mobile-escape-olp
>  		       (org-get-outline-path)
>  		       "/")

It looks good. Could you provide the same patch using git format-patch,
along with a proper commit message?

Thank you.

Regards,

-- 
Nicolas Goaziou

[PATCH] Fix bug in mobile outline path handling

[Ian Dunn]

* org-mobile.el (org-mobile-get-outline-path-link): Use a `:' after file instead of a `/'
---
 lisp/org-mobile.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index f6ef18f10..12e6c84b3 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -648,7 +648,7 @@ The table of checksums is written to the file mobile-checksums."
   (org-with-point-at pom
     (concat "olp:"
 	    (org-mobile-escape-olp (file-name-nondirectory buffer-file-name))
-	    "/"
+	    ":"
 	    (mapconcat 'org-mobile-escape-olp
 		       (org-get-outline-path)
 		       "/")
-- 
2.12.2

Re: [PATCH] Fix bug in mobile outline path handling

[Nicolas Goaziou]

Hello,

Ian Dunn <dunni@gnu.org> writes:

> * org-mobile.el (org-mobile-get-outline-path-link): Use a `:' after
> file instead of a `/'

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou