From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#28412: Acknowledgement (26.0.50; Let save-some-buffers accept write-contents-functions) Date: Mon, 11 Sep 2017 14:41:08 -0700 Message-ID: <87poawhq17.fsf@ericabrahamsen.net> References: <87bmmikyug.fsf@ericabrahamsen.net> <87mv62jjr5.fsf@ericabrahamsen.net> <83zia1s2f6.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505166215 16562 195.159.176.226 (11 Sep 2017 21:43:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Sep 2017 21:43:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) Cc: 28412@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 11 23:43:31 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drWU1-00038W-D0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 23:43:09 +0200 Original-Received: from localhost ([::1]:60745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drWU8-0007ik-Hb for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Sep 2017 17:43:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drWTz-0007fd-Aa for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 17:43:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drWTu-0006Oh-Cd for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 17:43:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53772) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1drWTu-0006OF-9C for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 17:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1drWTt-0000K2-UP for bug-gnu-emacs@gnu.org; Mon, 11 Sep 2017 17:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Sep 2017 21:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28412 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28412-submit@debbugs.gnu.org id=B28412.15051661531195 (code B ref 28412); Mon, 11 Sep 2017 21:43:01 +0000 Original-Received: (at 28412) by debbugs.gnu.org; 11 Sep 2017 21:42:33 +0000 Original-Received: from localhost ([127.0.0.1]:34220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drWTR-0000JD-3h for submit@debbugs.gnu.org; Mon, 11 Sep 2017 17:42:33 -0400 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:56253) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1drWTP-0000J6-KR for 28412@debbugs.gnu.org; Mon, 11 Sep 2017 17:42:31 -0400 Original-Received: from localhost (71-35-182-76.tukw.qwest.net [71.35.182.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id ED376C02AF; Mon, 11 Sep 2017 21:42:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1505166150; bh=epwtvGQ1ExQy7iYrr44qvroqWNkj02Zfw98dgDQZOzQ=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=o3/nc3GXbaCr83pb5R60WO9wz0AKIB+pZQ9XTLHGHpzjV1hSIMtxPnJ/QAHcXQ9T0 nG/6VKaTynEH0PcB8gOTZjGvQyS6QDNbkxWc+p0bRsuKzQun55Ll2PQt6+GBFqlBuE 1Bu9swvp3DRlS7n2IbkIVxUjA0g2tbuRvHVHUdgc= In-Reply-To: <83zia1s2f6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Sep 2017 18:03:25 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136813 Archived-At: > Thanks. Can we have some simple tests for this, both with and without > visiting a file? Is this sufficient, do you think? (ert-deftest files-test-no-file-write-contents () "Test that `write-contents-functions' permits saving a file. Usually `basic-save-buffer' will prompt for a file name if the current buffer has none. It should first call the functions in `write-contents-functions', and if one of them returns non-nil, consider the buffer saved, without prompting for a file name (Bug#28412)." (let ((read-file-name-function (lambda (&rest _ignore) (error "Prompting for file name")))) ;; With contents function, and no file. (with-temp-buffer (setq write-contents-functions (list (lambda () t))) (set-buffer-modified-p t) (should (null (save-buffer)))) ;; With no contents function and no file. This should reach the ;; `read-file-name' prompt. (with-temp-buffer (set-buffer-modified-p t) (should-error (save-buffer) :type 'error)) ;; Then a buffer visiting a file: should save normally. (files-tests--with-temp-file temp-file-name (with-current-buffer (find-file-noselect temp-file-name) (setq write-contents-functions nil) (insert "p") (should (null (save-buffer))) (should (eq (buffer-size) 1))))))