From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Date: Tue, 19 Sep 2017 09:03:34 -0700 Message-ID: <87poambrqh.fsf@ericabrahamsen.net> References: <20170918202953.21378.63492@vcs0.savannah.gnu.org> <20170918202955.5043420AC4@vcs0.savannah.gnu.org> <87ingfcrf6.fsf@ericabrahamsen.net> <87377id77h.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1505837155 22377 195.159.176.226 (19 Sep 2017 16:05:55 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Sep 2017 16:05:55 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 19 18:05:47 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duL1u-0005Ti-Lq for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 18:05:46 +0200 Original-Received: from localhost ([::1]:43937 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duL21-0001hm-PS for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 12:05:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duL08-0000qm-Ca for emacs-devel@gnu.org; Tue, 19 Sep 2017 12:03:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duL05-0007mY-Kj for emacs-devel@gnu.org; Tue, 19 Sep 2017 12:03:56 -0400 Original-Received: from [195.159.176.226] (port=54714 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duL05-0007lN-DG for emacs-devel@gnu.org; Tue, 19 Sep 2017 12:03:53 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1duKzs-0008MD-Ff for emacs-devel@gnu.org; Tue, 19 Sep 2017 18:03:40 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 16 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:+Dm7oYerkQ9rTdwea/XnP5qtggM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218522 Archived-At: Stefan Monnier writes: >> Ie maybe I should just revert the change to this function, and make sure >> to set `buffer-offer-save' to t in my use-case. No one will get >> surprised by save prompts they didn't ask for. That way I could also >> remove the buffer name check. > > If that works, then it sounds good. You could add a note in the > docstring of write-contents-function about the use of buffer-offer-save > to make sure someone else doesn't follow the same longwinded path you did. I'll kick the tires a bit (we've got tests!) and push a fix when it seems ready. Thanks, Eric