From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Newsgroups: gmane.emacs.devel Subject: Re: Flymake refactored Date: Tue, 10 Oct 2017 16:20:33 +0100 Message-ID: <87po9v9ghq.fsf@gmail.com> References: <87mv566yjx.fsf@udel.edu> <87shex276r.fsf@gmail.com> <87efqh2sud.fsf@udel.edu> <20171006151753.tmdunffovz7olhey@logos.localdomain> <87h8vbx7p3.fsf@gmail.com> <20171007181824.k6pf2ztgxyodmx4a@logos.localdomain> <87376uxb3s.fsf@gmail.com> <20171008125156.q22u2tya5ygfbwja@logos.localdomain> <87mv51w7j0.fsf@gmail.com> <20171010142729.r7mgfmlkk6jvrnt6@logos.localdomain> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1507648937 30817 195.159.176.226 (10 Oct 2017 15:22:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Oct 2017 15:22:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: emacs-devel@gnu.org, Simen =?utf-8?Q?Heggest=C3=B8yl?= , dgutov@yandex.ru, Steve Purcell , sdl.web@gmail.com, monnier@iro.umontreal.ca To: Mark Oteiza Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 10 17:22:06 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e1wM4-0006FH-Cl for ged-emacs-devel@m.gmane.org; Tue, 10 Oct 2017 17:22:00 +0200 Original-Received: from localhost ([::1]:35599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1wMB-0000aJ-Eu for ged-emacs-devel@m.gmane.org; Tue, 10 Oct 2017 11:22:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e1wKp-0000Kx-Cy for emacs-devel@gnu.org; Tue, 10 Oct 2017 11:20:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e1wKk-0007nu-GR for emacs-devel@gnu.org; Tue, 10 Oct 2017 11:20:43 -0400 Original-Received: from mail-wm0-x230.google.com ([2a00:1450:400c:c09::230]:53256) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e1wKk-0007nG-AE for emacs-devel@gnu.org; Tue, 10 Oct 2017 11:20:38 -0400 Original-Received: by mail-wm0-x230.google.com with SMTP id q132so6387961wmd.2 for ; Tue, 10 Oct 2017 08:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=UdGIbSxaZL2fUpmwsD2bs0ve3cc6mhdXaHV7JIRRvJg=; b=jKv96EecDogk2R9/98E5kt22gJUhTIXjGnucZ26fJTHr0HldxjAiNfZpLY/NDGg7X9 thaVCW3MYfUffTPVZSrjID2sUZN8HVB8OEqpmgVXrA9kq/WkW7YtkD0usDWyFxNinXQ3 38tBWQSjDGDUV7fIvUWIplYI+g2i09mHHL5uQ8unTeb64qkWlysMXhYuFZWRiR0EWBIN u3O/wrR2KCQtyD9SC/6FxptHRljZLI4pI3uLsUtN4f2bza0BSCSefWOkA4BssRHjs7qC VOv4v6Ei9sCgtnwsRzzaK/Cmfomk5FqEWqxdpzDw5VWTA+WrK2v4OTIgPMNQd7zR9aTP 39ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=UdGIbSxaZL2fUpmwsD2bs0ve3cc6mhdXaHV7JIRRvJg=; b=WU6lWFziQw0r5A8miWY7rCHK+/GWbpaNOln0UHFf+C50tt2Qdw9vMu5v5bHphLRvDz pvC5d7ALIb6oduMdJxEwj6UuHKOqZ6zCqhz/ZOWgagEpmpRVDXguNlgyRog9kLJjDQr2 4nSAtPw7slM2lg9NHI8QvtmKPpjwZqQ43VQX4c7P4qpuI8mAGb57wwvSYEHJqPJ+rvYo 21N80aXQ1VIbDjr6xLaMhds253wuRoddwcoyRtaIT2PmMUDvDZ/KzeOmrdLybC4zzDyY fYWFrqdOcAxwlhwcpELjfgInE1js9bNItlvMMiGhxi4Ye7c0DW/z8C4Kfg+NygdNwFjE gm8w== X-Gm-Message-State: AMCzsaVIQkt85gNotF0FrmgMD0DxvqrfXJ/mxUhcL0QPLvv2sfQekQfC qufu8OR1TvK8yMXht7HYsuI= X-Google-Smtp-Source: AOwi7QD5esvqbJ4Ezg583YJ5Now1uAL5lYjH0WIZsTi9T/5utB+sxilfQvp1gMcI1S1YdQaoL4FJOQ== X-Received: by 10.223.182.156 with SMTP id j28mr14502766wre.46.1507648837313; Tue, 10 Oct 2017 08:20:37 -0700 (PDT) Original-Received: from lolita.yourcompany.com ([194.117.2.109]) by smtp.gmail.com with ESMTPSA id r134sm7373480wmf.3.2017.10.10.08.20.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Oct 2017 08:20:36 -0700 (PDT) In-Reply-To: <20171010142729.r7mgfmlkk6jvrnt6@logos.localdomain> (Mark Oteiza's message of "Tue, 10 Oct 2017 10:27:29 -0400") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219340 Archived-At: Mark Oteiza writes: > On 09/10/17 at 12:21am, Jo=C3=A3o T=C3=A1vora wrote: >> Feel free to tweak again and push to the >> scratch/flymake-diagnostics-buffer branch. > > I just added the keymap to the button--did not notice anything else > wrong with it. Remarkably, this breaks the button (at least in my testing) for mouse-clicks, which is the only reason it is there. Being a button I think one shouldn't mess with its keymap. Rather, this is what is needed unbreak RET on the button (and still keep mouse-1, mouse-2 and SPC, naturally) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index cf1e7e41ba..e4c6a38a77 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1132,7 +1132,7 @@ flymake--diagnostics-buffer-entries mouse-face highlight help-echo "mouse-2: visit this diagnostic" face nil - keymap flymake-diagnostics-buffer-mode-map + action flymake-goto-diagnostic mouse-action flymake-goto-diagnostic)])))) =20 (define-derived-mode flymake-diagnostics-buffer-mode tabulated-list-mode Jo=C3=A3o