From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: joaotavora@gmail.com (=?utf-8?B?Sm/Do28gVMOhdm9yYQ==?=) Newsgroups: gmane.emacs.devel Subject: Re: new flymake: cosmetic problem on terminal emacs Date: Sun, 22 Oct 2017 23:29:48 +0100 Message-ID: <87po9e3jfn.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508711422 23583 195.159.176.226 (22 Oct 2017 22:30:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Oct 2017 22:30:22 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: emacs-devel@gnu.org To: Yuta Yamada Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 23 00:30:16 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Oko-0003Qh-QF for ged-emacs-devel@m.gmane.org; Mon, 23 Oct 2017 00:29:58 +0200 Original-Received: from localhost ([::1]:34450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6Okw-0002Qz-2L for ged-emacs-devel@m.gmane.org; Sun, 22 Oct 2017 18:30:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6Okn-0002Qs-8W for emacs-devel@gnu.org; Sun, 22 Oct 2017 18:29:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6Okj-00039z-BG for emacs-devel@gnu.org; Sun, 22 Oct 2017 18:29:57 -0400 Original-Received: from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b]:55226) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6Okj-00039i-4e for emacs-devel@gnu.org; Sun, 22 Oct 2017 18:29:53 -0400 Original-Received: by mail-wr0-x22b.google.com with SMTP id o44so15562149wrf.11 for ; Sun, 22 Oct 2017 15:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=4zHEuLK6VWCG1DZ7762Xl9Oz1VQ+8Y3/6Ki3L4xK1zo=; b=BA22aIBXGdhpEXVuNBvq8u+z+zqVYcUxbXpOb6pVbGruNPp2/8FOunhCv6/L/7Go0m enl30fy2EjX4EeItBuqU3PRZAc/SWwbRJUywi5ur7sdn1cKW/yQ+qrACKVoKfIG5q4l5 WngW3QLAQTPOhx5rZQyyNY8/ALEQ++b/F68kg7v1kjS7EKI2C0KLX8/Z7Iux5sDLNrHL Iu0A5Nd5U6y1ngo8mUqpZmd8NPgxMRz5zbFpWSUrDQ7MX3z56NISaGbTPqUpfj81LJrC nz5vPMeYX94+PL0i1KKd20wODKrlBdnCbydPPTjRvXfKd/I6Czv2XPpByC9ykFxR7R5S Dj2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=4zHEuLK6VWCG1DZ7762Xl9Oz1VQ+8Y3/6Ki3L4xK1zo=; b=K9rhpKqi2vvU54k5dLRGzBUMSneuuVaqleH0duBp6ec+9na9TmFQWrG5aPOmCB2PlH sXB1Bgfdj1KOfmQO+KK/G6u+jwWhVsrrgxx9gpbAvdmIboEltS6YjPeZCzO5KQKEU7n3 rHS/M0/kbdq+v5QtEIYPEOu3Dh9kog7w8FbADyF4ShD/fQibDqHT1S0FnFnAohPOG8Q0 BLaDw+8+XY7XUsSxXx4fX+bNMYRD6/nSkqJ9KFEzdqt0sOf/FkLgt5jjFF+pUWUdiFpV kPFwFmNZwUXDgGKilWXcDCAhuSqwx54U77H8MGUvkL1WZ2hQ6UvvzjHJAo05BP33l0RY 0LvQ== X-Gm-Message-State: AMCzsaXTlw9Wf0OmPw8ySIz6+7ryfceyZsdZD1pI/mA49v0CqVpV4m4S hsO8c/io6luuQGoAe/WLycQx0eGs X-Google-Smtp-Source: ABhQp+SFGSrxm0e+5pe0c8X9l9pVLgl9NHv7jjsGuhdUd0p/HsGvfKjtItjtquvV18pa0nCq63++yg== X-Received: by 10.223.160.132 with SMTP id m4mr4138315wrm.45.1508711391812; Sun, 22 Oct 2017 15:29:51 -0700 (PDT) Original-Received: from lolita.yourcompany.com (188.139.62.94.rev.vodafone.pt. [94.62.139.188]) by smtp.gmail.com with ESMTPSA id k130sm11545255wmg.12.2017.10.22.15.29.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 22 Oct 2017 15:29:50 -0700 (PDT) In-Reply-To: (Yuta Yamada's message of "Sat, 21 Oct 2017 07:42:52 -0700") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219685 Archived-At: Yuta Yamada writes: > In terminal Emacs, I found not highlight state of flymake even there is a= warning. > It can be visible if you set underline to the flymake's face. Since Flymake can now highlight arbitrary regions, some of those regions can be mere whitespace, which is the case with the elisp-flymake-checkdoc backend. The offending code is this (repeated in flymake-warning and flymake-note) (defface flymake-error '((((supports :underline (:style wave))) :underline (:style wave :color "Red1")) (t :inherit error)) "Face used for marking error regions." :version "24.4") Clearly your terminal doesn't support the first clause, and the second one is unsuitable for whitespace. The simplest thing I can think of that keeps some of the "genericness" of the last clause is adding ":inverse-video t" to it. If noone can think of anything better, I will push this patch in some days' time. I tried it and it looks reasonably OK. Jo=C3=A3o diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 9c546fd966..7738d608e9 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -281,6 +281,7 @@ flymake-error '((((supports :underline (:style wave))) :underline (:style wave :color "Red1")) (t + :inverse-video t :inherit error)) "Face used for marking error regions." :version "24.4") @@ -289,6 +290,7 @@ flymake-warning '((((supports :underline (:style wave))) :underline (:style wave :color "deep sky blue")) (t + :inverse-video t :inherit warning)) "Face used for marking warning regions." :version "24.4") @@ -297,6 +299,7 @@ flymake-note '((((supports :underline (:style wave))) :underline (:style wave :color "yellow green")) (t + :inverse-video t :inherit warning)) "Face used for marking note regions." :version "26.1")