From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#29785: [PATCH] Implement separate eww history Date: Wed, 20 Dec 2017 18:27:57 +0100 Message-ID: <87po79wbqa.fsf@gmail.com> References: <87k1xhy5mi.fsf@gmail.com> <83mv2dnzlt.fsf@gnu.org> <87y3lxwe39.fsf@gmail.com> <83k1xhnxvi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513793631 20568 195.159.176.226 (20 Dec 2017 18:13:51 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 20 Dec 2017 18:13:51 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29785@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 20 19:13:47 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRisE-0004ue-76 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Dec 2017 19:13:46 +0100 Original-Received: from localhost ([::1]:33248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRiuC-0005mH-By for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Dec 2017 13:15:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eRiAz-0007ml-Ew for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 12:29:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eRiAw-00079d-Fb for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 12:29:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36006) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eRiAw-00078z-Bi for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 12:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eRiAv-00084J-W2 for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2017 12:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Dec 2017 17:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29785-submit@debbugs.gnu.org id=B29785.151379088830957 (code B ref 29785); Wed, 20 Dec 2017 17:29:01 +0000 Original-Received: (at 29785) by debbugs.gnu.org; 20 Dec 2017 17:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:44687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRiA3-00083E-UR for submit@debbugs.gnu.org; Wed, 20 Dec 2017 12:28:08 -0500 Original-Received: from mail-wm0-f53.google.com ([74.125.82.53]:43261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eRiA2-00082k-Ah for 29785@debbugs.gnu.org; Wed, 20 Dec 2017 12:28:06 -0500 Original-Received: by mail-wm0-f53.google.com with SMTP id n138so11319170wmg.2 for <29785@debbugs.gnu.org>; Wed, 20 Dec 2017 09:28:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:gmane-reply-to-list:date:in-reply-to :message-id:user-agent:mime-version; bh=smR4qG59nE55xs2bz4WFMUjc2CVaIPssm9/UqOhp/eg=; b=aX1Lpw3UNTSqFBxKIgWcAmPj2D6Y9hrT91Y+aDOPjNlpaR0lp96zHvlLYeKX2UOZx9 UbmM6NinlNYDjynQwZTiyNfPEyDSW/TKI2sNqKtLLoklgISsGmobNGPVfbFNBWJ0xxdF YAOzpfaGAtDR7jOyxBp9AP2jON9LF8NXftikbP6KY01KtBPYPmHunUQ4qmvyQCh8e8Np WYlVEIH7Xff+OrERniK/bX5jSF5aKzrGXe7pkJtCTuGSM70Qpdtsq4xCg+hjlN+8P5Qm mjbNUetrDu1iwS4uyBbYG2Uk8+NceOHNtzJYtrtguPFlwnx138FPrOCANkH3qBFFWOw6 9SiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=smR4qG59nE55xs2bz4WFMUjc2CVaIPssm9/UqOhp/eg=; b=J3rUfn4BGBvJVVExCuvl+NNznffuyZjda99rm7TNnedhNBKNs41T9DBnWxqhr+/bQF EIIBkNfp5kru5GeLnfJ2ZI9ZJ6Ze2qfpZoB9LxE4rQwuTb37XGdlwVICuZmDv1/KvUWX o6gFchKBqhAX+4yFAQyXAnoD+k1fDoA9x6cuPqiLyJaWKxWMBt24ZjLva8yYCG9PId6s AIsjVkBxBHwiI5MjOfQQE8jfJdSURWU95gCzYjBWCR7soJdUar4aT1xOb8G62bVQlyZt o5ZNnrka87Wyft/YBU/wnuQRpDx/Cu9P7VBkPB8xoYwBtGKtvGoRuSpUqxAVqLT2WgIh y43g== X-Gm-Message-State: AKGB3mJ15drrIs/bEp1En+u6pWhXjXJ/APMhsC6v36kW8eypGGiWd4lo tRtmuL76fLdgZi8VMq5jsktLw1B88m0= X-Google-Smtp-Source: ACJfBosllZ43zHXKEStr6ZAkUgnXD3OcnMBRhGfFyZbkdOMNoi7GbInkSe1MBV9m6G8wj+Oi8sbNXA== X-Received: by 10.28.11.6 with SMTP id 6mr6606809wml.135.1513790880229; Wed, 20 Dec 2017 09:28:00 -0800 (PST) Original-Received: from rpluim-ubuntu ([2a01:e34:ecfc:a860:d1d0:358:2cae:ab7b]) by smtp.gmail.com with ESMTPSA id r64sm22343997wrb.62.2017.12.20.09.27.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Dec 2017 09:27:59 -0800 (PST) Gmane-Reply-To-List: yes In-Reply-To: <83k1xhnxvi.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Dec 2017 18:54:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:141304 Archived-At: Eli Zaretskii writes: >> From: Robert Pluim >> Cc: 29785@debbugs.gnu.org >> Date: Wed, 20 Dec 2017 17:36:58 +0100 >> >> Eli Zaretskii writes: >> >> > Why should EWW usurp the history of URLs? >> >> The patch does not change the existing history support of browse-url, >> so 'usurp' feels harsh. > > It's just a word. It feels strange to me to call URL history by name > that includes "eww" as a substring. IMO it should be a general URL > history, like we have for files. > It's the url history of M-x eww, but it's just a name. > But that's just one opinion. > >> I could make the argument that URLs visited via browse-url are >> passed to an external browser, so it's not up to Emacs to remember >> that history, unlike ones visited internally using EWW. > > url-history.el seems to disagree. OK, so that does even more, it remembers url history across sessions. I never noticed it because: a) It's disabled by default. b) As far as I can tell, nothing uses it for actual completion of urls. So the final implementation should 1. Enable it by default 2. Hook up eww to it 3. Hook up browse-url to it 4. and probably various things in org Note that eww has a separate history mechanism also to track the urls you visit during a session (there may be a way to persist that as well). I'm thinking 3 different history mechanisms is too much. I can work on connecting at least eww to the existing url-history mechanism over the holidays, if you think that's the right direction [1] > Thanks. In many cases, like this one, it's very simple: > > *** New user variable 'eww-separate-history'. > If non-nil, this causes EWW to use a separate minibuffer history. > The default is nil. Thanks for that. Robert Footnotes: [1] And if I really get going I'll try to unify the 4 different ways we have of determining what URL we think is at point