all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 29785@debbugs.gnu.org
Subject: bug#29785: [PATCH] Implement separate eww history
Date: Wed, 20 Dec 2017 18:27:57 +0100	[thread overview]
Message-ID: <87po79wbqa.fsf@gmail.com> (raw)
In-Reply-To: <83k1xhnxvi.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Dec 2017 18:54:25 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: 29785@debbugs.gnu.org
>> Date: Wed, 20 Dec 2017 17:36:58 +0100
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > Why should EWW usurp the history of URLs?
>> 
>> The patch does not change the existing history support of browse-url,
>> so 'usurp' feels harsh.
>
> It's just a word.  It feels strange to me to call URL history by name
> that includes "eww" as a substring.  IMO it should be a general URL
> history, like we have for files.
>

It's the url history of M-x eww, but it's just a name.

> But that's just one opinion.
>
>> I could make the argument that URLs visited via browse-url are
>> passed to an external browser, so it's not up to Emacs to remember
>> that history, unlike ones visited internally using EWW.
>
> url-history.el seems to disagree.


OK, so that does even more, it remembers url history across
sessions. I never noticed it because:

a) It's disabled by default.

b) As far as I can tell, nothing uses it for actual completion of
urls.

So the final implementation should

1. Enable it by default
2. Hook up eww to it
3. Hook up browse-url to it
4. and probably various things in org

Note that eww has a separate history mechanism also to track the urls
you visit during a session (there may be a way to persist that as
well).

I'm thinking 3 different history mechanisms is too much. I can work on
connecting at least eww to the existing url-history mechanism over the
holidays, if you think that's the right direction [1]

> Thanks.  In many cases, like this one, it's very simple:
>
>   *** New user variable 'eww-separate-history'.
>   If non-nil, this causes EWW to use a separate minibuffer history.
>   The default is nil.

Thanks for that.

Robert

Footnotes: 
[1] And if I really get going I'll try to unify the 4 different ways
we have of determining what URL we think is at point






  reply	other threads:[~2017-12-20 17:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-20 11:56 bug#29785: [PATCH] Implement separate eww history Robert Pluim
2017-12-20 12:20 ` Lars Ingebrigtsen
2017-12-20 12:23   ` Robert Pluim
2017-12-20 16:02     ` Eli Zaretskii
2017-12-20 16:50       ` Robert Pluim
2017-12-20 18:43         ` Eli Zaretskii
2017-12-20 19:01           ` Robert Pluim
2017-12-20 20:14             ` Eli Zaretskii
2017-12-21  8:25               ` Robert Pluim
2018-04-12 22:30                 ` Lars Ingebrigtsen
2018-04-13 10:21                   ` Robert Pluim
2017-12-20 16:17 ` Eli Zaretskii
2017-12-20 16:36   ` Robert Pluim
2017-12-20 16:54     ` Eli Zaretskii
2017-12-20 17:27       ` Robert Pluim [this message]
2017-12-20 18:58     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87po79wbqa.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=29785@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.