From: Michael Albinus <michael.albinus@gmx.de>
To: zhang cc <ccsmile2008@outlook.com>
Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: auto-revert error on macOS when auto-revert-use-notify is t
Date: Fri, 29 Dec 2017 11:02:10 +0100 [thread overview]
Message-ID: <87po6xvom5.fsf@gmx.de> (raw)
In-Reply-To: <SG2PR0601MB14057D743AB6946C0B22951FA8050@SG2PR0601MB1405.apcprd06.prod.outlook.com> (zhang cc's message of "Fri, 29 Dec 2017 05:08:00 +0000")
zhang cc <ccsmile2008@outlook.com> writes:
Hi,
> Emacs: 26.0.90
> OS: macOS 10.13.2
>
> 1. start Emacs with -Q
> 2. open a test file (like 1.c)
> 3. turn on auto-revert-mode by run global-auto-revert-mode
> 4. add auto-revert-use-notify as a watcher variable by
> debug-on-variable-change
> 5. open the test file with vim
> 6. modify the test file in vim and save it
> 7. Emacs enter debug with the following msg:
>
> Debugger entered--setting auto-revert-use-notify in buffer 1.c to nil:
> debug--implement-debug-watch(auto-revert-use-notify nil set #<buffer
> 1.c>)
> auto-revert-notify-handler((13 stopped "/Users/jun/test/1.c"))
> file-notify--rm-descriptor(13)
> file-notify-rm-watch(13)
> #f(compiled-function (key value) #<bytecode 0x40a952e1>)(13
> (#<buffer 1.c>))
> maphash(#f(compiled-function (key value) #<bytecode 0x40a952e1>)
> #<hash-table equal 7/65 0x40e7896d>)
> auto-revert-notify-rm-watch()
> auto-revert-notify-handler((13 stopped "/Users/jun/test/1.c"))
> file-notify--rm-descriptor(13)
> file-notify-rm-watch(13)
> file-notify-callback((13 (rename delete) "/Users/jun/test/1.c"))
> file-notify-handle-event((file-notify (13 (rename delete)
> "/Users/jun/test/1.c") file-notify-callback))
> funcall-interactively(file-notify-handle-event (file-notify (13
> (rename delete) "/Users/jun/test/1.c") file-notify-callback))
> call-interactively(file-notify-handle-event nil [(file-notify (13
> (rename delete) "/Users/jun/test/1.c") file-notify-callback)])
> command-execute(file-notify-handle-event nil [(file-notify (13
> (rename delete) "/Users/jun/test/1.c") file-notify-callback)] t)
Well, this is not an error. The watchdog over "/Users/jun/test/1.c"
receives the `(rename delete)' events from writing the file. Due to
this, the watchdog is removed, as you see in the backtrace.
I could reproduce this behaviour on my GNU/Linux system. See the
following example, just from the shell:
--8<---------------cut here---------------start------------->8---
$ touch 1.c
$ ls -il 1.c*
3282165 -rw-r--r-- 1 albinus albinus 0 Dec 29 10:52 1.c
--8<---------------cut here---------------end--------------->8---
A zero length file 1.c has been created with inode 3282165.
--8<---------------cut here---------------start------------->8---
$ vim 1.c
$ ls -il 1.c*
3283516 -rw-r--r-- 1 albinus albinus 5 Dec 29 10:53 1.c
--8<---------------cut here---------------end--------------->8---
I have modified the file with vim, and saved. Now the inode is 3283516,
which means a *new* file with the same name. While saving the file, a
temporary file has been created, and renamed then to the original file
name. From Emacs' file-notify point of view, this is a new file.
If you want to keep the original file, you must apply backup-by-copy in
vim. Apply the following settings in ~/.vimrc, and rerun the test:
--8<---------------cut here---------------start------------->8---
$ cat <<EOF >~/.vimrc
set backup
set backupcopy=yes
EOF
$ vim 1.c
$ ls -il 1.c*
3283516 -rw-r--r-- 1 albinus albinus 9 Dec 29 10:58 1.c
3283482 -rw-r--r-- 1 albinus albinus 5 Dec 29 10:53 1.c~
--8<---------------cut here---------------end--------------->8---
You'll see that the inode 3283516 is kept.
Best regards, Michael.
next prev parent reply other threads:[~2017-12-29 10:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 5:08 auto-revert error on macOS when auto-revert-use-notify is t zhang cc
2017-12-29 10:02 ` Michael Albinus [this message]
2017-12-29 10:13 ` Eli Zaretskii
2017-12-29 15:45 ` zhang cc
2018-01-02 13:23 ` Michael Albinus
2018-01-05 14:47 ` zhang cc
2018-01-20 15:34 ` Michael Albinus
2018-01-21 11:01 ` zhang cc
2018-01-21 20:16 ` Alan Third
2018-01-22 8:17 ` Michael Albinus
2018-01-22 23:05 ` Alan Third
2018-03-11 4:26 ` zhang cc
[not found] ` <18101cae-50ff-44a2-af65-f77b9039f461@Spark>
2018-03-11 4:29 ` zhang cc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po6xvom5.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=ccsmile2008@outlook.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.