From: Robert Cochran <robert-emacs@cochranmail.com>
To: Michael Mauger <mmauger@protonmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Robert Cochran <robert-emacs@cochranmail.com>,
"emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Re: sql.el MariaDB support
Date: Mon, 11 Jun 2018 18:10:00 -0700 [thread overview]
Message-ID: <87po0wq07r.fsf@cochranmail.com> (raw)
In-Reply-To: <AZ9K6HkhdXaH6oJNF6wwIrDc1dR7_IrK5fKAJ7Ijuh30YYiWEYcoYDdOwGfujS0zUVjkCmEhSLJiYc6gSihoIQ==@protonmail.com> (Michael Mauger's message of "Sun, 10 Jun 2018 20:26:49 -0400")
Michael Mauger <mmauger@protonmail.com> writes:
> I had to move the mariadb defvaraliases before the mysql defvar because that is the order expected.
Oops. I mean, I had a 50/50 of getting it right on the first try, so I
suppose I didn't do too badly.
> This is obviously the potential gotcha here, but if you are flipping between the two,
> you have enough other problems that I don't think Emacs will be you biggest. :)
Good. I was thinking the exact same thing, but I was playing it safe by
asking the question and confirming whether or not that was considered
reasonable behavior.
> That's a hold-over from the original and I'm not sure it has any impact today. Let
> me know if you have any problems...
Alright. It doesn't particularly bother /me/ to not have that
aligned. I'm simply happy not to have to fiddle with the prompt regexps
every time I want to use the SQL REPL. :)
> Keeping it loose is okay, anchoring it to the start of the line thru the "> " text is
> really all that's needed.
Awesome, because I honestly wasn't really in the mood for trying to
concoct a complicated regexp to match all the possibilities. ;)
> I had to rearrange the declarations a bit and correct a couple of spelling/cut-n-paste
> issues, but it looks fine. I went ahead and committed the code and gave you credit.
Thanks! Please forgive my n00b question: where exactly did it go? I
don't see it in the Emacs git, neither master nor emacs-26. Perhaps I'm
not searching for it correctly?
> I took care of this. Basically the font-lock variables have long lists of keywords,
> functions, and data types that are converted at build time to a massive regexp.
> I updated the lists from the MySQL and MariaDB documentation. Let me know if
> you find any of the highlighting to be distracting or seeming incorrect. Without a
> serious increase in complexity of the matching, there will always be some odd cases.
Thanks. Perhaps I could have phrased it better - I'm a casual user WRT
SQL in general. I understood once I saw the list of keywords what was
eventually going to happen to the list of words. I'm not entirely sure
why I didn't grok 'add the new keywords to the list' - I somehow got a
mental image of a much more drastic undertaking. I could have done that
if I had been able to read properly! :)
Sorry!
> Thank you very much, I greatly appreciate your contribution.
Thank you for taking it.
> Happy Hacking!
And to you as well.
--
~Robert Cochran
GPG Fingerprint - BD0C 5F8B 381C 64F0 F3CE E7B9 EC9A 872C 41B2 77C2
next prev parent reply other threads:[~2018-06-12 1:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 3:07 sql.el MariaDB support Robert Cochran
2018-06-06 14:53 ` Eli Zaretskii
2018-06-06 17:16 ` Michael Mauger
2018-06-06 17:28 ` Eli Zaretskii
2018-06-06 17:38 ` Michael Mauger
2018-06-07 8:48 ` Robert Cochran
2018-06-11 0:26 ` Michael Mauger
2018-06-12 1:10 ` Robert Cochran [this message]
2018-06-12 3:08 ` Michael Mauger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87po0wq07r.fsf@cochranmail.com \
--to=robert-emacs@cochranmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=mmauger@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.