From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.devel Subject: Re: auto-complete popup is broken on master Date: Mon, 25 Jun 2018 16:55:14 +0000 Message-ID: <87po0erekt.fsf@gmail.com> References: <87sh5arhw0.fsf@gmail.com> <87r2kurhn1.fsf@gmail.com> <837emmstl7.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529945651 27261 195.159.176.226 (25 Jun 2018 16:54:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 25 Jun 2018 16:54:11 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: Emacs-Devel devel To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 25 18:54:07 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fXUkd-0006ut-2W for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2018 18:54:03 +0200 Original-Received: from localhost ([::1]:48323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXUmk-0007B8-DZ for ged-emacs-devel@m.gmane.org; Mon, 25 Jun 2018 12:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXUm0-0007Ad-Jw for emacs-devel@gnu.org; Mon, 25 Jun 2018 12:55:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXUlx-0005Rq-CU for emacs-devel@gnu.org; Mon, 25 Jun 2018 12:55:28 -0400 Original-Received: from mail-qt0-x22b.google.com ([2607:f8b0:400d:c0d::22b]:37695) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXUlx-0005RQ-3z; Mon, 25 Jun 2018 12:55:25 -0400 Original-Received: by mail-qt0-x22b.google.com with SMTP id a18-v6so12565452qtj.4; Mon, 25 Jun 2018 09:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=kkvrIv8MEaDI94JwEVq+VNtp5EAkWhdv0WlKZDQzUDM=; b=Lf1pYXrB6R5m4SRK4fyzJvwnKGhj1EPU27bIfMTTLZozDW+tih9tjiGhk51CZqDnCU T1ABTQMPw64CXhBpA2IEZC1c06XdskRQyOP2Io82X3oNNfSIhwZzPgc7TlXtUYDR/mC7 ERNdWtd4Z+5WvIIatZps4C7pfUsf5Wlb/mNaiujbMoXpVXarL5HY7MWwogbmt44B3X1X dWum2uUrYVob/XxhaD4BlkmchWTc3Yqu9wDIFwW0hZGmGq/5XJI6RL2iEaejp846HadD O0yy+feOODsAN5sCviFjkXRaWoKoKNBOVEZCZUKFUu/QWStVyav8xkUdGzpxk3rurevo CdBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=kkvrIv8MEaDI94JwEVq+VNtp5EAkWhdv0WlKZDQzUDM=; b=OtZhAPVEx7mtgWKjdJG7BqeadU1srciFBWcXPibwkdEJDcTESD69ZRv4cnpxxFILaW wfM8J3bnM4bu4U0yrkEuPcrStI74WORfoboXLmmMNv947kYexggINpl5OnuNu7Vj8NCP X2mEgxCo77SEnkYDYisg5ynRxZHpCdqCodA0pgiu6Jhqk6v6uhi9aeebCgSg86IquSBw +j4bUWAyozNIiqTmEPwbqvrEbvPSanK1LyNYFMg4tRvRvRezDQLo6i2teVBVBOtBRobQ BaeIDytRnCj16ZvfYed5EcVwxGLqeLcx3BSonJu0qCLzXvioiBVjg0eGF5RR24FTa1S2 OD9g== X-Gm-Message-State: APt69E02i4w9fvDWlyFM1d5Usmiy8oa080GIH5MbXW2tt3QtZDKckf4r BwDSB9YrYQ6gumq/GnTFDn9cpg/l X-Google-Smtp-Source: AAOMgpdQaLh8xA54vMjC8ia2frzdUY4oJqO1RIPkryKWtOPMKY751v4isKET4MFUo5btYWR5QI59jw== X-Received: by 2002:a0c:84e6:: with SMTP id m93-v6mr11631025qva.227.1529945723767; Mon, 25 Jun 2018 09:55:23 -0700 (PDT) Original-Received: from 146f2c17b146 (cpe-184-152-55-93.nyc.res.rr.com. [184.152.55.93]) by smtp.gmail.com with ESMTPSA id 43-v6sm8534788qtx.12.2018.06.25.09.55.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Jun 2018 09:55:22 -0700 (PDT) In-reply-to: <837emmstl7.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226715 Archived-At: removed help-gnu-emacs and add emacs-devel Eli Zaretskii writes: >> From: John Shahid >> Date: Mon, 25 Jun 2018 15:49:06 +0000 >> >> The candidates in the auto-complete popup aren't aligned properly. This >> seems to be a result of the change in the behavior of >> `vertical-motion'. auto-complete tries to move vertically by getting the >> column using `(car (posn-col-row (posn-at-point)))' then use the col >> number as follows `(vertical-motion '(COL 1))'. This works as expected >> on `4a7e74fea687011ee81dcbb02294bccd99b3a05f` but its behavior has >> changed on master. Current master doesn't take into account >> display-line-number width. Was that an intentional change ? If so, what >> is the recommended way to get the previous behavior ? > > Thanks. This is not the right place for reporting bugs, certainly not > about the development codebase. Please submit a bug report using > report-emacs-bug, and please include there a recipe to reproduce the > problem starting from "emacs -Q". I meant to send this email to emacs-devel instead of help-gnu-emacs. Sorry about that. I will open a bug ASAP. > > (I think what you describe is not a bug, but it's hard to tell without > all the details. Also, the commit you mention is quite old.) I wasn't sure if this is considered a bug or a feature, but we can discuss that on the bug report. > >> While debugging this issue I also noticed that auto-complete popup-el >> use overlay 'prefix property which isn't documented. > > Can you point at places in auto-complete which are using that > property? It is being set in the following places https://github.com/auto-complete/popup-el/blob/master/popup.el#L610 & https://github.com/auto-complete/popup-el/blob/master/popup.el#L366.