From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#21201: 25.0.50; (buffer-modified-p) errors inside cl-letf Date: Tue, 17 Jul 2018 08:16:09 -0400 Message-ID: <87pnzm83cm.fsf@gmail.com> References: <87lhdo41vy.fsf@members.fsf.org> <8637zwghfe.fsf@members.fsf.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1531830374 9743 195.159.176.226 (17 Jul 2018 12:26:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2018 12:26:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 21201@debbugs.gnu.org, Artur Malabarba To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 17 14:26:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffP3Q-0002Nq-VQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 14:26:09 +0200 Original-Received: from localhost ([::1]:59021 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffP5X-0007e3-QT for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 08:28:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffOug-0007Zu-Cg for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:17:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffOud-00084H-1V for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:17:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39528) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffOuc-000848-Nj for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffOuc-0000XR-Gg for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 08:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jul 2018 12:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21201-submit@debbugs.gnu.org id=B21201.15318297791988 (code B ref 21201); Tue, 17 Jul 2018 12:17:02 +0000 Original-Received: (at 21201) by debbugs.gnu.org; 17 Jul 2018 12:16:19 +0000 Original-Received: from localhost ([127.0.0.1]:44543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffOtu-0000Vu-QB for submit@debbugs.gnu.org; Tue, 17 Jul 2018 08:16:19 -0400 Original-Received: from mail-it0-f42.google.com ([209.85.214.42]:36240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffOts-0000Va-R1; Tue, 17 Jul 2018 08:16:17 -0400 Original-Received: by mail-it0-f42.google.com with SMTP id j185-v6so1544641ite.1; Tue, 17 Jul 2018 05:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qFKN96fCTEU8vWfrIMVm2ru3xanzHyFyFxm4W1iF/4A=; b=LX5Q0poL50VCiNSuA7NPFJb9qyNOd19P6+WGeyUdDkMQu7mqLiGdx9QpjfuPaAWqBj uV/qbTlqZzur+R3Bk0eGQ0qRliLD3Ni212B5m5+HxyKdGQkT5jGmdwUiXRFArua3FS0B 7A9mo2tKg9JZ29Y+Vq9zdbrEQ/L6zD4tfhp2NJIwn5TeNwN7hjknjHCVIQQTh6QOcjg7 oKdPdJRoDiXt/XvmVSo4E1gILOdvhB0PsFCHLE1GEQrqh0WzJzkEGB5njj3q8vrd1So7 hc4lmPpoKRWS4PxRl6dmVXssqc59byYj771RLmXvQQgnlIsCQy/fFx8BUIcFDLUC80sm 5zlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qFKN96fCTEU8vWfrIMVm2ru3xanzHyFyFxm4W1iF/4A=; b=b/mfX6xrt830mEu1a3Lkc1ZO4eGwN/WD9ztlhN8IKrwTWDBLJxBSFz7yTkpX75JEPK +YpJAEF2Ve3sGwbRlnbTPtR4HaqAGyCtlY1LvGmpzrOMcbYU2EpkBXXb7zIfJWuOk+Zb G717TucZx4TSeDdU4L6ivhWmd2UWl/+iZqNJsPsdiOPeD1UlZmnedm3++PqTEiJ8JrI4 GgESUxYwlmJ0vGRkK5JBBqMwe6nWV8CZOPXgOtd3NT4JUrGmw3WzaxekI7l4gcXDtq0d rJBO8YCRQAPuMI24AAmSgN36Tu96+TiwcrinC1tkqwluy+Fb9q+nHWYsXe4z+bMvmBOc 2bQA== X-Gm-Message-State: AOUpUlGQ8aOWAtVTw9UA/WbpfUw0Av4lvYrkgFKQtMHZ77b4tyFMrfgF WO6Jzi+SqvLdbbEPU7mP7jz/Fw== X-Google-Smtp-Source: AAOMgpdqcZAjQ3NLJAfXAj+l94vVC+VXQxqDEc5EYGYdhoCUttfLfSauKybZVBHNZx2wO1Iqqs+Kyg== X-Received: by 2002:a24:b34f:: with SMTP id z15-v6mr1329679iti.53.1531829771059; Tue, 17 Jul 2018 05:16:11 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 69-v6sm369378itk.3.2018.07.17.05.16.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 05:16:10 -0700 (PDT) In-Reply-To: <8637zwghfe.fsf@members.fsf.org> (Nicolas Richard's message of "Fri, 07 Aug 2015 00:50:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148606 Archived-At: --=-=-= Content-Type: text/plain tags 21201 + patch quit Nicolas Richard writes: > Artur Malabarba writes: >> 2015-08-06 21:07 GMT+01:00 Nicolas Richard : >>> (gv-define-setter buffer-modified-p (flag &optional buf) >>> - `(with-current-buffer ,buf >>> - (set-buffer-modified-p ,flag))) >>> + (if buf >>> + `(with-current-buffer ,buf >>> + (set-buffer-modified-p ,flag)) >>> + `(set-buffer-modified-p ,flag))) >> >> Don't know if it's possible, but shouldn't it try to ensure that it's >> in the same buffer as before? > > I agree with you, but I don't know how to do that. This seems to work. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Allow-setf-of-buffer-modified-p-without-argument-Bug.patch Content-Description: patch >From 1481f8893ff04a83b578f403cd22c7bdd2ec65f0 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Mon, 16 Jul 2018 22:14:32 -0400 Subject: [PATCH] Allow setf of buffer-modified-p without argument (Bug#21201) * lisp/emacs-lisp/cl-lib.el (setf buffer-modified-p): Take current buffer if optional argument BUF is not passed. --- lisp/emacs-lisp/cl-lib.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index 381784d1fd..ba5f9d64a1 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -521,8 +521,9 @@ cl-pairlis ;; Some more Emacs-related place types. (gv-define-simple-setter buffer-file-name set-visited-file-name t) (gv-define-setter buffer-modified-p (flag &optional buf) - `(with-current-buffer ,buf - (set-buffer-modified-p ,flag))) + (macroexp-let2 nil buffer `(or ,buf (current-buffer)) + `(with-current-buffer ,buffer + (set-buffer-modified-p ,flag)))) (gv-define-simple-setter buffer-name rename-buffer t) (gv-define-setter buffer-string (store) `(insert (prog1 ,store (erase-buffer)))) -- 2.11.0 --=-=-=--