From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32201: 27.0.50; setenv should not change match-data Date: Sat, 21 Jul 2018 21:30:02 -0400 Message-ID: <87pnzg5a79.fsf@gmail.com> References: <87h8kwe4ja.fsf@gmail.com> <87601c88d9.fsf@gmail.com> <87efg0dqg6.fsf@gmail.com> <87o9f46l9a.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1532222983 3136 195.159.176.226 (22 Jul 2018 01:29:43 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Jul 2018 01:29:43 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: 32201@debbugs.gnu.org To: John Shahid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 22 03:29:38 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fh3Bq-0000jI-8x for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Jul 2018 03:29:38 +0200 Original-Received: from localhost ([::1]:54459 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fh3Dx-0006EX-91 for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Jul 2018 21:31:49 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fh3DF-00060f-Oi for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 21:31:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fh3DC-0003m9-Ld for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 21:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fh3DC-0003m3-H5 for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 21:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fh3DC-00017a-Ab for bug-gnu-emacs@gnu.org; Sat, 21 Jul 2018 21:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Jul 2018 01:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32201 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32201-submit@debbugs.gnu.org id=B32201.15322230134212 (code B ref 32201); Sun, 22 Jul 2018 01:31:02 +0000 Original-Received: (at 32201) by debbugs.gnu.org; 22 Jul 2018 01:30:13 +0000 Original-Received: from localhost ([127.0.0.1]:51473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fh3CP-00015m-EK for submit@debbugs.gnu.org; Sat, 21 Jul 2018 21:30:13 -0400 Original-Received: from mail-io0-f196.google.com ([209.85.223.196]:46655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fh3CM-00014c-C5; Sat, 21 Jul 2018 21:30:10 -0400 Original-Received: by mail-io0-f196.google.com with SMTP id i18-v6so12837018ioj.13; Sat, 21 Jul 2018 18:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=e3w+TYoaOKLdbe/VFGfStnBw9LXgQdvftvnNLQilA2w=; b=CQKgZxgVLWyBJ1jEzlfOXNBfukp/HRmc/AenbNpfcbgR3nbLEDCKRkQ4MiBKrbb1L4 ZpG1/nodKnE4hkkQV3mB6WrHqysQVGP5eqzLrgRVkmjWHZDLzDbDll+h2hjR+bQXkw9L AIWiH6FDUy7jN7S2YNEAY9TNzPIqqytxdx7n+DM++TJVqEMu3lGhUSD5OKFMs3+trRbF oRLzK9PWvC5JJwXSPOu1pWEKzkA9b2PM3jhs1wwKwoSOJ7wGjvb8uVE2uQRu5PSxaAxl VC2tcTnpEpqPVoPzRMvV7zePBH0SsX7LJamV12oGllKwp+tV2bvNW90CPR0AegWO5cfG xC+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=e3w+TYoaOKLdbe/VFGfStnBw9LXgQdvftvnNLQilA2w=; b=V8lwsIszIuGDHMgX1XUd2Ptx0/pNQ3DXNFN1dtVhIcBjLZ7IjBK4kd9G1lYSIXmlwp 1RtRUQ+YKCu/SStUzFIDTXkV2AH6lARc3EcO9S4ZY07ZW4PtZn4I38SPUT5ydmsXfcRD XKv9o6Yj+B0Zb27ZkR8QoaRLc2TWv1vIGNH3NbpdqxIBEU9cLnfr+fXNAgt9eHXxh8Oh dq7LflwdJWcuPICiS1d6RoMHYwbk6ArkFGDLDmcAfv1qTYEVWWOYyGMhUbg80A6voW67 LT7b0AhR4/79pR/cu+WuWk+RrjX6tzVYxlegWQfJ+qYr7x/IP/l1/PJiLpyeNyy8yNNy u9gQ== X-Gm-Message-State: AOUpUlEBGHdFXHD6hZNF6jC/zj+WAGhnC2wp99SfehDXtMo9hgdb6wWx UBGrhYpKMJXqH77/3DOtkoHtJ9CM X-Google-Smtp-Source: AAOMgpc0tpzxZj6gckM6PD43GIDLGkuF7mB55feZj3X1rbAmwH9x3F8aaFidEvCAIoEPbpsshQq9Tw== X-Received: by 2002:a6b:1a53:: with SMTP id a80-v6mr5892889ioa.143.1532223004440; Sat, 21 Jul 2018 18:30:04 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id i23-v6sm1726141iog.74.2018.07.21.18.30.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Jul 2018 18:30:03 -0700 (PDT) In-Reply-To: <87o9f46l9a.fsf@gmail.com> (Noam Postavsky's message of "Wed, 18 Jul 2018 21:56:49 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148798 Archived-At: tags 32201 fixed close 32201 26.2 quit Noam Postavsky writes: > John Shahid writes: > >>> Anyway, I don't think setenv should be changed, rather >>> abbreviate-file-name should save-match-data around the expand-file-name >>> call. After all, today you happened to use setenv in a hook, tomorrow >>> someone will use another match-data modifying function. >> >> I agree, but I also think that there is no reason for `setenv' to use >> `string-match' instead of `string-match-p'. It doesn't seem to be using >> the match data anyway. I attached the patch that replaces >> `string-match' with `string-match-p' in `setenv' and `setenv-internal'. >> WDYT ? > > Seems harmless enough. I'll wait a couple of days, and then push my > abbreviate-file-name patch to emacs-26 and this patch to master. Done. [1: 59e8533286]: 2018-07-21 21:07:07 -0400 Add save-match-data to abbreviate-file-name (Bug#32201) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=59e8533286cc8b5abc80b0966ef4b9fb676fbdfe [2: b7ca3d5d93]: 2018-07-21 21:10:20 -0400 Avoid destroying match data in 'setenv' (Bug#32201) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b7ca3d5d932bad6900296679ab87f7d0d64d1de9