From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#32304: 27.0.50; tramp-tests issue with double slash Date: Sun, 29 Jul 2018 18:27:40 +0200 Message-ID: <87pnz6dn2b.fsf@gmx.de> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1532881570 26081 195.159.176.226 (29 Jul 2018 16:26:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jul 2018 16:26:10 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32304@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 29 18:26:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjoWC-0006fy-S9 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 18:26:04 +0200 Original-Received: from localhost ([::1]:48990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjoYJ-00012N-Hk for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 12:28:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjoYB-00012D-2P for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 12:28:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjoY7-0006qK-1T for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 12:28:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57233) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjoY6-0006q5-RM for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 12:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjoY6-0000x1-5y for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 12:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jul 2018 16:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32304 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32304-submit@debbugs.gnu.org id=B32304.15328816753634 (code B ref 32304); Sun, 29 Jul 2018 16:28:02 +0000 Original-Received: (at 32304) by debbugs.gnu.org; 29 Jul 2018 16:27:55 +0000 Original-Received: from localhost ([127.0.0.1]:34018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjoXy-0000wY-Ur for submit@debbugs.gnu.org; Sun, 29 Jul 2018 12:27:55 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:33163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjoXw-0000wJ-HU for 32304@debbugs.gnu.org; Sun, 29 Jul 2018 12:27:53 -0400 Original-Received: from detlef.gmx.de ([212.86.51.86]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LngRb-1gBSeQ2UXv-00hz0w; Sun, 29 Jul 2018 18:27:41 +0200 In-Reply-To: (Ken Brown's message of "Sun, 29 Jul 2018 11:54:10 -0400") X-Provags-ID: V03:K1:BRxt2S6Q2At1vN5B1n7PyXN7ifGt3oPAvj1XhTzrR7AtlnS60MR 6bF1CRS/A0IVTlf++/x9vwfaMIQIcsHK/vpudCXjs9rnqRx3kSYDGdlJcihsQ8tMJUgyYrl IFGVitqN9jOOiiGs6Sq1/XhvX4iZwkYDaNSOtGqY5VkrB6JtB7xQAPvHM5bazbyN/zpS3vr 9oHp/Erh2Zs8ZdeHP7z/g== X-UI-Out-Filterresults: notjunk:1;V01:K0:y4gOe5BrTGg=:VwfnNcIuf36EiQeB5v/KeK LUmHgwWG20cRuw8OUrl1Rj4Fc5NtbnCyuKKJZknCcG0pKlpitqm5QTvXeWiyV//7wtqET910k iWLkTY8GL21GZS/kQ1NgEDljEckaMNjZ3oz1BQ+oH/FVgT0Vx2wVzbdNT0YasCkL49wZ7IGUk pKA5jxYZ9gKTe8NidG4uBsBfxIPG06e9oxZvQV6d+qyH5G9xFfU7zOoCSaLZDg+zEN+xAWw3P 1yJK/bvB/c4ijd84p9dMeADfTRl1sUEVisI5hnaOqoBPnRBoz5+vNo8uxd9a5RwugcFNnQfbZ yLhd7bmJ6imkdaDbyItxuiXm3OyL0fanpgV9gsp7uaZ6+zSnyzxwxEyLtE7haQl1Y2gYhHAM0 A+BQ7Y/y5gB4WGiMHw/PFHjyrQ6jP/IE15nuAd2M0UCeis9WNRYkrhacG2RiMXJJVrEa3rFe2 hFZmg19X1eZepgccgkZTl9TBreKH7QOiAbKqF6BJm6Qqhm6U7QTYWQqfRa0/WSpc9CMSPZ6un A/R6srO3Yj8Y0UFDLnyHZ3aUV7BBtc9ss52fk5BCJinmFxTqrBsy1+0+6xb6Gu6nzD7L/oyYT dizwxm/GgKd0+8NAfSYcy2aNpCSpktbl6oUnXKrJVO1bBslm514OkXDtOoDvEMpx+zKawKLlR JqUUTMDVWQMmDECh5B9BGNHx7x4xvxe7gJUQAdLrEJ9S7w6kpF0Vz9h1LWSDHNBHzmQXb7xID 5jQO5xI1Ssv0keiH75vGROgxRAszup6Ri8ZbOgDjbErRgtSLJK3Y5Mz3OIM= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149053 Archived-At: --=-=-= Content-Type: text/plain Ken Brown writes: Hi Ken, > "//" has a special meaning at the beginning of a file name on Cygwin and > MS-Windows; see the comment near the beginning of > search_embedded_absfilename. So I don't think there's a real bug here. > Maybe the expected result of the test should simply be adjusted, as in > the attached patch. Someone who builds on MS-Windows would have to > check this. Thanks for the report. However, your patch seems just to hide the problem in tramp-tests.el. Wouldn't it be better to fix this? What about the appended patch? > Ken Best regards, Michael. --=-=-= Content-Type: text/plain Content-Disposition: attachment diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el index d56b09a604..1c1ed7a377 100644 --- a/lisp/net/tramp.el +++ b/lisp/net/tramp.el @@ -3567,8 +3567,11 @@ tramp-handle-substitute-in-file-name ;; First, we must replace environment variables. (setq filename (tramp-replace-environment-variables filename)) (with-parsed-tramp-file-name filename nil - ;; We do not want to replace environment variables, again. - (let (process-environment) + ;; "//" has a special meaning at the beginning of a file name on + ;; Cygwin and MS-Windows. And we do not want to replace + ;; environment variables, again. + (let ((system-type 'not-windows) + process-environment) ;; Ignore in LOCALNAME everything before "//" or "/~". (when (stringp localname) (if (string-match "//\\(/\\|~\\)" localname) --=-=-=--