From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32281: shr.el align support patch Date: Mon, 06 Aug 2018 13:36:18 -0400 Message-ID: <87pnyvxur1.fsf@gmail.com> References: <6177421532613989@iva7-bd007c44f58e.qloud-c.yandex.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: blaine.gmane.org 1533578523 20627 195.159.176.226 (6 Aug 2018 18:02:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 6 Aug 2018 18:02:03 +0000 (UTC) Cc: Bad Blue Bull To: 32281@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 06 20:01:58 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmjpO-0005EU-EH for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Aug 2018 20:01:58 +0200 Original-Received: from localhost ([::1]:35522 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmjrU-0000ay-Go for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Aug 2018 14:04:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmjRK-0000xT-5P for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 13:37:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmjRG-00041Y-Q2 for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 13:37:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37840) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmjRG-00041O-Iu for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 13:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fmjRG-0003Hf-8h for bug-gnu-emacs@gnu.org; Mon, 06 Aug 2018 13:37:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <6177421532613989@iva7-bd007c44f58e.qloud-c.yandex.net> Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Aug 2018 17:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32281-submit@debbugs.gnu.org id=B32281.153357698712576 (code B ref 32281); Mon, 06 Aug 2018 17:37:02 +0000 Original-Received: (at 32281) by debbugs.gnu.org; 6 Aug 2018 17:36:27 +0000 Original-Received: from localhost ([127.0.0.1]:42858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmjQh-0003Gm-5Z for submit@debbugs.gnu.org; Mon, 06 Aug 2018 13:36:27 -0400 Original-Received: from mail-it0-f41.google.com ([209.85.214.41]:50790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmjQf-0003GW-9q for 32281@debbugs.gnu.org; Mon, 06 Aug 2018 13:36:25 -0400 Original-Received: by mail-it0-f41.google.com with SMTP id j81-v6so16722881ite.0 for <32281@debbugs.gnu.org>; Mon, 06 Aug 2018 10:36:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version; bh=4zi3hRCGvBMIjWH2MlLxqhtmAo02q+AliI7bYsNoGfU=; b=sgz8ie5DcyPAYWclluP2uKpE8qmvSgUbBJkfFjaG+nOca4O5WbN4ZHvkRxf0lEuezj DgYGT7R1mBhQR2wbHUN2024uB/SxuLCZ+/9qvBMiThs/MlCx8PfKgIdt1xUQWrsk12WW WYaHCtnjj8A7eFy9FNnJhCrWSGYr9uchlY9U3+wXjp3cnyzuvEqp4IFuUga6bzEUzfJI 4dISB7XNmOXjNPVbXW8Cq8LJlPCg2WJ9TV2NSLn7Hwo7kiVkmL4y0mH7pavkbp3TQzCd qOQJ1ASzSODCBby2rFR4xiuIekgX6VTv5OZKs1i3wQ7pqRkSCRGyFfKJwNb4irza8+kZ X93w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=4zi3hRCGvBMIjWH2MlLxqhtmAo02q+AliI7bYsNoGfU=; b=hKHxT36/ryIyWYJgg+nHjejpoNQQI4IbmzJxj753H3GN6t3mnmDcsD4Ef5k3VBZyT+ CrtR9aoBtk9s8zn5Hg7azsCNhswrZYGtErCso8ZSuRoKF4yL7tfRb9sMTYArzs/IkLUz A+EVASdip/qd8enfMSEBk9aTY39fUh1UDNyNvdRq/ZiQE5pr7Sm8HcDrQ6dEqSQh0guw 707a4jslW5XsKnToOnRnZbmfWjaSBqwhLqvAo4AbsVdUipH6MVle7As3likNS3/U/270 kqxQaLy2Z4W5vGhIpCgBBFVX+NRL75WkahJJrOX6V6kRzbYNf5UgFZcFdisS7/rYbOS9 4XXg== X-Gm-Message-State: AOUpUlHndm5xam6ereHKIsvS1if9lYfmO1EeywTw/VbEtjcTOeeVRt4I fBoUniWH5hYjrH47v1L/I8o= X-Google-Smtp-Source: AAOMgpc+kc6HYsPryxyPuCpr5hqvPJ2acLyUzU36ODH4kOZTnpCmxc9gOytqCHxfy6wyLybLttwNyQ== X-Received: by 2002:a02:105:: with SMTP id c5-v6mr13278169jad.139.1533576979595; Mon, 06 Aug 2018 10:36:19 -0700 (PDT) Original-Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id z1-v6sm3804116itb.7.2018.08.06.10.36.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 10:36:18 -0700 (PDT) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149289 Archived-At: --=-=-= Content-Type: text/plain [forwarding to list, please use "Reply All" to keep 32281@debbugs.gnu.org on Cc] --=-=-= Content-Type: message/rfc822 Content-Disposition: inline From: Bad Blue Bull To: Noam Postavsky In-Reply-To: <87wot4xl3g.fsf@gmail.com> References: <6177421532613989@iva7-bd007c44f58e.qloud-c.yandex.net> <87wot4xl3g.fsf@gmail.com> Subject: Re: bug#32281: shr.el align support patch Date: Mon, 06 Aug 2018 16:01:49 +0300 Message-Id: <17599871533560509@sas2-7b909973f402.qloud-c.yandex.net> MIME-Version: 1.0 Content-Type: text/plain > The indentation in your patch looks kind of off, are you not using > Emacs' builtin auto-indentation? (also, don't leave hanging parens.) I have (setq-default lisp-body-indent 2) in my ~/.emacs, things seemed for me indented like the rest of the source, as for hanging parens - there's a comment (that though should be put before paren as it relates to the last argument), it's unnecessary. As for monospace/proportional fonts: I don't insist on change of shr-use-fonts default value, paragraph justification won't work with proportional fonts though. Current version of shr.el don't fill the text at all and I don't know maybe smb likes it and won't welcome the change (see pics), although ERC fills text for example. --=-=-=--