all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: 32281@debbugs.gnu.org
Cc: Bad Blue Bull <ibmbull@yandex.ru>
Subject: bug#32281: shr.el align support patch
Date: Mon, 06 Aug 2018 13:36:18 -0400	[thread overview]
Message-ID: <87pnyvxur1.fsf@gmail.com> (raw)
In-Reply-To: <6177421532613989@iva7-bd007c44f58e.qloud-c.yandex.net>

[-- Attachment #1: Type: text/plain, Size: 82 bytes --]

[forwarding to list, please use "Reply All" to keep 32281@debbugs.gnu.org on Cc]


[-- Attachment #2: Type: message/rfc822, Size: 1141 bytes --]

From: Bad Blue Bull <ibmbull@yandex.ru>
To: Noam Postavsky <npostavs@gmail.com>
Subject: Re: bug#32281: shr.el align support patch
Date: Mon, 06 Aug 2018 16:01:49 +0300
Message-ID: <17599871533560509@sas2-7b909973f402.qloud-c.yandex.net>

> The indentation in your patch looks kind of off, are you not using
> Emacs' builtin auto-indentation? (also, don't leave hanging parens.)

I have (setq-default lisp-body-indent 2) in my ~/.emacs, things seemed
for me indented like the rest of the source, as for hanging parens -
there's a comment (that though should be put before paren as it relates
to the last argument), it's unnecessary.

As for monospace/proportional fonts: I don't insist on change of
shr-use-fonts default value, paragraph justification won't work with
proportional fonts though.

Current version of shr.el don't fill the text at all and I don't know
maybe smb likes it and won't welcome the change (see pics), although ERC
fills text for example.

      parent reply	other threads:[~2018-08-06 17:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 14:06 bug#32281: shr.el align support patch Bad Blue Bull
2018-08-06  2:52 ` Noam Postavsky
2018-08-06 15:13   ` Eli Zaretskii
2018-08-07  0:51     ` Bad Blue Bull
2018-08-07  0:59       ` Bad Blue Bull
2018-08-07  2:34       ` Noam Postavsky
2018-08-07 15:07       ` Eli Zaretskii
2018-08-07 16:54         ` Bad Blue Bull
2018-08-07 17:11           ` Bad Blue Bull
2018-08-07 17:19           ` Eli Zaretskii
2018-08-07 18:15             ` Bad Blue Bull
2018-08-07 18:15       ` Lars Ingebrigtsen
2018-08-07 19:56         ` Bad Blue Bull
2018-08-10  0:12           ` Noam Postavsky
2018-08-06 17:36 ` Noam Postavsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnyvxur1.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=32281@debbugs.gnu.org \
    --cc=ibmbull@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.