From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Gemini Lasswell Newsgroups: gmane.emacs.devel Subject: Re: list-threads Date: Sun, 09 Sep 2018 08:44:41 -0700 Message-ID: <87pnxmu13q.fsf@runbox.com> References: <87tvoiq208.fsf@runbox.com> <87efej3e2p.fsf@runbox.com> <83pny34pde.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1536507777 15445 195.159.176.226 (9 Sep 2018 15:42:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2018 15:42:57 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 09 17:42:53 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fz1rN-0003qa-VI for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2018 17:42:50 +0200 Original-Received: from localhost ([::1]:47768 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz1tU-0000FF-CE for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2018 11:45:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz1tO-0000Eo-69 for emacs-devel@gnu.org; Sun, 09 Sep 2018 11:44:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fz1tL-0008AY-1B for emacs-devel@gnu.org; Sun, 09 Sep 2018 11:44:54 -0400 Original-Received: from aibo.runbox.com ([91.220.196.211]:55218) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fz1tK-00088X-Ms; Sun, 09 Sep 2018 11:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=xpYHBsbycWzIgWFJvWp6vePk81fRyKBpZofU51ID5dU=; b=ZbbWFwa/7AxCus6S6yJw5sHlt+ kUPW+KZOAQO2dcIvmwUDgZZxHFfp7Rrxddvj16MnOhNrdkGnY94Ack+NfVedqUTiR4x0QRUKhhE3m y8dL571xFwCPtQLIFtw2rFT102AkHkrH9R3lbZ9fmJYLkBVB2rxcOkksYvpf7H8e+4XhiWJPY5sIe RUHe5njCJKKfBut1CFf4Y1xpREZgmS2fO9OI9leou0QIeE+095BAbej2RgKhXPBOphfT8fb2j0Fb7 aBpFO2OrdwlJMqfAl7PuByQ6kyzjmI4VyIeweloy8e+CZEgXjH3X5V9fMsaBCtLPv4NUe7J+vyu6e SgRwFLpQ==; Original-Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1fz1tI-0002Xz-40; Sun, 09 Sep 2018 17:44:48 +0200 Original-Received: by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1fz1tD-0001hF-P1; Sun, 09 Sep 2018 17:44:44 +0200 In-Reply-To: <83pny34pde.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Aug 2018 21:48:45 +0300") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 91.220.196.211 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229565 Archived-At: Eli Zaretskii writes: > A few of comments: Thanks for the feedback. > . I'm not sure the section bout list-threads should be in the ELisp > manual. It's a user command. OTOH, list-processes is also > described in the ELisp manual, hmm... list-timers is also described in the ELisp manual. All three commands are more useful to Lisp programmers than to Emacs users who don't know Lisp. So I've left it where it is. > . But if we decide to leave this section where it is, then it should > behave like any other section in that manual, which means variables > are described with @defvar. > > . Please add a cross-reference to the section where make-thread is > described where you tell that the thread's name comes from that > call. Info manuals should always cross-link to the description of > each major topic when they refer to it, because people frequently > read the manual out of order. > > . "Send a signal to the thread" is slightly misleading, because it > can be interpreted as talking about OS signals. Suggest to use > "signal the thread" instead. I'd also qualify that what each > thread does for each of the 2 signals is entirely up to the thread > (default is to exit on any signal). > > . This text is slightly inaccurate: > > Be aware that by the time you see the backtrace, the thread > may have resumed execution, and be in a different section of > code, or be completed. > > I would rephrase like this: > > Be aware that the backtrace is a snapshot; the thread could have > meanwhile resumed execution, and could be in a different state, or > could have exited. > . Finally, I think the NEWS entry should be a bit longer, and should > say this is a new command. I've made all these changes, in 8adc0e518f. > . Will the new function backtrace--frames-from-thread (and its > subroutines) compile and work in an Emacs configured without > threads? If not, they should be conditioned by THREADS_ENABLED. Yes, they compile. In an Emacs configured without threads, backtrace--frames-from-thread is present but will always give a wrong-type-argument error, because you can't make a thread object to pass to it without make-thread.