From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#22000: Patch addressing the menu-bar frame-resize interaction Date: Thu, 18 Oct 2018 14:48:21 +0200 Message-ID: <87pnw7xvxm.fsf@gmail.com> References: <87k2p8h1vn.fsf@isaac.fritz.box> <5B52E425.8010608@gmx.at> <5B543148.1010004@gmx.at> <5B557ACA.4020106@gmx.at> <5BBF93CF.4060301@gmx.at> <5BC05EEB.9010609@gmx.at> <5BC0E405.90805@gmx.at> <5BC1AAE2.7070808@gmx.at> <5BC4DB0E.3050501@gmx.at> <5BC6E4F2.2030607@gmx.at> <5BC83F03.4050006@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1539866829 12416 195.159.176.226 (18 Oct 2018 12:47:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 18 Oct 2018 12:47:09 +0000 (UTC) Cc: 22000@debbugs.gnu.org, David Engster To: Vivek Dasmohapatra Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 18 14:47:04 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD7hf-00035n-Cs for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 14:47:03 +0200 Original-Received: from localhost ([::1]:42167 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD7jl-0000T2-UR for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Oct 2018 08:49:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD7je-0000Sw-Dg for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 08:49:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gD7ja-00049c-9d for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 08:49:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51959) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gD7ja-000498-4m for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 08:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gD7jZ-00019U-TB for bug-gnu-emacs@gnu.org; Thu, 18 Oct 2018 08:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Oct 2018 12:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22000 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22000-submit@debbugs.gnu.org id=B22000.15398669114393 (code B ref 22000); Thu, 18 Oct 2018 12:49:01 +0000 Original-Received: (at 22000) by debbugs.gnu.org; 18 Oct 2018 12:48:31 +0000 Original-Received: from localhost ([127.0.0.1]:56217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD7j5-00018m-Ca for submit@debbugs.gnu.org; Thu, 18 Oct 2018 08:48:31 -0400 Original-Received: from mail-wm1-f42.google.com ([209.85.128.42]:39184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gD7j4-00018Z-Af for 22000@debbugs.gnu.org; Thu, 18 Oct 2018 08:48:30 -0400 Original-Received: by mail-wm1-f42.google.com with SMTP id y144-v6so132936wmd.4 for <22000@debbugs.gnu.org>; Thu, 18 Oct 2018 05:48:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version:content-transfer-encoding; bh=PbY/+gp+h7nRcmQbb7xKS31YCVdsqDrsLa1YqoDqbBU=; b=cRqdjGKGpt300S0/qxxCOS68Di+y9PYG7xQVKY+hmC1gubBMDzyqaWzhRldn6vGe53 XsspbhhQaxB/x5SaUSdzYEmRAZexFXvwnnr9IMpbGwULbB3WfsRZpRIl27Ml5GwTNXFg SPUZpYVuiLZfLP4fBYUTFR0hBlBy/GkV1VVp02cD61E4qSEjfV90ZJtzZ2psLWMOR1qz emDamaS9UIJGExeJBXGkIx+FWkwU2DnXz1JGTaysz1+ddA7JKWDFFSAK4vZKj9Ad2Yy0 eoyGynjtubJ0yAM4pvIYUBLTA1VLkNrxu4acmLAMxmEBHG4PV8p0EE3YldSEwXI5ewe7 b9WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version :content-transfer-encoding; bh=PbY/+gp+h7nRcmQbb7xKS31YCVdsqDrsLa1YqoDqbBU=; b=LMj9dLbU8pcdkkmqaioCYdOsuRmcKYI1X1yg79NzgiPONYP91uREXkdWmyx8x8gasi sSsTkSA+OBloGBsPa8ETsdPMBfNOxY33BfXcYurjGxCBZI270ljaMaBv4IKrOBM6PS34 5GbVg9SQejopT2iGyLzjxo5aC008YwqKzIh1UXo+xWzRN68Avlt7diBhe97W94N5Z/tX hcgK00MidzbxHPPcBhxh8shfxcQ5jEoB53YZWuku61g5hTvYAmqxIMoLM1H0AYbxcaNp gGKMHx1iZUn34IRQBmRYtLOtbOI08KOCzLlXaiWYg0eZuOYBd7HXfHQlJbPP955kbyL5 /hlw== X-Gm-Message-State: ABuFfogTizPKAfE3P2SaEM7KPB2Vtzis91olxICWOgYpKxeIwHVQO6kt irorxEnzRzEUZUcjN5nw9Yo= X-Google-Smtp-Source: ACcGV61bd13d/7/Ykz/k7tLUsJe492l4ZAeSTFEGWyPHAMT+lKdXq2Rfx2uGupDeT+UYRiuiOfSlAQ== X-Received: by 2002:a1c:4b15:: with SMTP id y21-v6mr160016wma.122.1539866904175; Thu, 18 Oct 2018 05:48:24 -0700 (PDT) Original-Received: from rpluim-ubuntu ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id y19-v6sm98239wma.7.2018.10.18.05.48.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 18 Oct 2018 05:48:23 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: (Vivek Dasmohapatra's message of "Thu, 18 Oct 2018 13:23:26 +0100 (BST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151372 Archived-At: I don=CA=BCt use the menu-bar, so I can't speak to the functionality, but various documentation nits below. (menu-bar? menubar? menu bar? I=CA=BCm not sure what the consensus is there) Vivek Dasmohapatra writes: > featurep guards added, defcustom setting emacs version bumped. > > > From 489a38cceda02e62dc50367347930713f4454f95 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Vivek=3D20Das=3DC2=3DA0Mohapatra?=3D > Date: Thu, 11 Oct 2018 13:48:47 +0100 > Subject: [PATCH 2/3] Document the new menu-bar-scrollbar frame parameter > > --- > doc/lispref/frames.texi | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/doc/lispref/frames.texi b/doc/lispref/frames.texi > index 2f9bb39886..601749d97e 100644 > --- a/doc/lispref/frames.texi > +++ b/doc/lispref/frames.texi > @@ -601,6 +601,10 @@ Frame Layout > frame unchanged, so the native height of the frame (see below) will > change instead. >=20=20 > +If the menu bar is drawn by GTK then its behavior when it would grow > +wider than the root frame is controlled by the @code{menu-bar-scrollbar} > +parameter (@pxref{Layout Parameters}). > + What is the 'root frame'? Surely the only frame that matters is the one displaying the menu bar? > @item Tool Bar > @cindex internal tool bar > @cindex external tool bar > @@ -1814,6 +1818,23 @@ Layout Parameters > (@pxref{Frame Geometry}) allows to derive whether the menu bar actually > occupies one or more lines. >=20=20 > +@vindex menu-bar-scrollbar@r{, a frame parameter} > +@item menu-bar-scrollbar > +The behavior of GTK menu bars when they would otherwise grow wider than > +the frame. Valid values are: > +@itemize > +@item @code{always} - Scrollbar is present, menu bar scrolls when > too wide. 'Scrollbar is always shown' perhaps. What does 'menu bar scrolls when too wide' mean? If the menu bar is too wide to be displayed entirely, then the user has to take some action to see the hidden items. This phrase seems to imply some kind of automatic behaviour. > +@item @code{automatic} - Scrollbar appears when menubar grows too > wide. 'Scrollbar is shown when menubar grows too wide.' > +@item @code{forced-resize} - No scrollbar. Growing menubar forces a fra= me resize. > +@item @code{nil} (or any other value) I=CA=BCd drop the 'any other value' portion, so as not to constrain any future changes. Also I think this is the one time where you use 'menubar' rather than 'menu bar'. > +@itemize > +@item GTK >=3D 3.16 - No scrollbar. Menu bar is truncated if it grows t= oo wide. > +@item GTK < 3,16 - Same behavior as @code{forced-resize}. '3.16' rather than '3,16' > +@end itemize > +@end itemize > +It is worth noting that for GTK before 3.16 the scrollbar adds a signifi= cant > +amount of vertical padding to the menubar: This appears to be unavoidabl= e. > + I=CA=BCd write 'this' rather than 'This': it=CA=BCs not a separate sentence.