From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#32897: 26.1; nxml-mode indentation Date: Fri, 19 Apr 2019 13:42:36 -0400 Message-ID: <87pnphvqlv.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="188668"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: Stefan Monnier , 32897@debbugs.gnu.org To: David Carlisle Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 19 19:43:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHXXd-000n02-0Q for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 19:43:13 +0200 Original-Received: from localhost ([127.0.0.1]:59492 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHXXc-0005F7-08 for geb-bug-gnu-emacs@m.gmane.org; Fri, 19 Apr 2019 13:43:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHXXT-0005EZ-I2 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 13:43:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHXXS-0000qh-9n for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 13:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hHXXS-0000qX-47 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 13:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hHXXR-0008Ep-Tt for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2019 13:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2019 17:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32897 X-GNU-PR-Package: emacs Original-Received: via spool by 32897-submit@debbugs.gnu.org id=B32897.155569576831645 (code B ref 32897); Fri, 19 Apr 2019 17:43:01 +0000 Original-Received: (at 32897) by debbugs.gnu.org; 19 Apr 2019 17:42:48 +0000 Original-Received: from localhost ([127.0.0.1]:44577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHXXE-0008EF-2W for submit@debbugs.gnu.org; Fri, 19 Apr 2019 13:42:48 -0400 Original-Received: from mail-qt1-f175.google.com ([209.85.160.175]:39523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hHXXB-0008Dw-G8; Fri, 19 Apr 2019 13:42:46 -0400 Original-Received: by mail-qt1-f175.google.com with SMTP id f13so5816604qto.6; Fri, 19 Apr 2019 10:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PR7qXt2NrNaFgXl90OvRQz39fCOchxc3Lj89xPv5CG4=; b=WPUDy1yWN9OvotMOU2HRTUoFCAOcZKfAl76dTzhKNu4dHnru6dnZIpM7LSDLYkUWY5 9AKgrD+9DXrXd/BbbfmBNDbREelUO4CBTWjS3fBs0Bn19sqJJQNZ/rYHh591l6KiqIqM BB3nXg58DvTI+cPGR1NYmD0H9kOL83lb+BcbcOifNNisK07OQ5sfB7ILxpj4F2EQ1AN4 9D2Ye07dH9/ZcTbiizwABWMht/oMZxV8arqbfqus5X6cDzRf6Tk7kLLR7CqQsORKanLO GRSf5NukKs/4hjBu87TyFOLowfma+vk30zsSoPbSjs8EaIHZooWH+DzHxLfE3k5hU/Xt Kp7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=PR7qXt2NrNaFgXl90OvRQz39fCOchxc3Lj89xPv5CG4=; b=FwKn0yZoyiQn64lZ3ePYHM5gs2eHVxuXSlomXelJpYiN+nfzhjIHg+eL7Zvytlrbki vPQjFfu4EyipmJoAQtMzP4h7xTVGSMnZELZfCUW7ekU56Ta14c4jgKtWBxm5rHNjH+Xj 87hELaQFYPVOk28MBIefDjSgT/+wcuuux5B8fGzud6wUtLlAnOmC7eVcBraU/NYxRI5d RkaLf2rWa65GlQw6guivojR7wWNEyTIZkYvC9qhNDHFgKzPUTg5EzLikDs6gCSaU5hbZ Z/homyN99a/CUjO1XnDGvMH5fWXmLHlGBqv7aJSIZytNT9VehVuVB1V2sr+tv4mBCFYZ RRzg== X-Gm-Message-State: APjAAAVRmUTptmnIp176V80gMzQSeD+FoysPSkLvpgtJfXP0M0OPTLH8 iJlObWnM94Abxt+eWnvsY6Sm49AV X-Google-Smtp-Source: APXvYqy6wxXKkFuI7nQJ0O1+ycqzOGeVgJQAk3Q6Z8v9j7YQ0alaZN48omDdoC/50qPBYlZGigwZ2A== X-Received: by 2002:a0c:b291:: with SMTP id r17mr4321723qve.206.1555695758929; Fri, 19 Apr 2019 10:42:38 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u15sm3373558qth.54.2019.04.19.10.42.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 19 Apr 2019 10:42:38 -0700 (PDT) In-Reply-To: (David Carlisle's message of "Mon, 1 Oct 2018 10:44:37 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157856 Archived-At: --=-=-= Content-Type: text/plain retitle 32897 nxml-mode nxml-char-ref-extra-display for (newline) is unwanted severity 32897 minor tags 32897 + patch quit [For the indentation aspect of this bug, see Bug#32003.] David Carlisle writes: > Also it does not show a visual newline for #10, even when other numeric > references to printable characters do display the character, which was > the desired behaviour. I assume this was changed by [1: 930f8e8377]. I guess can just special case newline, it's the only character that has this problem that I can think of. This would be for emacs-26 since it's a regression. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Disable-extra-display-of-10-in-nxml-mode-Bug-32897.patch Content-Description: patch >From 689e90314f73fef3b2a7bdda183ca78101a5d449 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Fri, 19 Apr 2019 13:28:00 -0400 Subject: [PATCH] Disable extra display of in nxml-mode (Bug#32897) * lisp/nxml/nxml-mode.el (nxml-char-ref-display-extra): Don't put display for the newline, it makes the indentation look wrong. --- lisp/nxml/nxml-mode.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lisp/nxml/nxml-mode.el b/lisp/nxml/nxml-mode.el index f17f5843b8..14748d5c56 100644 --- a/lisp/nxml/nxml-mode.el +++ b/lisp/nxml/nxml-mode.el @@ -2378,7 +2378,9 @@ (defun nxml-toggle-char-ref-extra-display (arg) (put 'nxml-char-ref 'evaporate t) (defun nxml-char-ref-display-extra (start end n) - (when nxml-char-ref-extra-display + (when (and ;; Displaying literal newline is unhelpful. + (not eql n ?\n) + nxml-char-ref-extra-display) (let ((name (or (get-char-code-property n 'name) (get-char-code-property n 'old-name))) (glyph-string (and nxml-char-ref-display-glyph-flag -- 2.11.0 --=-=-= Content-Type: text/plain [1: 930f8e8377]: 2016-01-15 10:29:20 -0500 Update nXML to use Emacs's Unicode support, and lexical-binding https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=930f8e8377e40ba161bd16ea4d612cb4c570ee1b --=-=-=--