From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35273: "Marker does not point anywhere" when reading next article Date: Sat, 27 Apr 2019 15:28:01 -0400 Message-ID: <87pnp7p7su.fsf@gmail.com> References: <875zrgpusw.fsf@vuxu.org> <87lg0czgy1.fsf@tcd.ie> <8736mkgu83.fsf@vuxu.org> <87zhoqxgzn.fsf@gmail.com> <87wojum7vc.fsf@vuxu.org> <87wojuxfdl.fsf@gmail.com> <87sguim6gn.fsf@vuxu.org> <87tveyxdd7.fsf@gmail.com> <83h8aygfil.fsf@gnu.org> <87zhokubjp.fsf@gmail.com> <83d0lgbxln.fsf@gnu.org> <83zhokabrx.fsf@gnu.org> <871s1nqv6y.fsf@gmail.com> <83ef5nv1eb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256221"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: contovob@tcd.ie, 35273@debbugs.gnu.org, leah@vuxu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 27 21:42:41 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hKTDa-0014Vu-W6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2019 21:42:39 +0200 Original-Received: from localhost ([127.0.0.1]:35701 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKTDZ-0003J4-Uf for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Apr 2019 15:42:37 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hKTDR-0003CK-1u for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 15:42:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hKT0Q-0004Ux-Ti for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 15:29:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50728) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hKT0Q-0004Ur-Q3 for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2019 15:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hKT0Q-0008Bz-8U; Sat, 27 Apr 2019 15:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Sat, 27 Apr 2019 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35273 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 35273-submit@debbugs.gnu.org id=B35273.155639329331432 (code B ref 35273); Sat, 27 Apr 2019 19:29:02 +0000 Original-Received: (at 35273) by debbugs.gnu.org; 27 Apr 2019 19:28:13 +0000 Original-Received: from localhost ([127.0.0.1]:36037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKSzd-0008Ap-5o for submit@debbugs.gnu.org; Sat, 27 Apr 2019 15:28:13 -0400 Original-Received: from mail-qk1-f174.google.com ([209.85.222.174]:39234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hKSza-0008AV-62; Sat, 27 Apr 2019 15:28:11 -0400 Original-Received: by mail-qk1-f174.google.com with SMTP id f125so3860621qke.6; Sat, 27 Apr 2019 12:28:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kmXXoVIravaECbUZeUJBjeyjsbkxwtrdVaolb3iNpSA=; b=ZSUktDnzheR9CX5l4SjMyZBYhdGl/7QgwHTwy0YBX8JMS79gj/54fFuqiXtHXESiQu vhHmf5Arrjgkg3j7a2y4Zs6plyekzQAOjRIeiVratvmlWiwh/JCU001ojiKpuyIAcXMv nfJA0g/S8UXo7xSSuoLkfuOg1iqHuvAw/cd7aTAqyFMXgor7SZpNuC4jBVYqlI3+3f3f /UqEbh7lWIWZph4LzAoontqHON01hEwhrFTAK4kOW0EKJUKi70714YnyPMFVJ4/tcVEk yi0mJjcA7Ri8afQKKj70B+RxK38khJXknOqaddOUvz2AsTWIrv5ehGHm8GkU8U026tBk aw9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kmXXoVIravaECbUZeUJBjeyjsbkxwtrdVaolb3iNpSA=; b=Z1AWRTCgkcKd2+5OS1Lg15vK3tDePK4T1GNS0YsI/IJeHkO5QASKDhSL5EQqo2S0Lp Y1VMnqfRYXOKosUQsxecGdifh6W1fsKkuwBEvvjhZApSlpKVdRm3jgt+VA/CosFk9Zwe xgL9Esou7/50SSzbMb3XYaUDWPKNbJ18JpWw90d2ZmFaJFIYDHm03wZzABsaMOjE8uPD nc68kWcOvl3qaxjcoI1JZiVszjlKl+Y4ORv6p9K2NwDI/2nDP+5AF0L1+JaSJ7J3Hkrt eLB+ItX3hwEfzcFe8/kxv2c95sVOLiYF1dsHH4a9305N/FCjF5pkkWJd5jXxmwfW3wnF JmsA== X-Gm-Message-State: APjAAAVJiRNci9lUqTTxTsNO+l4CFKss3EHFo/eteZcU6BpKVyUZj7kM 964iJZ8rqadfyMQqyfIPgFCtN+Ip X-Google-Smtp-Source: APXvYqy+z2ftVombYxENUq61uRKbvSwto1tdXJm87kUBMbX3H4HClnfWi7axVhQqGIKMT6M6HvAoNA== X-Received: by 2002:ae9:e913:: with SMTP id x19mr28581533qkf.103.1556393284353; Sat, 27 Apr 2019 12:28:04 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id 67sm10234461qtc.29.2019.04.27.12.28.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 Apr 2019 12:28:02 -0700 (PDT) In-Reply-To: <83ef5nv1eb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Apr 2019 19:49:48 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158374 Archived-At: --=-=-= Content-Type: text/plain tags 35273 + patch quit Eli Zaretskii writes: >> From: Noam Postavsky >> I managed to reproduce (wasn't too hard actually). All the overlay >> deletion seems to come from gnus. I got hits from erase-buffer (called >> by gnus), gnus-kill-all-overlays, and gnus-cite-delete-overlays. > > OK, thanks. Then I think it would be better to test the overlay for > being dead in xdisp.c, before we call mouse_face_overlay_overlaps. > Also, a faster test would be to check that the marker's buffer is a > NULL pointer, doing that doesn't require a call marker-position. > WDYT? Sure, that works. Should I push to emacs-26? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Check-if-mouse_face_overlay-was-deleted-Bug-35273.patch Content-Description: patch >From 912e336d107cd1bb840cc921b4893bfc0d6cfa98 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 27 Apr 2019 15:22:11 -0400 Subject: [PATCH] Check if mouse_face_overlay was deleted (Bug#35273) * src/xdisp.c (note_mouse_highlight): Check if the mouse_face_overlay actually points to a buffer, before calling mouse_face_overlay_overlaps on it. --- src/xdisp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/xdisp.c b/src/xdisp.c index 0c3754a338..aa6e1bd2df 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -31526,7 +31526,9 @@ note_mouse_highlight (struct frame *f, int x, int y) is currently hidden to avoid Bug#30519. */ || (!hlinfo->mouse_face_hidden && OVERLAYP (hlinfo->mouse_face_overlay) - && mouse_face_overlay_overlaps (hlinfo->mouse_face_overlay))) + /* It's possible the overlay was deleted (Bug#35273). */ + && XMARKER (OVERLAY_START (hlinfo->mouse_face_overlay))->buffer + && mouse_face_overlay_overlaps (hlinfo->mouse_face_overlay))) { /* Find the highest priority overlay with a mouse-face. */ Lisp_Object overlay = Qnil; -- 2.11.0 --=-=-=--