From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: contovob@tcd.ie, 35273@debbugs.gnu.org, leah@vuxu.org
Subject: bug#35273: "Marker does not point anywhere" when reading next article
Date: Sat, 27 Apr 2019 15:28:01 -0400 [thread overview]
Message-ID: <87pnp7p7su.fsf@gmail.com> (raw)
In-Reply-To: <83ef5nv1eb.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Apr 2019 19:49:48 +0300")
[-- Attachment #1: Type: text/plain, Size: 657 bytes --]
tags 35273 + patch
quit
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Noam Postavsky <npostavs@gmail.com>
>> I managed to reproduce (wasn't too hard actually). All the overlay
>> deletion seems to come from gnus. I got hits from erase-buffer (called
>> by gnus), gnus-kill-all-overlays, and gnus-cite-delete-overlays.
>
> OK, thanks. Then I think it would be better to test the overlay for
> being dead in xdisp.c, before we call mouse_face_overlay_overlaps.
> Also, a faster test would be to check that the marker's buffer is a
> NULL pointer, doing that doesn't require a call marker-position.
> WDYT?
Sure, that works. Should I push to emacs-26?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1172 bytes --]
From 912e336d107cd1bb840cc921b4893bfc0d6cfa98 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 27 Apr 2019 15:22:11 -0400
Subject: [PATCH] Check if mouse_face_overlay was deleted (Bug#35273)
* src/xdisp.c (note_mouse_highlight): Check if the mouse_face_overlay
actually points to a buffer, before calling
mouse_face_overlay_overlaps on it.
---
src/xdisp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/xdisp.c b/src/xdisp.c
index 0c3754a338..aa6e1bd2df 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -31526,7 +31526,9 @@ note_mouse_highlight (struct frame *f, int x, int y)
is currently hidden to avoid Bug#30519. */
|| (!hlinfo->mouse_face_hidden
&& OVERLAYP (hlinfo->mouse_face_overlay)
- && mouse_face_overlay_overlaps (hlinfo->mouse_face_overlay)))
+ /* It's possible the overlay was deleted (Bug#35273). */
+ && XMARKER (OVERLAY_START (hlinfo->mouse_face_overlay))->buffer
+ && mouse_face_overlay_overlaps (hlinfo->mouse_face_overlay)))
{
/* Find the highest priority overlay with a mouse-face. */
Lisp_Object overlay = Qnil;
--
2.11.0
next prev parent reply other threads:[~2019-04-27 19:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-14 13:42 bug#35273: "Marker does not point anywhere" when reading next article Leah Neukirchen
2019-04-14 16:31 ` Basil L. Contovounesios
2019-04-14 21:19 ` Leah Neukirchen
2019-04-16 12:38 ` Noam Postavsky
2019-04-16 12:50 ` Leah Neukirchen
2019-04-16 13:13 ` Noam Postavsky
2019-04-16 13:21 ` Leah Neukirchen
2019-04-16 13:56 ` Noam Postavsky
2019-04-16 14:04 ` Leah Neukirchen
2019-04-16 15:02 ` Eli Zaretskii
2019-04-20 12:05 ` Noam Postavsky
2019-04-20 13:44 ` Eli Zaretskii
2019-04-20 16:20 ` Eli Zaretskii
2019-04-27 16:17 ` Noam Postavsky
2019-04-27 16:49 ` Eli Zaretskii
2019-04-27 19:28 ` Noam Postavsky [this message]
2019-04-27 19:35 ` Eli Zaretskii
2019-04-28 12:45 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnp7p7su.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=35273@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
--cc=leah@vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.