From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#35497: [PATCH] Don't rewrite buffer contents after saving by rename Date: Tue, 30 Apr 2019 09:18:18 +0200 Message-ID: <87pnp4t0zp.fsf@gmx.de> References: <20190429232009.94549-1-jktomer@google.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="197941"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35497@debbugs.gnu.org To: Jonathan Tomer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 30 09:45:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hLNRt-000pKP-Hs for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 09:45:09 +0200 Original-Received: from localhost ([127.0.0.1]:40852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLNRr-0006Mh-Sj for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Apr 2019 03:45:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56691) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLN2c-00013z-W4 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:19:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLN2c-0005qR-3F for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLN2b-0005qK-W4 for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLN2b-0002wj-QB for bug-gnu-emacs@gnu.org; Tue, 30 Apr 2019 03:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Apr 2019 07:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35497-submit@debbugs.gnu.org id=B35497.155660871011283 (code B ref 35497); Tue, 30 Apr 2019 07:19:01 +0000 Original-Received: (at 35497) by debbugs.gnu.org; 30 Apr 2019 07:18:30 +0000 Original-Received: from localhost ([127.0.0.1]:40547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLN26-0002vu-5G for submit@debbugs.gnu.org; Tue, 30 Apr 2019 03:18:30 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:51793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hLN24-0002vh-Ht for 35497@debbugs.gnu.org; Tue, 30 Apr 2019 03:18:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1556608700; bh=6I/JA8qyJ+iPhircUHWWOYlwZYHYVHi59pmLytkiUFg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=RB9qB6DaUvXK9rGCxf06oiaqI3Z5o/0mhdXWLYKRTxUO1/QLO8WtIyRWpDh+Snxqz nbI7Qvp1cUfwy3iClIkGORsDFipoeSbN2AUtNLOanZk9RFlyX7W15e2sjOUbKc9fn1 gw7BIA3b4qJnaxxqtwY9nTdUqGis7oTu3rtFCP0A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.52.91]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LvE2c-1gca1x3u4Y-010JdV; Tue, 30 Apr 2019 09:18:20 +0200 In-Reply-To: <20190429232009.94549-1-jktomer@google.com> (Jonathan Tomer's message of "Mon, 29 Apr 2019 16:20:09 -0700") X-Provags-ID: V03:K1:IRp2L5Kvd4YIQcYu51zY+wS5iIfhxfUuTZCi2K8KEZU1E5em8Ek j3IgYa9/TsRhdmaorBSRp712oxPfcfGEwOuAx4z9wu36WePwHN87u5gzjb04Al+LgtD6VY2 G1macFmAY3aLbEU9M6i9oKDB8QjuTqrbVqMJQW7V6Ks6xAi2fpyfmd6yxQbjVdOA7uSGQSw sUaUL51BQ+bv1JbMWM/lg== X-UI-Out-Filterresults: notjunk:1;V03:K0:cLBHMVRjcJU=:FMqSmwQs8jU759pitCrBQg rPtIokm9VfaN29rVJ+Dha7o5500nhrRn1Wy2S7u6poegjGDH/NaBfgBg/qUWn0oF0NuOoWmN2 D4L0+S1nzqh7nmK4XwNVqt8DfMn83Zp3dLBVz2iPnW1nybGfWZGiNYOVkhzlY43cYKhoAFEwg 0ddl6j7QvgFU+S909YeolshFcs7HhDYTQprH30ATEp3uiN7cj5TbLjZuJx/Q/v1t2EC/jx+Vj GMeQClHD4KOM23AjTmA//fXcI8lqWKnpjXzQczFknGVsWQy9SbVgU0RQ75jfwbB8o0cE3oie7 pDa06ipsRyUjXpVg7Etl9i8MawxOwIFR/Ng1w1JI/sEcL2CeMV4xgO8StVR0aUgqupQ3emw6U McMSUhffs7UXYQUI+NLsInOnXeVabClmI1EFdmakpFJHhvkqjzqyRNIpVC73KvylLR3gjy5Vf aeqDZ0qbm4hRJl1goqAm5iw3gW3l7wmDzuvQR5rHPRi0vuYaalvNkgx4yqnLf+40WjKN+Hgw5 uVUzYpdmaaU5IaMp0JMspvDio1oPoKzNFriAzIqtL9aMNNRDCNyw0sY9vu6mYLzi/vH71BBOd SQN82+eTVCdncRytu2cweGk+imd8BB6VDyS/M6gxwXr9U/GkhtMGAqvZuesLJ2sQqNtHO9S1Q q2HqMCKlXis27AU5nx5+5OYfBstGTFEKVG75HwzB+RfEIH5oxYl9HYpiolRYKJ+EWh56WrW8k 56kRUzFAvdNnEdgO/pFvP1WjEkwfbiF+Zg0YP5Q0gLVUV26DD0krm04AiP/LMHZENq08BDSM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158481 Archived-At: Jonathan Tomer writes: Hi Jonathan, Thanks for the patch. > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -340,6 +340,13 @@ longer. > ** Multicolor fonts such as "Noto Color Emoji" can be displayed on > Emacs configured with Cairo drawing and linked with cairo >=3D 1.16.0. > > +--- > +** The file-precious-flag is now respected correctly. > +A bug previously caused files to be saved twice when > +`file-precious-flag' or `break-hardlinks-on-save' were specified: once > +by renaming a temporary file to the destination name, and then again > +by truncating and rewriting the file, which is exactly what > +`file-precious-flag' is supposed to avoid. > =0C > * Editing Changes in Emacs 27.1 We don't describe bug fixes in etc/NEWS. > +(ert-deftest files-tests-dont-rewrite-precious-files () > + "Test that `file-precious-flag' forces files to be saved by > +renaming only, rather than modified in-place." I haven't checked the situation with Tramp. It cares also for file-precious-flag, bug I don't remember whether it behaves as strict as you have tested here. Do you want to write a Tramp test for this? It would fit into tramp-tests.el. Best regards, Michael.