From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#35476: font-lock-{append, prepend}-text-property and anonymous faces Date: Sun, 12 May 2019 15:09:36 -0400 Message-ID: <87pnonh4lr.fsf@gmail.com> References: <87lfzu9hsl.fsf@gmail.com> <87a7g8owim.fsf@gmail.com> <87ftpqq1kl.fsf_-_@gmail.com> <87a7frj1qg.fsf_-_@gmail.com> <87d0knshkm.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="135912"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 35476@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 12 21:10:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hPtrT-000ZFa-BR for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 21:10:15 +0200 Original-Received: from localhost ([127.0.0.1]:46374 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPtrQ-0006cq-Ek for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2019 15:10:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37615) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hPtrI-0006ch-R5 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:10:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hPtrG-00023H-R3 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:10:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hPtrG-00022F-L2 for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hPtrG-0001GR-7u for bug-gnu-emacs@gnu.org; Sun, 12 May 2019 15:10:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 May 2019 19:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35476 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35476-submit@debbugs.gnu.org id=B35476.15576881864830 (code B ref 35476); Sun, 12 May 2019 19:10:02 +0000 Original-Received: (at 35476) by debbugs.gnu.org; 12 May 2019 19:09:46 +0000 Original-Received: from localhost ([127.0.0.1]:43325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPtqz-0001Fp-L3 for submit@debbugs.gnu.org; Sun, 12 May 2019 15:09:46 -0400 Original-Received: from mail-it1-f174.google.com ([209.85.166.174]:40890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hPtqx-0001Fb-MM for 35476@debbugs.gnu.org; Sun, 12 May 2019 15:09:44 -0400 Original-Received: by mail-it1-f174.google.com with SMTP id g71so17006457ita.5 for <35476@debbugs.gnu.org>; Sun, 12 May 2019 12:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=VfPS7JGFOI/Ei2myOCn6KZv3fMdcydBVX5vHpoe+V24=; b=qVXeD/TTM7WTTIRQ8/OyaWKHulUEpPubMj0cbkKNLUaIRDkiqD/a7ORJMF1QMUFhbC HuIlBrtWOzWRn62CCpMi3T/HN0oYiJ9JwYYWSgtowp+Y06MOgu1PkLVd8Ef8BMYjeXlJ OA11wsTJ3yJvDG9VF04Xx7Z1Fc+5myDTm9VgJV93EQDycHuGW8PfyKNtdLsEH1c+8MK2 UTjtAkIilxwvUQjsQe+inzYM8fzZja2gAap4J5+Ks2TX3vf6uz92nsfZmMbja3d5OLNy GYLetFyiVKEQIJmq791y0g0QtGWj5Y2m8WOC657Je1SAXwjgsYAoEtu4smi/1bGOxad9 28Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VfPS7JGFOI/Ei2myOCn6KZv3fMdcydBVX5vHpoe+V24=; b=IIRTBtJYRJiYrkEgeCuwDu2An2iDmONdIsZ3Xt4Oy48Zo9d3rayAkg1qDrAx2YnqvL +K0OAqnhJqjNC7uuYb6mPyAaq3aNWvPE4nHZXpM7F0CSpma50UvEvB64CroioMmlG5Mb xaJ5CgI0CS3PIni+T7TxKr4iKtq7pUZjFF2+CejRKU82w00Mgo+ZLDAYayPuYXY9z6Bd na2yc1qtYDE+vtJ5miqisZ0tgxr/tFKUuI/4/yviPt93vErMsyxyat3ma6YYnMcDMuy/ 66oq/BiXhYNZujZEKVcE8rnKF/sylTql6I7yQTgTD4Jai5UfTvhwpJdTeokdGgzeUDTH vvfg== X-Gm-Message-State: APjAAAUuvDBBr0PvYG/yw/pCB8Ogzm+zzUPfjwGp4V3pv5mYzjbK5bU+ gMdeQM28cCERK8DCJDkrAJujh7yN X-Google-Smtp-Source: APXvYqw1jCYNrqHuc+8HQM9gHZo1RDDNLrw9rGOiO5yh7Ybvf17eBJBIE+fufrat59XWoemixiNsGA== X-Received: by 2002:a24:9414:: with SMTP id j20mr14983626ite.91.1557688178006; Sun, 12 May 2019 12:09:38 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id x74sm5401616itb.33.2019.05.12.12.09.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 12 May 2019 12:09:37 -0700 (PDT) In-Reply-To: <87d0knshkm.fsf@gmail.com> ("=?UTF-8?Q?K=C3=A9vin?= Le Gouguec"'s message of "Sun, 12 May 2019 19:34:01 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159148 Archived-At: Looks basically good, I just have a few nitpicks below. > Subject: [PATCH 1/2] Stop splicing anonymous faces in > font-lock-append-text-property > > This is the same fix as f478082, which was only applied to It's best to avoid using hashes in commit messages, as they're translated to ChangeLog files which might read from the tarball (i.e., without a git repo to hand). CONTRIBUTE talks about using "action stamps" but I think date+title is more readable. Which would be: 2019-04-29 "Refrain from splicing anonymous faces in text properties". > +(provide 'font-lock-tests) I don't think there is any reason to `provide' a feature in a test file (I know some other test files do that, but I don't see why), test files are generally not loaded via require. > Subject: [PATCH 2/2] Extract common code for adding text properties > + (let ((new-value (if append > + (append (if (listp prev) prev (list prev)) val) > + (append val (if (listp prev) prev (list prev)))))) I would suggest to factor out the (if (listp prev) prev (list prev)) from these expressions.