From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dario Gjorgjevski Newsgroups: gmane.emacs.bugs Subject: bug#35771: [PATCH] Customization type of recentf-max-saved-items Date: Sun, 19 May 2019 11:15:24 +0200 Message-ID: <87pnoe4xg3.fsf@gmail.com> References: <87pnohb79x.fsf@gmail.com> <87r28xxlzu.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="154711"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35771@debbugs.gnu.org To: "Basil L. Contovounesios" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 19 11:16:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hSHvS-000e7X-5B for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 May 2019 11:16:14 +0200 Original-Received: from localhost ([127.0.0.1]:45987 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSHvR-0005eq-6j for geb-bug-gnu-emacs@m.gmane.org; Sun, 19 May 2019 05:16:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSHvJ-0005cZ-8f for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 05:16:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSHvH-0008Pe-Az for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 05:16:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48461) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hSHvF-0008Or-Rw for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 05:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hSHvF-0001qE-Ml for bug-gnu-emacs@gnu.org; Sun, 19 May 2019 05:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dario Gjorgjevski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 May 2019 09:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35771 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35771-submit@debbugs.gnu.org id=B35771.15582573357046 (code B ref 35771); Sun, 19 May 2019 09:16:01 +0000 Original-Received: (at 35771) by debbugs.gnu.org; 19 May 2019 09:15:35 +0000 Original-Received: from localhost ([127.0.0.1]:33772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSHup-0001pZ-Dr for submit@debbugs.gnu.org; Sun, 19 May 2019 05:15:35 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:45984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hSHum-0001pI-SO for 35771@debbugs.gnu.org; Sun, 19 May 2019 05:15:33 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id g57so18437490edc.12 for <35771@debbugs.gnu.org>; Sun, 19 May 2019 02:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RqiSVaRTsk6zO+DgezCCjY409gxPWHCy9GGApCuLjx4=; b=vKOG15Kb79pH1hAigOJ53RSiPvtCSKR4K0CZbq6PUtzA1jkfKmn7ethpjyHTsOBFqt odeUHOX/SZtsC3qeg9R+ATBavIx1BkYkXVBJlxjXElLUrLlhLAGVu1krw9SjBnvUTUxb homJoaCCH8M+WmtjwkxxQc0wU3KX2lR1QxOUtJaNNMndv1G591A2D3oBZO+5Y7zj5V6f NtMhXeOoEmuut1CU8zRwcfeoy8DpAOwu/w6KqlaxhDtl4iE0jP3YGkFrf1b/cUYW362x YrVuEozymPDa/PN3M/pFn1N8dOjMBYuBLWbajeyJMbuWQRgOpqbzasMhL5vNpszVs3at cu9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=RqiSVaRTsk6zO+DgezCCjY409gxPWHCy9GGApCuLjx4=; b=nn152GeQMxMfcXZQqD7kZvfS8JDYdbAmTcvYIKRFtbOPzFVqDu7ZcmLkeMInLsCyOH LP7nUcs26Zo5DSdnP736TRRPsq8O0nfMZ+J6RTYBCr1sykp2DOgW3/j2APRkA9JPcwwA dCSIDujpng6eayuCZs+bRe/V7oY+usMzkisijvwuH/tmCuMbhfDdT9QTXvV04qSKfFAs NxP2KhQjgxNsiCqiCbHnRCXFwlctrCgc5r9n473WPm7EB/5C1MMcE1XxcuvxoHqojG19 c54nwucjhmbFrvrFFaZwVH2v7q3L/QpEck5WN23n8vSO3ni7vnLrVQcRKPqfOmKUXr5Y /GmA== X-Gm-Message-State: APjAAAVJ8ba3DJVeZKyniyPuOznJF9X0ThNd9ZCSxwNB/qMiVW9XtQK5 HNDf/PQWmKlMonRIAmAoWI/1eV1Q5nM= X-Google-Smtp-Source: APXvYqy2cSHZFBC/HVztVFt2hCQSVlefCUtYV8tEjDQmXF0jWpX6/BCOqe7RlaP+tVj+nA+icta5Eg== X-Received: by 2002:a50:94ed:: with SMTP id t42mr69360723eda.288.1558257326760; Sun, 19 May 2019 02:15:26 -0700 (PDT) Original-Received: from dario-XPS-13-9370.gmail.com (cable-158-181-75-102.cust.telecolumbus.net. [158.181.75.102]) by smtp.gmail.com with ESMTPSA id b53sm3903954edd.89.2019.05.19.02.15.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 19 May 2019 02:15:25 -0700 (PDT) In-Reply-To: <87r28xxlzu.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 17 May 2019 14:13:09 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159529 Archived-At: --=-=-= Content-Type: text/plain "Basil L. Contovounesios" writes: > (I'm curious as to why :value is set to 1 rather than the default values > 20 and 400 of the user options recentf-max-saved-items and > save-place-limit, respectively. Not an important issue, though.) I was also wondering the same thing. > See the outlines "Commit messages" and "Generating ChangeLog entries" > in the file CONTRIBUTE for the preferred commit message format. > In particular, it should mention the names of the file and variable > changed, as well as the bug#number. Thanks. I am attaching a patch file with a properly formatted commit message. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Customization-type-of-recentf-max-saved-items.patch Content-Description: Change customization type of recentf-max-saved-items to allow for nil >From 46a0d4715ce49aee376a4d253a129c5d6b5b97a8 Mon Sep 17 00:00:00 2001 From: Dario Gjorgjevski Date: Fri, 17 May 2019 11:46:54 +0200 Subject: [PATCH] Customization type of recentf-max-saved-items Change the customization type of recentf-max-saved-items to include nil, as it is an allowed value (Bug#35771). * lisp/recentf.el (recentf-max-saved-items): Change the customization type in the defcustom. --- lisp/recentf.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/recentf.el b/lisp/recentf.el index 9b70017a38..4112b44e48 100644 --- a/lisp/recentf.el +++ b/lisp/recentf.el @@ -67,7 +67,8 @@ You should define the options of your own filters in this group." A nil value means to save the whole list. See the command `recentf-save-list'." :group 'recentf - :type 'integer) + :type '(choice (integer :tag "Entries" :value 1) + (const :tag "No Limit" nil))) (defcustom recentf-save-file (locate-user-emacs-file "recentf" ".recentf") "File to save the recent list into." -- 2.20.1 --=-=-= Content-Type: text/plain -- Dario Gjorgjevski :: dario.gjorgjevski@gmail.com :: +389 (0)70 784 142 --=-=-=--