From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: 35771@debbugs.gnu.org
Subject: bug#35771: [PATCH] Customization type of recentf-max-saved-items
Date: Sun, 19 May 2019 11:15:24 +0200 [thread overview]
Message-ID: <87pnoe4xg3.fsf@gmail.com> (raw)
In-Reply-To: <87r28xxlzu.fsf@tcd.ie> (Basil L. Contovounesios's message of "Fri, 17 May 2019 14:13:09 +0100")
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> (I'm curious as to why :value is set to 1 rather than the default values
> 20 and 400 of the user options recentf-max-saved-items and
> save-place-limit, respectively. Not an important issue, though.)
I was also wondering the same thing.
> See the outlines "Commit messages" and "Generating ChangeLog entries"
> in the file CONTRIBUTE for the preferred commit message format.
> In particular, it should mention the names of the file and variable
> changed, as well as the bug#number.
Thanks. I am attaching a patch file with a properly formatted commit
message.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Change customization type of recentf-max-saved-items to allow for nil --]
[-- Type: text/x-diff, Size: 1061 bytes --]
From 46a0d4715ce49aee376a4d253a129c5d6b5b97a8 Mon Sep 17 00:00:00 2001
From: Dario Gjorgjevski <dario.gjorgjevski+git@gmail.com>
Date: Fri, 17 May 2019 11:46:54 +0200
Subject: [PATCH] Customization type of recentf-max-saved-items
Change the customization type of recentf-max-saved-items to include
nil, as it is an allowed value (Bug#35771).
* lisp/recentf.el (recentf-max-saved-items): Change the customization
type in the defcustom.
---
lisp/recentf.el | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lisp/recentf.el b/lisp/recentf.el
index 9b70017a38..4112b44e48 100644
--- a/lisp/recentf.el
+++ b/lisp/recentf.el
@@ -67,7 +67,8 @@ You should define the options of your own filters in this group."
A nil value means to save the whole list.
See the command `recentf-save-list'."
:group 'recentf
- :type 'integer)
+ :type '(choice (integer :tag "Entries" :value 1)
+ (const :tag "No Limit" nil)))
(defcustom recentf-save-file (locate-user-emacs-file "recentf" ".recentf")
"File to save the recent list into."
--
2.20.1
[-- Attachment #3: Type: text/plain, Size: 76 bytes --]
--
Dario Gjorgjevski :: dario.gjorgjevski@gmail.com :: +389 (0)70 784 142
next prev parent reply other threads:[~2019-05-19 9:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 12:22 bug#35771: [PATCH] Customization type of recentf-max-saved-items Dario Gjorgjevski
2019-05-17 13:13 ` Basil L. Contovounesios
2019-05-17 13:33 ` Eli Zaretskii
2019-05-17 14:14 ` Basil L. Contovounesios
2019-05-17 14:39 ` Eli Zaretskii
2019-05-19 9:15 ` Dario Gjorgjevski [this message]
2019-05-23 0:21 ` Basil L. Contovounesios
2019-05-17 13:36 ` Drew Adams
2019-05-17 14:17 ` Basil L. Contovounesios
2019-05-17 15:30 ` Drew Adams
2019-05-18 16:58 ` Basil L. Contovounesios
2019-05-18 23:10 ` Drew Adams
2019-05-19 2:52 ` Basil L. Contovounesios
2019-05-22 5:28 ` Eli Zaretskii
2019-05-23 0:24 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnoe4xg3.fsf@gmail.com \
--to=dario.gjorgjevski@gmail.com \
--cc=35771@debbugs.gnu.org \
--cc=contovob@tcd.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.