From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#35967: [PATCH] avoid flyspell error if point is at bob Date: Thu, 30 May 2019 12:58:29 +0100 Message-ID: <87pno0upay.fsf@tcd.ie> References: <87h89e8g3a.fsf@gmail.com> <83pno1xmz1.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="203097"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Alex Branham , 35967@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 30 13:59:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWJiB-000qj0-8V for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 13:59:11 +0200 Original-Received: from localhost ([127.0.0.1]:52690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWJiA-0005DU-5n for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 07:59:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWJi3-0005DM-Pj for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:59:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWJi2-00022p-Ko for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:59:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47345) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWJi2-00021n-Gu for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWJi2-0006eZ-Av for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 07:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 11:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35967 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 35967-submit@debbugs.gnu.org id=B35967.155921751925533 (code B ref 35967); Thu, 30 May 2019 11:59:02 +0000 Original-Received: (at 35967) by debbugs.gnu.org; 30 May 2019 11:58:39 +0000 Original-Received: from localhost ([127.0.0.1]:60889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWJhf-0006dl-EM for submit@debbugs.gnu.org; Thu, 30 May 2019 07:58:39 -0400 Original-Received: from mail-ed1-f66.google.com ([209.85.208.66]:37053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWJhe-0006dW-1F for 35967@debbugs.gnu.org; Thu, 30 May 2019 07:58:38 -0400 Original-Received: by mail-ed1-f66.google.com with SMTP id w37so8781906edw.4 for <35967@debbugs.gnu.org>; Thu, 30 May 2019 04:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=EhRGndsuaKv3PrCptNEJ+Wo/jgSVPMqF9W78Wgega5o=; b=a+xkkd8N6ZcNhdg1XkjkgvBqtMbVKI9sv41bXvGslahS1SoPH/TxY8NLCn5UHuUdC1 jlgS2hYLh1m682MZTzMats0FwHUMAsRpps1BQUQWusI4xrq7KoPxycBsAOieIV38am0W uFL2KKnSkj982aHMxGmPYPd7Ku5NUFr+A3qMBDYUPHI0rGkuHeWJsWygC7YtNu88a267 syN5St+Ty+vFCfqwJG67LctzRyCF5uw+A0iZHicCshtc+JTYyLbTxpeQCAcKsOvQnb5n R/jvyfU2S3ME3AhesikGDbpaFFcbm3aQODkdR/zTKo9cUyEkTJPwOw5oiIHE1fKkfl7h 7/qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EhRGndsuaKv3PrCptNEJ+Wo/jgSVPMqF9W78Wgega5o=; b=Joj1HKBXNskgXHv2TLJ7YAjyOlrdTSLM/lwj7HhQgLD4t0RytQYOmVUgJMprLyKqVd rbWDLYEkmRNP19utqVZdpTyk1273y24nAdyU9lEQbB/+6pdvefZLZbpPBSHrcGStMot4 KibwpzKq2hLZrqkXYQf5uZ2Vfy3Aad4561w+iQwIPPtNK0IlT6ly8BGdSpfqzfIwfXa4 8AT5XmgXKUhnD57808tMWMYPCb9DSaR5Tt7atHDdZQ/T7WH3VjZ/fhI63GOHH5zkNb7X fdLYVVcV+R/j9JziYujvMFEDBg9qVa+TevQLfREAVKsQtx2vb8Jz0kj19L62au+60s8T bHzw== X-Gm-Message-State: APjAAAVLu58F+hLvRz576zi5v077A6t0Uiw8RcKpNXbB8SyHc/Je5a8F Ec6DTQ1IZG/2QdbYDGhdUVe7xg== X-Google-Smtp-Source: APXvYqy98pg4t1sp1Ruc4Dt9pCitJ9Ggm/5ttuJX5334LlkesJQ+iKR2ogvpIdtO//RCL2mZQwy7UA== X-Received: by 2002:a17:906:c3cb:: with SMTP id cj11mr3077775ejb.132.1559217511538; Thu, 30 May 2019 04:58:31 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:8cad:ae29:555d:852d]) by smtp.gmail.com with ESMTPSA id n15sm393726eja.26.2019.05.30.04.58.30 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 30 May 2019 04:58:30 -0700 (PDT) In-Reply-To: <83pno1xmz1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 May 2019 19:08:18 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159910 Archived-At: Eli Zaretskii writes: >> From: Alex Branham >> Date: Tue, 28 May 2019 15:43:53 -0500 >> >> >From e130dfcb542af667fbef6e6eb867c46eee6d9746 Mon Sep 17 00:00:00 2001 >> From: Alex Branham >> Date: Tue, 28 May 2019 15:40:26 -0500 >> Subject: [PATCH] Avoid a flyspell error if point is at beginning of buffer >> >> * lisp/textmodes/flyspell.el (flyspell-generic-progmode-verify): >> Check if point is at bob. This prevents an error when e.g. >> 'flyspell-auto-correct-word' gets called with point at the >> beginning of the buffer. >> --- >> lisp/textmodes/flyspell.el | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el >> index d18916dfd0..e711fe72b2 100644 >> --- a/lisp/textmodes/flyspell.el >> +++ b/lisp/textmodes/flyspell.el >> @@ -424,8 +424,9 @@ like \"Some." >> (defun flyspell-generic-progmode-verify () >> "Used for `flyspell-generic-check-word-predicate' in programming modes." >> ;; (point) is next char after the word. Must check one char before. >> - (let ((f (get-text-property (- (point) 1) 'face))) >> - (memq f flyspell-prog-text-faces))) >> + (unless (bobp) >> + (let ((f (get-text-property (- (point) 1) 'face))) >> + (memq f flyspell-prog-text-faces)))) > > Maybe it's just me, but whenever I see bobp, I always have to consult > the docs regarding what happens in a narrowed buffer. For that > reason, I prefer comparison with point-min instead. > > Am I the only one troubled by that? I wouldn't say I'm troubled by what bobp does in a narrowed buffer (I would expect it to heed buffer restrictions). Rather, bobp conveys only some property of current state, whereas explicit comparisons to point-min such as (> (point) (point-min)) or (max (point-min) (1- (point))) additionally suggest that subsequent buffer position operations are being guarded from out-of-bounds errors. But that's just my reading into the distinction, so it probably comes down to taste and habits. -- Basil