From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alex Branham <alex.branham@gmail.com>, 35967@debbugs.gnu.org
Subject: bug#35967: [PATCH] avoid flyspell error if point is at bob
Date: Thu, 30 May 2019 12:58:29 +0100 [thread overview]
Message-ID: <87pno0upay.fsf@tcd.ie> (raw)
In-Reply-To: <83pno1xmz1.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 May 2019 19:08:18 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Alex Branham <alex.branham@gmail.com>
>> Date: Tue, 28 May 2019 15:43:53 -0500
>>
>> >From e130dfcb542af667fbef6e6eb867c46eee6d9746 Mon Sep 17 00:00:00 2001
>> From: Alex Branham <alex.branham@gmail.com>
>> Date: Tue, 28 May 2019 15:40:26 -0500
>> Subject: [PATCH] Avoid a flyspell error if point is at beginning of buffer
>>
>> * lisp/textmodes/flyspell.el (flyspell-generic-progmode-verify):
>> Check if point is at bob. This prevents an error when e.g.
>> 'flyspell-auto-correct-word' gets called with point at the
>> beginning of the buffer.
>> ---
>> lisp/textmodes/flyspell.el | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/lisp/textmodes/flyspell.el b/lisp/textmodes/flyspell.el
>> index d18916dfd0..e711fe72b2 100644
>> --- a/lisp/textmodes/flyspell.el
>> +++ b/lisp/textmodes/flyspell.el
>> @@ -424,8 +424,9 @@ like <img alt=\"Some thing.\">."
>> (defun flyspell-generic-progmode-verify ()
>> "Used for `flyspell-generic-check-word-predicate' in programming modes."
>> ;; (point) is next char after the word. Must check one char before.
>> - (let ((f (get-text-property (- (point) 1) 'face)))
>> - (memq f flyspell-prog-text-faces)))
>> + (unless (bobp)
>> + (let ((f (get-text-property (- (point) 1) 'face)))
>> + (memq f flyspell-prog-text-faces))))
>
> Maybe it's just me, but whenever I see bobp, I always have to consult
> the docs regarding what happens in a narrowed buffer. For that
> reason, I prefer comparison with point-min instead.
>
> Am I the only one troubled by that?
I wouldn't say I'm troubled by what bobp does in a narrowed buffer
(I would expect it to heed buffer restrictions).
Rather, bobp conveys only some property of current state, whereas
explicit comparisons to point-min such as (> (point) (point-min)) or
(max (point-min) (1- (point))) additionally suggest that subsequent
buffer position operations are being guarded from out-of-bounds errors.
But that's just my reading into the distinction, so it probably comes
down to taste and habits.
--
Basil
next prev parent reply other threads:[~2019-05-30 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 20:43 bug#35967: [PATCH] avoid flyspell error if point is at bob Alex Branham
2019-05-29 16:08 ` Eli Zaretskii
2019-05-30 11:58 ` Basil L. Contovounesios [this message]
2019-06-11 14:12 ` npostavs
2019-06-11 14:39 ` Eli Zaretskii
2019-06-14 18:17 ` Alex Branham
2019-06-14 18:31 ` npostavs
2019-06-14 18:41 ` Alex Branham
2019-06-14 19:14 ` Andreas Schwab
2019-06-17 19:04 ` Alex Branham
2019-06-18 12:18 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pno0upay.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=35967@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.