From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master dde0320: * lisp/replace.el (replace-highlight): Add save-match-data (bug#36328) Date: Mon, 08 Jul 2019 01:18:21 +0300 Organization: LINKOV.NET Message-ID: <87pnml32vm.fsf@mail.linkov.net> References: <20190705191140.31351.77660@vcs0.savannah.gnu.org> <20190705191141.C019D20552@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="1331"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 08 00:22:24 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hkFY7-0000CG-8L for ged-emacs-devel@m.gmane.org; Mon, 08 Jul 2019 00:22:23 +0200 Original-Received: from localhost ([::1]:37232 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkFY5-0002W2-VH for ged-emacs-devel@m.gmane.org; Sun, 07 Jul 2019 18:22:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54000) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hkFXm-0002VF-I5 for emacs-devel@gnu.org; Sun, 07 Jul 2019 18:22:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hkFXk-0001DZ-0p for emacs-devel@gnu.org; Sun, 07 Jul 2019 18:22:02 -0400 Original-Received: from caracal.birch.relay.mailchannels.net ([23.83.209.30]:23354) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hkFXi-0001Aj-Qv for emacs-devel@gnu.org; Sun, 07 Jul 2019 18:21:59 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B86C9141434; Sun, 7 Jul 2019 22:21:56 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a86.g.dreamhost.com (100-96-83-205.trex.outbound.svc.cluster.local [100.96.83.205]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3E2911405BF; Sun, 7 Jul 2019 22:21:55 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a86.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.3); Sun, 07 Jul 2019 22:21:56 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Whistle-Dime: 62e8405036e1b08e_1562538116519_1902438864 X-MC-Loop-Signature: 1562538116519:1800003404 X-MC-Ingress-Time: 1562538116519 Original-Received: from pdx1-sub0-mail-a86.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a86.g.dreamhost.com (Postfix) with ESMTP id 076638012C; Sun, 7 Jul 2019 15:21:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=DTK2rxvYeDc0pFSfU3m+ZgehOHc=; b= L6fAcu9nxvXC0KCYQ1hNEeeQ0mAz436booDLomRN0beUmP8/NtZiYHB4tBBWPENe nMTDXWhPkqBIZkqEoKn2QDG2KC6MW7MZU6UWJQUpH+U3dECJzFpQyHlbo6MAZApe sLw3KYehaXVmEwXmHR9kZ5sxYHV6UsRuDSEbUMDH9oU= Original-Received: from mail.jurta.org (m91-129-109-127.cust.tele2.ee [91.129.109.127]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a86.g.dreamhost.com (Postfix) with ESMTPSA id 1B0B880168; Sun, 7 Jul 2019 15:21:46 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a86 In-Reply-To: (Stefan Monnier's message of "Fri, 05 Jul 2019 16:24:13 -0400") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrfeelgddtiecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtledruddvjeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdelrdduvdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepmhhonhhnihgvrhesihhrohdruhhmohhnthhrvggrlhdrtggrnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 23.83.209.30 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238400 Archived-At: >> - (isearch-lazy-highlight-new-loop range-beg range-end)))) >> + (save-match-data >> + ;; Preserve match-data for perform-replace since > > Then the save-match-data should be in perform-replace, not here, > I think. This means code duplication, but ok, this will make code cleaner.