From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals Date: Wed, 24 Jul 2019 14:41:17 +0200 Message-ID: <87pnlzzjte.fsf@mouse.gnus.org> References: <20190723171714.15080.69466@vcs0.savannah.gnu.org> <20190723171715.8F064210EC@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="179468"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 24 14:41:35 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqGaN-000kXL-BT for ged-emacs-devel@m.gmane.org; Wed, 24 Jul 2019 14:41:35 +0200 Original-Received: from localhost ([::1]:51288 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqGaM-0004cI-0p for ged-emacs-devel@m.gmane.org; Wed, 24 Jul 2019 08:41:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52773) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqGaE-0004c9-8H for emacs-devel@gnu.org; Wed, 24 Jul 2019 08:41:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqGaD-0006l8-48 for emacs-devel@gnu.org; Wed, 24 Jul 2019 08:41:26 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hqGaC-0006js-Sl for emacs-devel@gnu.org; Wed, 24 Jul 2019 08:41:25 -0400 Original-Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqGa6-0002Om-7G; Wed, 24 Jul 2019 14:41:20 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 23 Jul 2019 15:57:12 -0400") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 80.91.231.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:238866 Archived-At: Stefan Monnier writes: > Actually, they should mostly use `input-decode-map` instead nowadays (the > difference is that `input-decode-map`'s remapping is applied > unconditionally, where `(local-)function-key-map`'s remapping is only > applied when there's no normal keybinding). I've now changed the two instances to refer to input-decode-map (only). >> @smallexample >> ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.} >> -(define-key function-key-map [kp-enter] [?\C-j]) >> +(define-key local-function-key-map [kp-enter] [?\C-j]) > > This remapping should probably be applied to any terminal that has > a kp-enter key, so I think the change is for the worse. Makes sense... but should we then change the bit in the manual that says: @code{local-function-key-map} inherits from @code{function-key-map}, but the latter should not be used directly. Perhaps we should change that to something that says more explicitly what the effect of using function-key-map is? Something like "which should only be used if you want the changes in all terminals"? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no