all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals
Date: Wed, 24 Jul 2019 14:41:17 +0200	[thread overview]
Message-ID: <87pnlzzjte.fsf@mouse.gnus.org> (raw)
In-Reply-To: <jwvef2gttqr.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 23 Jul 2019 15:57:12 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Actually, they should mostly use `input-decode-map` instead nowadays (the
> difference is that `input-decode-map`'s remapping is applied
> unconditionally, where `(local-)function-key-map`'s remapping is only
> applied when there's no normal keybinding).

I've now changed the two instances to refer to input-decode-map (only).

>>  @smallexample
>>  ;; @r{Make the @key{ENTER} key from the numeric keypad act as @kbd{C-j}.}
>> -(define-key function-key-map [kp-enter] [?\C-j])
>> +(define-key local-function-key-map [kp-enter] [?\C-j])
>
> This remapping should probably be applied to any terminal that has
> a kp-enter key, so I think the change is for the worse.

Makes sense...  but should we then change the bit in the manual that
says:

@code{local-function-key-map} inherits from @code{function-key-map},
but the latter should not be used directly.

Perhaps we should change that to something that says more explicitly
what the effect of using function-key-map is?  Something like "which
should only be used if you want the changes in all terminals"?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



  reply	other threads:[~2019-07-24 12:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190723171714.15080.69466@vcs0.savannah.gnu.org>
     [not found] ` <20190723171715.8F064210EC@vcs0.savannah.gnu.org>
2019-07-23 19:57   ` [Emacs-diffs] master 9a83ecb: Refer to local-function-key-map in various manuals Stefan Monnier
2019-07-24 12:41     ` Lars Ingebrigtsen [this message]
2019-07-24 13:52       ` Stefan Monnier
2019-07-25  9:53         ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnlzzjte.fsf@mouse.gnus.org \
    --to=larsi@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.