From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Alex Branham Newsgroups: gmane.emacs.bugs Subject: bug#34330: 27.0.50; shell auto-complete cannot handle special characters Date: Fri, 23 Aug 2019 11:02:48 -0500 Message-ID: <87pnkv6f9z.fsf@gmail.com> References: <87zhkav2e4.fsf@gmail.com> <87sgq2v27l.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="85397"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Tadeus Prastowo , 34330@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 23 18:10:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1C8o-000M1o-I3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 18:10:18 +0200 Original-Received: from localhost ([::1]:58962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1C8m-000659-BM for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Aug 2019 12:10:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40731) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1C2m-0001Fa-7Z for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 12:04:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1C2l-0002eA-3O for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 12:04:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60455) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1C2k-0002dD-BO for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 12:04:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1C2k-0007Br-6I for bug-gnu-emacs@gnu.org; Fri, 23 Aug 2019 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Alex Branham Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Aug 2019 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34330 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 34330-submit@debbugs.gnu.org id=B34330.156657618227513 (code B ref 34330); Fri, 23 Aug 2019 16:04:02 +0000 Original-Received: (at 34330) by debbugs.gnu.org; 23 Aug 2019 16:03:02 +0000 Original-Received: from localhost ([127.0.0.1]:41043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1C1l-00079a-Gs for submit@debbugs.gnu.org; Fri, 23 Aug 2019 12:03:01 -0400 Original-Received: from mail-oi1-f170.google.com ([209.85.167.170]:45323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1C1j-00079F-8b for 34330@debbugs.gnu.org; Fri, 23 Aug 2019 12:02:59 -0400 Original-Received: by mail-oi1-f170.google.com with SMTP id v12so7365304oic.12 for <34330@debbugs.gnu.org>; Fri, 23 Aug 2019 09:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=qCCrQ+KUCxTbZw+GqZtA9/ttunyhzp2lQUm+hiZsUBM=; b=fI5Edk9TVrZepGHjiuChysT3mY8QNYoFWs3MJWQXULMe0pqC85R0rBPzSiLeuVMMou Q0DxU6cjY5cLpSAtAuZI9xjjuaOZnsdjZQB3EdeJFBwRhfaKMeCaQ798vIeo9EMIjfIg 3TUFNz4TrS4Hob/O46w9jRi4A0RHhNxDyJbiNV1zHOvF//D41hCPh4kL+lwyAKcd4n/9 F76BR0j5pB8tppvGGUiVWeVl2DsgUMpoRQaGJcv51IBU3iYoqQeeC5tcaMscnsH/rfJj XjgiOd2sAt1zUlFsAetovPGtcAzPO49BjqEROiW1rLCyHs+jwgv/NCIqx/PwfSErJ+Al QZLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=qCCrQ+KUCxTbZw+GqZtA9/ttunyhzp2lQUm+hiZsUBM=; b=BgwaWgEXdH+QcX14WQrKka+5pftLQTnTjeQuGjKrR9bkP0yzSta0wXIcVAGM4YSh9r IEVjk0nfNlmkgFEeb2QbYSsGxar/lTURJ3vEhHiGRzlGHqfVVpChMkiCwDRzXsZt0phS w/lTQCLiB1BS/Z3TbE7Um9a1mlhkXSPkQi9pKs+1giPmQ/xM1RQdgDztfkozGrzwZMMc mkeG+Unh4Vzd+3I+c9EOTY301RqVH38U3s9MYm2rPGcVFq+7hhB1vv8kGcMoZy5Hhz6h Zxwlolx/J4YGPaNdsuH40aQnR5aal31xMvfrkQGB9TNjxWIqljq5KPGyAshKzeF32osH kYAA== X-Gm-Message-State: APjAAAUBp8CzxcTj2TZ3HoiRXWD2xJjAuJQGdKe3tWSP/psrJRkCufba tQcRXB6CLyaj52xxUt8iRPzBT9Nfktc= X-Google-Smtp-Source: APXvYqxHwdvfdJ9fH7+mkD01deqMQJGTgxnTL7++NBV1kinbetv1Fl3Vm+Ji4mjdCdhXO7YIJJIwDw== X-Received: by 2002:aca:4d85:: with SMTP id a127mr3624381oib.3.1566576172673; Fri, 23 Aug 2019 09:02:52 -0700 (PDT) Original-Received: from mars (cpe-70-114-192-208.austin.res.rr.com. [70.114.192.208]) by smtp.gmail.com with ESMTPSA id y88sm1136110ota.32.2019.08.23.09.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Aug 2019 09:02:49 -0700 (PDT) In-Reply-To: <87sgq2v27l.fsf@gmail.com> (Alex Branham's message of "Thu, 15 Aug 2019 11:10:54 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165700 Archived-At: > On Thu 15 Aug 2019 at 11:06, Alex Branham wrote: Is this OK to apply to master to fix the issue with completion of filenames? Alex > >>>From 1af4915f3dc774b4fb53e2b52b1318f4b52b7ba3 Mon Sep 17 00:00:00 2001 > From: Alex Branham > Date: Thu, 15 Aug 2019 11:02:38 -0500 > Subject: [PATCH] Fix filename completion in shell mode buffers > > * lisp/shell.el (shell-dynamic-complete-functions): Move > pcomplete-completions-at-point down the list so that filename > completion has a chance to complete before pcompletion. > > Fixes bug#34330 > --- > lisp/shell.el | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lisp/shell.el b/lisp/shell.el > index 2914d1d2c8..889602d26e 100644 > --- a/lisp/shell.el > +++ b/lisp/shell.el > @@ -184,14 +184,15 @@ shell buffer. The value may depend on the operating system or shell." > shell-environment-variable-completion > shell-command-completion > shell-c-a-p-replace-by-expanded-directory > - pcomplete-completions-at-point > shell-filename-completion > - comint-filename-completion) > + comint-filename-completion > + pcomplete-completions-at-point) > "List of functions called to perform completion. > This variable is used to initialize `comint-dynamic-complete-functions' in the > shell buffer." > :type '(repeat function) > - :group 'shell) > + :group 'shell > + :version "27.1") > > (defcustom shell-command-regexp "[^;&|\n]+" > "Regexp to match a single command within a pipeline.