From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#37592: Using tabs in EWW Date: Fri, 04 Oct 2019 01:39:42 +0300 Organization: LINKOV.NET Message-ID: <87pnjdh1up.fsf@mail.linkov.net> References: <87r23uga96.fsf@mail.linkov.net> <83zhii7dkk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="18419"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 37592@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 04 01:44:07 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iGAlS-0004dG-Te for geb-bug-gnu-emacs@m.gmane.org; Fri, 04 Oct 2019 01:44:07 +0200 Original-Received: from localhost ([::1]:41213 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGAlR-0000kc-BH for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Oct 2019 19:44:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54302) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGAOF-0003Ei-7C for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 19:20:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGAOB-0000bh-BX for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 19:20:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60861) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGAOA-0000bV-R8 for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 19:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iGAOA-0006ZA-GN for bug-gnu-emacs@gnu.org; Thu, 03 Oct 2019 19:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 23:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37592 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37592-submit@debbugs.gnu.org id=B37592.157014477225181 (code B ref 37592); Thu, 03 Oct 2019 23:20:02 +0000 Original-Received: (at 37592) by debbugs.gnu.org; 3 Oct 2019 23:19:32 +0000 Original-Received: from localhost ([127.0.0.1]:41446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGANf-0006Y5-NB for submit@debbugs.gnu.org; Thu, 03 Oct 2019 19:19:31 -0400 Original-Received: from buffalo.birch.relay.mailchannels.net ([23.83.209.24]:32799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iGANd-0006Xr-TE for 37592@debbugs.gnu.org; Thu, 03 Oct 2019 19:19:30 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id BAABD500D40; Thu, 3 Oct 2019 23:19:27 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a97.g.dreamhost.com (100-96-14-189.trex.outbound.svc.cluster.local [100.96.14.189]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0FF15500F50; Thu, 3 Oct 2019 23:19:27 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a97.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Thu, 03 Oct 2019 23:19:27 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thoughtful-Name: 3b6555e60c6a3f7e_1570144767271_4200664881 X-MC-Loop-Signature: 1570144767271:2504952015 X-MC-Ingress-Time: 1570144767271 Original-Received: from pdx1-sub0-mail-a97.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a97.g.dreamhost.com (Postfix) with ESMTP id 938627F688; Thu, 3 Oct 2019 16:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=1SnHwPqBE9XmHihrgAkJdBWug8A=; b= y7RsRJ62xP4/SEAZLtJxAzDfp14fbANYDiFmn02PZ1KnTCDzK2pLIJ6SW/NTWWp9 pBdPXZPjWYjZF0pxDByfYCQrAYsDuvzT6VFWL0Nv4CupODWyXibUVnlUX2vDSY8n WVy/VOx41ae9yQQg5Vu4rDEPfpWHboArrDICbOXi5Mk= Original-Received: from mail.jurta.org (m91-129-99-99.cust.tele2.ee [91.129.99.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a97.g.dreamhost.com (Postfix) with ESMTPSA id CD1C97F682; Thu, 3 Oct 2019 16:19:17 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a97 In-Reply-To: <83zhii7dkk.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 03 Oct 2019 05:44:27 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrgeelgddvudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleelrdelleenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdelledrleelpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepvghlihiisehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168293 Archived-At: >> Like in web browsers opens links in a new tab, >> the attached patch does the same for EWW. >> >> The change that implements support for tabs in EWW is just 3 lines: >> >> (when eww-browse-url-new-window-is-tab >> (let ((tab-bar-new-tab-choice t)) >> (tab-new))) >> >> Everything else is replicating the existing code: >> >> 1. A new defcustom eww-browse-url-new-window-is-tab is a copy >> of existing browse-url-firefox-new-window-is-tab >> >> 2. The docstring for eww-browse-url is copied from browse-url-firefox >> >> 3. The code for shr-browse-url is copied from browse-url-at-point > > Instead of adding another defcustom, how about doing this by default > if tab-bar-mode is enabled? I guess the users still need to decide whether they want to open new tabs in the tab-bar (when eww-browse-url-new-window-is-tab is non-nil), or new tabs in the tab-line (when eww-browse-url-new-window-is-tab is nil) that just creates a new buffer displayed in the window-local tab-line - this is the current behavior. Another use case is that when tab-bar-mode is not yet enabled, users migth prefer that clicking on a link with a Ctrl key could enable the tab-bar and open a new tab in automatically enabled tab-bar.