From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ingo Lohmar Newsgroups: gmane.emacs.devel Subject: Re: :extend t inheritance Date: Sat, 26 Oct 2019 10:55:41 +0200 Message-ID: <87pnijkhrm.fsf@kenko.localhost.com> References: <87zhhrmcaq.fsf@kenko.localhost.com> <83o8y6xnmn.fsf@gnu.org> <20191026014911.7riwc5oq6epjhdiq@Ergus> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="25509"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 26 10:56:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOHsK-0006Se-0q for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 10:56:44 +0200 Original-Received: from localhost ([::1]:39256 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOHsI-0008SP-UO for ged-emacs-devel@m.gmane.org; Sat, 26 Oct 2019 04:56:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53127) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOHrT-0008Jl-O9 for emacs-devel@gnu.org; Sat, 26 Oct 2019 04:55:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOHrS-0004da-8c for emacs-devel@gnu.org; Sat, 26 Oct 2019 04:55:51 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:56620) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iOHrR-0004cx-QA for emacs-devel@gnu.org; Sat, 26 Oct 2019 04:55:50 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id D5ABC160062 for ; Sat, 26 Oct 2019 10:55:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1572080146; bh=VPI13xOqbj/Zr5+1bYDSxg6Cgy/RorP9mPQaZkRkk98=; h=From:To:Cc:Subject:Date:From; b=LbJnT7Q2jgh8IecE3DyjDp7RiDdZ6+tNhFvvSFEClbcLS0DHvDwZDBc5ZKJ1R1nCK u9tS6WPh4nPLzML042RR0a/jk7PoghJGxsItAdF3HyJvkSN33proyCImMUyhWYEGbM F9eJSoHeoqH7QRjd3t+2lwsN/DuFjNu80PRZ6xtXbkGAb7xhTCF5ct8aDnhaRumjjA 1rqLjLtD7m2KWMOySGHKQoCJHYZ7CLxN5AgSAA/Oah1SyVaWmmPPZM4LNcBifqVU1N Ug/Q+uDwAUE+DfyZZ68sd5mCkviAUKNsu4oUD6yNMtjV6yotDO7PVdchkcUnZZGQhi tz86adKZnKo0Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 470ZZP4mP3z6tmB; Sat, 26 Oct 2019 10:55:41 +0200 (CEST) In-Reply-To: <20191026014911.7riwc5oq6epjhdiq@Ergus> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 185.67.36.65 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241433 Archived-At: On Sat, Oct 26 2019 03:49 (+0200), Ergus wrote: > Hi: > > I just added a branch `fix/inherit_extend_face` that fixes the issue > with inheritance of the extend attribute with filter condition. > > There are two commits because I also detected another issue in gui I > didn't see before because I don't use gui normally. > > Please give it a look and if everything is fine I'll move it to master > ASAP. Thanks, I just tried the branch and continued customizing my face settings: No everything works as I would expect from inheritance. I did not see any adverse effects of the changes either, but I only used it for about an hour. Looking forward to the changes being merged! BTW: there seem to be some whitespace-only hunks in the changes..