bug#37973: 26.2; Entertaining comments in admin.el

bug#37973: 26.2; Entertaining comments in admin.el

[Rolf Ade]

Note the date and "only briefly present". Is there something not
finished but got forgotten?

commit 0d613483907fc9b053de10dfb0377f2b67eac682
Author: Glenn Morris <rgm@gnu.org>
Date:   Thu Jan 16 21:11:36 2014 -0500

    Make M-x authors return zero *Authors Errors* from current logs
    
    * lisp/emacs-lisp/authors.el (authors-obsolete-files-regexps):
    (authors-ignored-files): Add some entries, remove others.
    (authors-ambiguous-files, authors-valid-file-names): Add some entries.
    (authors-renamed-files-alist): Add, remove, and adjust entries.
    (authors-renamed-files-regexps): Add some entries.
    Remove some very broad ones.  Make some entries `lax'.
    (authors-lax-changelogs): New constant.
    (authors-disambiguate-file-name): Treat top-level specially.
    (authors-lax-changelog-p): New function.
    (authors-canonical-file-name): Check file as written against
    authors-valid-file-names.  Do not special-case etc/.
    Handle `lax' logs and authors-renamed-files-regexps elements.
    
    * admin/make-tarball.txt: Update for no expected *Authors Errors*.

diff --git a/lisp/emacs-lisp/authors.el b/lisp/emacs-lisp/authors.el
--- a/lisp/emacs-lisp/authors.el
+++ b/lisp/emacs-lisp/authors.el
@@ -280,0 +283,2 @@
+    ;; Only briefly present.
+    "tests/gnustest-nntp.el" "tests/gnustest-registry.el"


Even more so here: "only installed very briefly" and not touched for 10
years.

commit 1fc28a2c9d6d862fabfc7e8deb01d6563253b2fc
Author: Glenn Morris <rgm@gnu.org>
Date:   Wed Sep 30 02:27:10 2009 +0000

    (authors-ignored-files): Add "js2-mode.el".

diff --git a/lisp/emacs-lisp/authors.el b/lisp/emacs-lisp/authors.el
--- a/lisp/emacs-lisp/authors.el
+++ b/lisp/emacs-lisp/authors.el
@@ -246,0 +246,1 @@
+    "js2-mode.el"      ; only installed very briefly, replaced by js.el

bug#37973: 26.2; Entertaining comments in admin.el

[Glenn Morris]

No, I see nothing unfinished or forgotten (or entertaining...) there.

bug#37973: 26.2; Entertaining comments in admin.el

[Eli Zaretskii]

> From: Glenn Morris <rgm@gnu.org>
> Date: Mon, 28 Oct 2019 21:07:39 -0400
> Cc: 37973@debbugs.gnu.org
> 
> 
> No, I see nothing unfinished or forgotten (or entertaining...) there.

Neither do I.

authors.el is supposed to pick up every contribution to Emacs, even if
it was only briefly present in the codebase.

bug#37973: 26.2; Entertaining comments in admin.el

[Rolf Ade]

Eli Zaretskii <eliz@gnu.org> writes:
>> From: Glenn Morris <rgm@gnu.org>
>> 
>> No, I see nothing unfinished or forgotten (or entertaining...) there.
>
> Neither do I.
>
> authors.el is supposed to pick up every contribution to Emacs, even if
> it was only briefly present in the codebase.

Please accept my apologise; clearly I misunderstood the code and
comment. I'm sorry for the noise.

The comments say, that the files with that name were only briefly part
of the source tree (and not that the code lines should only be briefly
part of the code). In hindsight that's obvious, even to me ...

bug#37973: 26.2; Entertaining comments in admin.el

[Eli Zaretskii]

> From: Rolf Ade <rolf@pointsman.de>
> Cc: Glenn Morris <rgm@gnu.org>,  37973@debbugs.gnu.org
> Date: Wed, 30 Oct 2019 18:51:39 +0100
> 
> > authors.el is supposed to pick up every contribution to Emacs, even if
> > it was only briefly present in the codebase.
> 
> Please accept my apologise; clearly I misunderstood the code and
> comment. I'm sorry for the noise.

No need to be sorry.  Anyone could make a mistake.