From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Thu, 21 Nov 2019 22:15:21 +0100 Message-ID: <87pnhl9biu.fsf@gmx.net> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="134298"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: larsi@gnus.org, Dmitry Gutov , 38044@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 22:16:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXtoU-000YoP-UB for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 22:16:31 +0100 Original-Received: from localhost ([::1]:45876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXtoT-0003y1-Ip for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 16:16:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48601) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXto4-0003xq-Ob for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:16:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXto3-00089b-Jw for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:16:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXto3-00089U-Gj for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:16:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXto2-0002zH-Bi for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157437094611455 (code B ref 38044); Thu, 21 Nov 2019 21:16:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 21:15:46 +0000 Original-Received: from localhost ([127.0.0.1]:53396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtnl-0002yh-RI for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:15:46 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:44281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtng-0002yO-PN for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 16:15:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1574370927; bh=sKqHobDPKSwtnq4jeCXqPnUNg8jWKZu23uH12PDosO0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=izVfn16y0h3qTrVoprZQ2+XRaWYvA5GUnHMHEWGtv2wwFh60X5mjQKrGqbGqYyefd 7zZBA7w23jEqeT1Ni71wrkFDUaM6wxlMv597H0WPyCsGgJbokAN2Pvy/4tgLAzezL8 p1QYoNLt6puoTgVgguEf88R8LUxGBX0R5JnqN69s= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-lfs84 ([92.78.62.223]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McYCl-1hzvYQ0Z01-00d1NV; Thu, 21 Nov 2019 22:15:27 +0100 In-Reply-To: <837e3tx9s8.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Nov 2019 22:19:03 +0200") X-Provags-ID: V03:K1:Ag2iJx3jjsdaLWp0uiUguW9GaLj5uUTCnx5LvNiqal2/YOS3MUE /3odyiCRu3z7nW1OBme6vI8H/iekMCpASnwxSaxZkpxh+XCnRRuYT1qN7Esfma6HP2NgPG8 AZ+vs7KXTQIKNRpdRJgbE36MpVZKPslTDqqstOEKO9AmlxvNVZFVRlwMRBbTRXry56QL26i 1cayell6ormaU7ZSItrcg== X-UI-Out-Filterresults: notjunk:1;V03:K0:xG1T4DlSe1k=:mq4Rvyo4QpKVRftqmdqIGb KioCd7a+Lez+nmF2ZbM7T72qVeayfvhVPuRXKTaL/+v04K+tqbJpKlhTEn/PgK5U/XwCkQs18 j1/2JgPQX74y+34zOg4HwWTLu17z/tajADPQfe/SffkwWejM7QQ8b15hFF/Amlf0dYs3VT+Gf C+6aHAuh/Wby9BNvDQ70JSQCntBjd8BdiP6Z464l0BX2IIUwOJyq/d9a7I4I5xAIZoVJaUSE8 OoBio+q6NvGawX4NOpervc/umsY6V3U36aszaa2IJZSw2W6GXSZgIwQVrp3Kl0OBr4PK/6CEz LJSBs+xkZySO8BP6OFV9milbP2nGbgxvt7FugfykyseD+LS7vulqps3qoBFeaqjhR+r8fqsMd KMrjwkOeqIip8hW4y4cvrqrGw72TIGou+nP4zeCmEXNDph004k4XHq4HRGlIHZX/jgtxlxDSO xtLiQTb3wAk0l/jU6ZaIZA15+Fid0qC+d0SnKmSjbS592+Re9FAbxbaMOUWXoEL4J7UKnQPuS 1p5e+0FlDnO3suJcDLWMTy1CnAQE7qmIxVfbvoeaZwz/kjL+MvW3Eb/iOJr14JeQpz4kO6BVO Zmdh3L8PsrQlaelklMFdmj6/SQEdfa+wvoJfV5jPa8UyUi3KkQTB+98w0w46y7L2QC5rwE+NH j8E8mLymraKE1FccER+LSFaGPbeXUQbB93Xf4/qeajg7fih9cS/tvHZo5g4YRtn3/QMe0cFxO hRir8LvxIaHm27xhWFwATlwUylrfOJxiZnD+YwrWmGSuKf1poESFldZYY8nmr5tY3nYrMEb3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172162 Archived-At: On Thu, 21 Nov 2019 22:19:03 +0200 Eli Zaretskii wrote: >> Cc: juri@linkov.net, larsi@gnus.org, stephen.berman@gmx.net, >> 38044@debbugs.gnu.org >> From: Dmitry Gutov >> Date: Thu, 21 Nov 2019 21:08:49 +0200 >> >> "As I said before", when a revision is created, we fill in a number of >> different fields, most importantly, the commit message. That's in every >> VCS except some ancient ones. So to show a revision means to show all >> that stuff. > > Here's an alternative proposal. It seems like almost all VCS backends > we support provide a variant of a "log" command that shows the diffs > together with the usual meta-data shown by "log". Only RCS and CVS > don't have such an option of "log", all the rest do (most of them via > "log -p"). > > So we could make this a subcommand of vc-log, more accurately > vc-print-root-log, such that "C-u C-u C-x v L" will prompt for a > revision ID, and display the information produced by such a "log -p" > command (and fall back to displaying just the diffs for RCS and CVS). > > Does this sound better? If it's to be assigned to an existing VC command and key binding, I think `log' is better than `diff' (FWIW, I named the git-specific command I wrote for myself, posted near the top of this thread, srb-git-log). However, I'm not thrilled with the thought of having to type two prefix keys to invoke it. Since one of the desiderata of this command, perhaps even the main one, is that it should act on the revision ID at point, how about making just `C-x v L' do that if it recognizes the word at point as a revision ID? If this is deemed to unreliable, it could be conditioned by a user option, or perhaps (though more annoying) by asking for confirmation. Steve Berman