From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38282: 26.3; goto-line should not share input history with other commands Date: Fri, 22 Nov 2019 13:09:06 +0100 Message-ID: <87pnhkt8nx.fsf@gnus.org> References: <877e3va66f.fsf@gmail.com> <871ru1z6ax.fsf@gnus.org> <878so9uugg.fsf@gmx.de> <87h82xw21s.fsf@gnus.org> <87imndkr3f.fsf@gmail.com> <87a78olwa1.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="141329"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38282@debbugs.gnu.org, Robert Pluim , Michael Albinus To: Federico Tedin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 13:10:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iY7lO-000adt-UJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 13:10:15 +0100 Original-Received: from localhost ([::1]:50056 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY7lN-0008L1-Mx for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 07:10:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44483) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY7lH-0008Kv-ST for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 07:10:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iY7lC-0001zi-UL for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 07:10:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45038) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iY7lC-0001ze-Qx for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 07:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iY7lC-0006HS-Ja for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 07:10:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2019 12:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38282 X-GNU-PR-Package: emacs Original-Received: via spool by 38282-submit@debbugs.gnu.org id=B38282.157442456124086 (code B ref 38282); Fri, 22 Nov 2019 12:10:02 +0000 Original-Received: (at 38282) by debbugs.gnu.org; 22 Nov 2019 12:09:21 +0000 Original-Received: from localhost ([127.0.0.1]:53859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY7kU-0006GN-Uw for submit@debbugs.gnu.org; Fri, 22 Nov 2019 07:09:20 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:47826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY7kT-0006G6-6A for 38282@debbugs.gnu.org; Fri, 22 Nov 2019 07:09:17 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iY7kJ-0002ko-LB; Fri, 22 Nov 2019 13:09:10 +0100 In-Reply-To: <87a78olwa1.fsf@gmail.com> (Federico Tedin's message of "Thu, 21 Nov 2019 23:06:14 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172220 Archived-At: Federico Tedin writes: > + ;; It would be better to use `goto-line-history' as a HIST > + ;; parameter to `read-from-minibuffer' (through > + ;; `read-number'), but using buffer-local variables > + ;; doesn't work for that purpose. (Bug#38317) > + (minibuffer-history > + (buffer-local-value 'goto-line-history (or buffer > + (current-buffer))))) I think a per-buffer history for goto-line makes sense, but I was also wondering whether read-number should have its own separate history, too. This would, I think, not interoperate well with that (that is, if `read-number' passes a different variable to read-from-minibuffer than nil). So I think a better solution would be to fix the problem with buffer-local variables not working in read-from-minibuffer first, and then we could extend read-number with a history parameter instead of hacking around the problem this way. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no